Page MenuHomeWildfire Games
Differential D480

Macedonian team bonus
ClosedPublic
Actions

Authored by fatherbushido on May 12 2017, 12:14 PM.
Tags
None
Referenced Files
F5208095: D480.id1895.diff
Thu, Sep 19, 1:34 AM
Unknown Object (File)
Sat, Sep 14, 7:37 PM
Unknown Object (File)
Sun, Sep 8, 10:26 PM
Unknown Object (File)
Sun, Sep 8, 5:27 PM
Unknown Object (File)
Sun, Sep 8, 10:25 AM
Unknown Object (File)
Wed, Sep 4, 1:43 AM
Unknown Object (File)
Fri, Aug 30, 11:28 PM
Unknown Object (File)
Fri, Aug 30, 10:17 PM
View All 15 Files
Subscribers
Vulcan

Details

Reviewers
mimo
Summary

Needs D478

Test Plan

-

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1825
Build 2894: Vulcan BuildJenkins
Build 2893: arc lint + arc unit

Event Timeline

fatherbushido created this revision.May 12 2017, 12:14 PM
Vulcan added a subscriber: Vulcan.May 12 2017, 2:59 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1161/ for more details.

Harbormaster completed remote builds in B1666: Diff 1869.May 12 2017, 2:59 PM
fatherbushido updated this revision to Diff 1894.May 13 2017, 8:34 AM

use sell instead of buy

Harbormaster completed remote builds in B1692: Diff 1894.May 13 2017, 8:34 AM
fatherbushido updated this revision to Diff 1895.May 13 2017, 8:36 AM

remove unrelated changes

Harbormaster completed remote builds in B1693: Diff 1895.May 13 2017, 8:36 AM
Vulcan added a comment.May 13 2017, 9:51 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1179/ for more details.

Harbormaster completed remote builds in B1692: Diff 1894.May 13 2017, 9:51 AM
Vulcan added a comment.May 13 2017, 10:38 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1180/ for more details.

Harbormaster completed remote builds in B1693: Diff 1895.May 13 2017, 10:38 AM
fatherbushido mentioned this in D502: Add missing team bonuses.May 15 2017, 2:21 PM
fatherbushido mentioned this in D460: Update teamboni in civ.jsons.May 16 2017, 7:21 AM
fatherbushido updated this revision to Diff 2036.May 19 2017, 9:09 PM

update for D478

fatherbushido mentioned this in D478: Barter modifications.May 19 2017, 9:14 PM
fatherbushido updated this revision to Diff 2039.May 19 2017, 9:52 PM

revert

fatherbushido added a reviewer: mimo.May 19 2017, 9:54 PM
Vulcan added a comment.May 20 2017, 2:35 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1259/ for more details.

Harbormaster completed remote builds in B1812: Diff 2036.May 20 2017, 2:35 AM
Vulcan added a comment.May 20 2017, 4:55 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1262/ for more details.

Harbormaster completed remote builds in B1815: Diff 2039.May 20 2017, 4:55 AM
mimo edited edge metadata.May 20 2017, 9:55 AM

Patch is fine, but i wonder if well balanced compared to other team bonuses. Maybe increase it to 1.15 or 1.20?

fatherbushido added a comment.May 20 2017, 12:46 PM
In D480#21116, @mimo wrote:

Patch is fine, but i wonder if well balanced compared to other team bonuses. Maybe increase it to 1.15 or 1.20?

sure, 1.20 sounds good

fatherbushido updated this revision to Diff 2051.May 20 2017, 6:50 PM

tweak balance

mimo accepted this revision.May 20 2017, 6:54 PM
mimo added inline comments.
binaries/data/mods/public/simulation/data/auras/teambonuses/mace_player_teambonus.json
13

tooltip should be changed too

This revision is now accepted and ready to land.May 20 2017, 6:54 PM
fatherbushido updated this revision to Diff 2052.May 20 2017, 6:55 PM

fix tooltip

Harbormaster completed remote builds in B1825: Diff 2052.May 20 2017, 6:55 PM
Vulcan added a comment.May 20 2017, 8:11 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1269/ for more details.

Harbormaster completed remote builds in B1824: Diff 2051.May 20 2017, 8:11 PM
fatherbushido closed this revision.May 20 2017, 9:34 PM

closed by rP19616

Vulcan added a comment.May 20 2017, 9:58 PM

Build has FAILED

Link to build: http://jw:8080/job/phabricator/1271/
See console output for more information: http://jw:8080/job/phabricator/1271/console

Harbormaster failed remote builds in B1825: Diff 2052!May 20 2017, 9:58 PM

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
simulation/
data/
auras/
teambonuses/
13 lines
templates/
special/
6 lines

Diff 2052

View Options

binaries/data/mods/public/simulation/data/auras/teambonuses/mace_player_teambonus.json

Loading...
View Options

binaries/data/mods/public/simulation/templates/special/player_mace.xml

Loading...
Wildfire Games · Phabricator