Page MenuHomeWildfire Games
Differential D502

Add missing team bonuses
ClosedPublic
Actions

Authored by fatherbushido on May 15 2017, 2:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 14, 7:41 PM
Unknown Object (File)
Sun, Sep 8, 5:16 PM
Unknown Object (File)
Sun, Sep 8, 2:08 AM
Unknown Object (File)
Sat, Sep 7, 6:43 PM
Unknown Object (File)
Sat, Aug 31, 8:04 PM
Unknown Object (File)
Sat, Aug 31, 8:04 PM
Unknown Object (File)
Sat, Aug 31, 8:03 PM
Unknown Object (File)
Sat, Aug 31, 8:03 PM
View All 20 Files
Subscribers
borg-
elexis
Grugnas
Hannibal_Barca
Vulcan

Details

Reviewers
elexis
Commits
rP19591: Team bonuses for Britons, Gauls and Romans. Reviewed by elexis. Refs #4082.
Summary

Romans: the first one in dd, https://trac.wildfiregames.com/wiki/Civ%3A_Romans_Republican?version=1#TEAMBONUS
Brits: http://trac.wildfiregames.com/wiki/Civ%3A_Britons#TEAMBONUS
Gauls: https://trac.wildfiregames.com/wiki/Civ%3A_Gauls#TEAMBONUS

Add a slight difference between Brits and Gauls. (http://www.perseus.tufts.edu/hopper/text?doc=Perseus%3Atext%3A1999.02.0001%3Abook%3D6%3Achapter%3D13 is interesting to read).

(D480 will remain.)

Test Plan

Can be tested in games, else if effect seems to weak effect could be increase (or later).

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fatherbushido created this revision.May 15 2017, 2:10 PM
fatherbushido updated this revision to Diff 1943.May 15 2017, 2:11 PM

Typos

fatherbushido updated this revision to Diff 1944.May 15 2017, 2:12 PM

typos again

fatherbushido edited the summary of this revision. (Show Details)May 15 2017, 2:21 PM
Vulcan added a subscriber: Vulcan.May 15 2017, 3:27 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1211/ for more details.

Harbormaster completed remote builds in B1737: Diff 1942.May 15 2017, 3:27 PM
Vulcan added a comment.May 15 2017, 4:24 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1212/ for more details.

Harbormaster completed remote builds in B1738: Diff 1943.May 15 2017, 4:24 PM
Vulcan added a comment.May 15 2017, 5:11 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1213/ for more details.

Harbormaster completed remote builds in B1739: Diff 1944.May 15 2017, 5:11 PM
elexis edited a custom field.May 15 2017, 6:15 PM
elexis added a subscriber: elexis.May 15 2017, 6:19 PM

Patch is correct with regards to being historically reasoned and gameplay-wise balanced. Didn't test whether the proposed effects actually work yet.
Patch is complete since we have them for all other civs except macedonia.

binaries/data/mods/public/simulation/data/auras/teambonuses/brit_player_teambonus.json
12 ↗(On Diff #1943)

A healer costs 250 food, with this only 200, so it's good.

binaries/data/mods/public/simulation/data/auras/teambonuses/gaul_player_teambonus.json
10 ↗(On Diff #1943)

This one doesn't really have an influence. Could reduce resource costs for techs too.

binaries/data/mods/public/simulation/data/auras/teambonuses/rome_player_teambonus.json
9 ↗(On Diff #1943)

-20%? Mostly thinking about that seleucid team bonus which seems huge in comparison.

"for infantry of allied players" or
"for allied infantry"

elexis added a reviewer: elexis.May 15 2017, 6:21 PM
elexis edited the summary of this revision. (Show Details)
elexis edited edge metadata.May 15 2017, 6:26 PM
elexis added subscribers: borg-, Grugnas, Hannibal_Barca.

Pinging the mob in case someone has dug up some important historical fact that would revolutionize the way team games are played @Grugnas @borg- @Hannibal_Barca .

fatherbushido added inline comments.May 15 2017, 7:03 PM
binaries/data/mods/public/simulation/data/auras/teambonuses/brit_player_teambonus.json
12 ↗(On Diff #1943)

ok

binaries/data/mods/public/simulation/data/auras/teambonuses/gaul_player_teambonus.json
10 ↗(On Diff #1943)

ok
-10% then

binaries/data/mods/public/simulation/data/auras/teambonuses/rome_player_teambonus.json
9 ↗(On Diff #1943)

ok

fatherbushido updated this revision to Diff 1953.May 15 2017, 10:12 PM

adress elexis remarks

Harbormaster completed remote builds in B1749: Diff 1953.May 15 2017, 10:12 PM
fatherbushido updated this revision to Diff 1954.May 15 2017, 10:13 PM

add eol stuff again

fatherbushido updated this revision to Diff 1955.May 15 2017, 10:14 PM

Forgot a dot at end of line.

Harbormaster completed remote builds in B1751: Diff 1955.May 15 2017, 10:14 PM
Vulcan added a comment.May 16 2017, 12:44 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1219/ for more details.

Harbormaster completed remote builds in B1749: Diff 1953.May 16 2017, 12:44 AM
Vulcan added a comment.May 16 2017, 2:18 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1220/ for more details.

Harbormaster completed remote builds in B1750: Diff 1954.May 16 2017, 2:18 AM
Vulcan added a comment.May 16 2017, 4:00 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1221/ for more details.

Harbormaster completed remote builds in B1751: Diff 1955.May 16 2017, 4:00 AM
elexis accepted this revision.May 16 2017, 4:14 AM

Tested it successfully.

Agree with causative that the user really must have a way to read the team bonuses. So we should fix that one entry in the civ files.

The other team bonuses could use a little polishing IMO:

  • The sparta 10% health one for citizen soldiers could be buffed to 20%.
  • Since one doesn't build many CCs at all, the seleucid bonus could be increased
  • The athen bonus doesn't seem that useful to me, it could add a small wood cost bonus to ships maybe
binaries/data/mods/public/simulation/data/auras/teambonuses/gaul_player_teambonus.json
10 ↗(On Diff #1943)

Sorry, I thought this is only about temple technologies. This changes things a lot!

Compared to the iberian bonus (100 skirmishers * 10 food, 10 wood each = 1000 food 1000 wood saved), this would likely still be too much. You can revert to the 20% speed bonus for all techs if you want or go down to 5% cost.

binaries/data/mods/public/simulation/data/auras/teambonuses/rome_player_teambonus.json
9 ↗(On Diff #1943)

This number was discussed widely with Grugnas (who has the impression it is too much), Hannibal (no response) and causative (agrees it's about equal to the iberian (not seleucid) skirmisher cost bonus).

Since the bonus doesn't stack with the batch training, it seems a valuable bonus but not OP. It will be good in the beginning for a faster economy and good in the lategame when having to spawn many units quickly, given the same number of barracks as the enemy)

This revision is now accepted and ready to land.May 16 2017, 4:14 AM
fatherbushido added a comment.May 16 2017, 6:51 AM
In D502#20343, @elexis wrote:

Tested it successfully.

Agree with causative that the user really must have a way to read the team bonuses. So we should fix that one entry in the civ files.

yes, Imarok takes care of that.
Ultimately, I am confident that more things are coming about structure tree and related things.

The other team bonuses could use a little polishing IMO:

  • The sparta 10% health one for citizen soldiers could be buffed to 20%.
  • Since one doesn't build many CCs at all, the seleucid bonus could be increased
  • The athen bonus doesn't seem that useful to me, it could add a small wood cost bonus to ships maybe

ok.

fatherbushido updated this revision to Diff 1961.May 16 2017, 6:59 AM

Retweak gaul modifications.

Closed by commit rP19591: Team bonuses for Britons, Gauls and Romans. Reviewed by elexis. Refs #4082. (authored by fatherbushido). · Explain WhyMay 16 2017, 7:17 AM
This revision was automatically updated to reflect the committed changes.
fatherbushido mentioned this in D460: Update teamboni in civ.jsons.May 16 2017, 7:21 AM
Vulcan added a comment.May 16 2017, 8:02 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1224/ for more details.

Harbormaster completed remote builds in B1757: Diff 1961.May 16 2017, 8:02 AM

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
data/
auras/
teambonuses/
13 lines
10 lines
10 lines
templates/
special/
6 lines
6 lines
6 lines

Diff 1962

View Options

ps/trunk/binaries/data/mods/public/simulation/data/auras/teambonuses/brit_player_teambonus.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/auras/teambonuses/gaul_player_teambonus.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/auras/teambonuses/rome_player_teambonus.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/player_brit.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/player_gaul.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/player_rome.xml

Loading...
Wildfire Games · Phabricator