Gamesetup tooltips for population limit, mapsize, mapfilter and civs
ClosedPublic
Actions

Authored by elexis on May 16 2017, 1:49 AM.

Details

Reviewers

Hannibal_Barca
Phormio

Commits

rP19609: Add selection-dependent gamesetup tooltips for the chosen map, map filter, map…

Summary

In D316, Vladislav has added support for tooltips specific to the currently hovered dropdown list item, specifically for victory conditions, maptypes and starting resources.
This patch adds item-specific tooltips for

Population limit (since chosing a too big limit can often cause "lag" in both AI and multiplayer games. 4v4 * 150, 3v3 * 200 seems to work great, going beyond often caused lag. See also D232.)
Map Sizes (since it isn't obvious which mapsize is best suited, see also rP18854.)
Map filters (since it isn't obvious what the default or trigger filter contains.)

The map description could be displayed, but it is TLDR, not appealing and only distractive.

The structtree displays the history strings, but using them here also seems too noisy:

Test Plan

Proofread the strings, check for grammar, intuitive phrasing and correct meaning.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

elexis created this revision.May 16 2017, 1:49 AM

Actually there is a proper civ tooltip in the history property of the civ json files. We can see those strings displayed in the tech tree

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1223/ for more details.

Harbormaster completed remote builds in B1754: Diff 1958.May 16 2017, 6:29 AM

elexis edited the summary of this revision. (Show Details)May 16 2017, 3:30 PM

Actually it doesn't seem anymore distractive than the other hovertooltips, while adding a little goody IMO. So adding civ and map descriptions to the hovertooltip.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1229/ for more details.

Harbormaster completed remote builds in B1764: Diff 1972.May 16 2017, 4:33 PM

Works and doesn't seem too "noisy".

This revision is now accepted and ready to land.May 18 2017, 5:24 PM

Thanks for the review (i.e. that testing you performed and the brief check for content and grammar correctness you posted in the lobby)

Closed by commit rP19609: Add selection-dependent gamesetup tooltips for the chosen map, map filter, map… (authored by elexis). · Explain WhyMay 18 2017, 10:49 PM

This revision was automatically updated to reflect the committed changes.

(Nothing important, but the civ tooltip has not enough room (mainly on vertical, we don't see the bottom of the words). With the translation, the mauryan one for example could be problematic.
Tested on 1920*1080 (28" screen).)

(edit: in fact the bottom trimming could even be seen in the screenshot in the description.)

In D505#20833, @fatherbushido wrote:

(Nothing important, but the civ tooltip has not enough room (mainly on vertical, we don't see the bottom of the words). With the translation, the mauryan one for example could be problematic.
Tested on 1920*1080 (28" screen).)

(edit: in fact the bottom trimming could even be seen in the screenshot in the description.)

It's the worst-case screenshot. Same goes for the map description.
Also if cheats are enabled in an MP game, said those very long descriptions might overlap. But that is already the case if someone would add a long english or long translation of a short english tooltip somewhere and should be fixed separately by redistributing the width depending on the actual width taken by the cheat warning label.
That we can't display the entire description isn't problematic IMO, the user should get a sneak preview when hovering the items. Was more wondering whether it is too distractive, but that is just consistent with the other selection-dependent tooltips while it provides some information to the user. Perhaps it wasn't ideal to end in the middle of the sentence, but if players wan't to read the entire thing, they can still select the map or the civ in the civ info dialog / structure tree. Can also revert the map description and civ info one if it's too bad (Splitting the map description into individual translatable sentences seems overkill).

elexis mentioned this in D594: Fix tooltips not used in gamesetup.Jun 3 2017, 3:35 AM

elexis mentioned this in D232: Gamesetup - Adapt population limit to the number of players .Jul 9 2017, 2:21 AM

elexis mentioned this in rP20024: Fix two translation oversights in rP19609 / D505..Aug 23 2017, 3:13 PM

elexis mentioned this in rP21881: Remove two dead strings from gamesetup.xml following rP19609 / D505 and rP20529….Sep 9 2018, 7:23 PM