Remove the use of std::iterator in EntityMap.h
ClosedPublic
Actions

Authored by phosit on Aug 17 2023, 8:19 PM.

Details

Reviewers

wraitii
vladislavbelov

Commits

rP27813: Remove the use of std::iterator in EntityMap.h

Summary

std::iterator is deprecated since C++17.

Test Plan

Compile it

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

phosit created this revision.Aug 17 2023, 8:19 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8304/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7215/display/redirect

Harbormaster completed remote builds in B22243: Diff 22156.Aug 17 2023, 8:37 PM

phosit requested review of this revision.Aug 17 2023, 8:37 PM

LGTM.

This revision is now accepted and ready to land.Aug 18 2023, 7:48 PM

This revision was landed with ongoing or failed builds.Aug 23 2023, 2:31 PM

Closed by commit rP27813: Remove the use of std::iterator in EntityMap.h (authored by phosit). · Explain Why

This revision was automatically updated to reflect the committed changes.

phosit added a commit: rP27813: Remove the use of std::iterator in EntityMap.h.

Owners added a subscriber: Restricted Owners Package.Aug 23 2023, 2:31 PM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

source/

simulation2/

system/

EntityMap.h

10 lines

Diff 22169

View Options

ps/trunk/source/simulation2/system/EntityMap.h

Remove the use of std::iterator in EntityMap.hClosedPublicActions