Paths

Table of Contentst

Differential D5115

fix vertical misalignment of text "Victory:" on save game screen
Changes PlannedPublic
Actions

Authored by abian on Aug 27 2023, 12:49 PM.

Tags

None

Subscribers

Details

Reviewers

Trac Tickets

Summary

See <https://trac.wildfiregames.com/ticket/6863>. Also raise the block 10px, it was too close to the bottom.

Test Plan

Tested in the game.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 22269
Build 54436: Vulcan Build	Jenkins
Build 54435: Vulcan Build (macOS)	Jenkins
Build 54434: Vulcan Build (Windows)	Jenkins

Event Timeline

abian created this revision.Aug 27 2023, 12:49 PM

abian published this revision for review.Aug 27 2023, 12:51 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8323/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7234/display/redirect

Harbormaster completed remote builds in B22267: Diff 22181.Aug 27 2023, 1:12 PM

Have you checked other languages? There is a script to generate a special localization with longest words: source/tools/i18n/generateDebugTranslation.py.

In D5115#217268, @vladislavbelov wrote:

Have you checked other languages? There is a script to generate a special localization with longest words: source/tools/i18n/generateDebugTranslation.py.

Thanks! Tested with "Segervillkor:", all okay.

Instead of changing bounding box I'd say just use the appropriate style which looks to be "ModernLeftTopLabelText"

abian updated this revision to Diff 22185.Aug 27 2023, 10:27 PM

abian edited the summary of this revision. (Show Details)

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8325/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7236/display/redirect

Harbormaster completed remote builds in B22269: Diff 22185.Aug 27 2023, 10:44 PM

In D5115#217276, @abian wrote:

Thanks! Tested with "Segervillkor:", all okay.

Could you attach screenshots for long translations?

Freagarach resigned from this revision.Oct 13 2023, 11:08 AM

Freagarach edited reviewers, added: vladislavbelov; removed: Freagarach.

In D5115#219400, @vladislavbelov wrote:

Could you attach screenshots for long translations?

I'm glad that you asked them because now I've seen that the height of some fields is not enough for their names. I'll fix that too as soon as I can.

Revision Contents
Changeset List

Path

Size

binaries/

data/

mods/

public/

gui/

loadgame/

20 lines

Diff 22185

binaries/data/mods/public/gui/loadgame/load.xml

Loading...