Make the sea ground height of Elephantine independent from the mapsize.
ClosedPublic
Actions

Authored by phosit on Sep 17 2023, 12:24 PM.

Details

Reviewers

Freagarach
real_tabasco_sauce

Commits

rP27909: Make the sea ground height of Elephantine independent from the mapsize.

Summary

I increased the number, so that the sea/river is still passable on tiny maps.

Test Plan

Places docks using different map sizes

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

phosit created this revision.Sep 17 2023, 12:24 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7297/display/redirect

Harbormaster completed remote builds in B22346: Diff 22269.Sep 17 2023, 12:56 PM

phosit requested review of this revision.Sep 17 2023, 12:57 PM

phosit retitled this revision from Make the height of the sea ground independent from the mapsize. to Make the sea ground height of Elephantine independent from the mapsize..Sep 17 2023, 1:00 PM

sera added a subscriber: sera.Sep 18 2023, 9:07 AM

sera added inline comments.

binaries/data/mods/public/maps/random/elephantine.js
138 ↗	(On Diff #22269)	Doesn't it seems more natural to make shore fixed height?

According to elexis all heights should be scaled by the map size.
For me this makes sense for hills and mountains but definitly not for waves or shores.
I'm uncertain if the sea ground height should be scaled by the map size. Conceptualy it should be treated like hills but in practice a deep see ground hurts performance and isn't noticed by players.

I'd say a map should try to preserve the feel across the different sizes. That isn't the same as blatantly scaling, in fact constructing counter examples isn't all that hard (eg, think of vertical range of ranged units). Also you already violate this supposed rule with your fix. I'd say a map author should go with the most sensible choice case by case.

I know that i violate this rule

Make the shore also independent.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7330/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8419/display/redirect

Harbormaster completed remote builds in B22390: Diff 22316.Sep 24 2023, 4:52 PM

Probably a different diff, but I think this map should use the Nubia or Sahara biome.

Don't remove the heightWaterLevel constant.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7377/display/redirect

Successful build - Chance fights ever on the side of the prudent.