Page MenuHomeWildfire Games
Differential D530

Update variants rnc/rng
ClosedPublic
Actions

Authored by fatherbushido on May 21 2017, 5:27 PM.

Details

Reviewers
• leper
sanderd17
wraitii
elexis
Summary

Use the id attribute (see rP19031, it was added for actors but not for variants).
Also trang the rnc file and get that new one.

refs D425

Test Plan

perl validate.pl
in source/tools/xmlvalidator
(it threw false errors)

Diff Detail

Event Timeline

fatherbushido created this revision.May 21 2017, 5:27 PM
fatherbushido edited the test plan for this revision. (Show Details)May 21 2017, 5:29 PM
Harbormaster failed remote builds in B1856: Diff 2084!May 21 2017, 6:29 PM
Vulcan added a subscriber: Vulcan.May 21 2017, 8:12 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1285/ for more details.

elexis accepted this revision.May 26 2017, 3:05 PM
elexis added a subscriber: elexis.

(Doing a review per request)

Without the patch:

Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_archer_chariot_ready.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_archer_ready.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_archer_relax.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_archer_relax_fem.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_driver_chariot.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_driver_chariot_celt.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_healer.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_healer_female.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_hoplite.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_jav_chariot_ready.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_rhomphaia_shield.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_rhomphaia_shield_fast.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_skirmisher.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_skirmisher_heavy.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_slave_male.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_slinger_ready.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_spearman_ready.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_spearman_ready_fast.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_spearman_ready_smallshield.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_spearman_relax.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_swordsman_2hand_ready.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_swordsman_2hand_relax.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_swordsman_shield_fast.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_swordsman_shield_fast_relax.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_swordsman_shield_ready.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_swordsman_shield_relax.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_swordsman_shieldarm.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_swordsman_shieldarm_fast.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_swordsman_shieldsmall_fast.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/base_trader.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/death_infantry.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/female_death.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/gather_praise.xml:0: Relax-NG validity error : Element variant failed to validate content
Relax-NG validity error : Extra element animations in interleave
/public/art/variants/biped/pikeman_base.xml:0: Relax-NG validity error : Element variant failed to validate content

With the patch applied:

Validating actors...

0 actor validation errors

The change is correct as you have pointed out by looking up the according commit.

Thanks for the research and patch!

binaries/data/mods/public/art/variants/variant.rng
1

Using `trang binaries/data/mods/public/art/variants/variant.rnc binaries/data/mods/public/art/variants/variant.rng``` I could reproduce the exact same rng file.

This revision is now accepted and ready to land.May 26 2017, 3:05 PM
fatherbushido closed this revision.May 26 2017, 9:54 PM

close as fixed by rP19661

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
art/
variants/
1 line
313 lines

Diff 2084

View Options

binaries/data/mods/public/art/variants/variant.rnc

Loading...
View Options

binaries/data/mods/public/art/variants/variant.rng

Loading...
Wildfire Games · Phabricator