Fix some style issues noticed by the linter. (Stripped apart from D717)
Details
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1711/ for more details.
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/297/ for more details.
patch nice and small so fix all issues found by bb linting too :P
binaries/data/mods/public/simulation/components/StatusBars.js | ||
---|---|---|
1 ↗ | (On Diff #2846) | make it a g_FooBar |
24 ↗ | (On Diff #2846) | move opening tag a line up and fix the indentation of the block. |
29 ↗ | (On Diff #2846) | trailling comma |
39 ↗ | (On Diff #2846) | period |
116 ↗ | (On Diff #2846) | period |
226 ↗ | (On Diff #2846) | use capital letter |
Could also change some other files. Or not.
In D717 we also noticed that healers (or which unit was it?) include some stuff the parent template already has, should be cleaned up somewhere too.
binaries/data/mods/public/simulation/components/StatusBars.js | ||
---|---|---|
1 ↗ | (On Diff #2846) | Maybe a prototype property would look preferable (if that works with de/serialization) |
(Oups, that acceptance is a leftover from when I first looked at this. Give bb those periods before committing)
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1756/ for more details.
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/326/ for more details.