Apply life-long training to spot the commented out code.
Details
Details
- Reviewers
Sandarac - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP19932: Remove commented out code.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- map_code
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 2597 Build 4396: Vulcan Build (Windows) Jenkins Build 4395: Vulcan Build Jenkins Build 4394: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1739/ for more details.
Comment Actions
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/312/ for more details.
Comment Actions
GameView.cpp:869
(Maybe someone can figure out some way to detect commented out code automatically)