Page MenuHomeWildfire Games

New order categories in options
ClosedPublic

Authored by ffffffff on Aug 18 2017, 3:14 PM.

Details

Summary

New categorie "game play", game play related settings.

New Screenshots: https://imgur.com/a/WKn8z

Test Plan

test

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
In D797#34067, @elexis wrote:
  • The chat timestamp setting is relevant in both lobby and ingame chat, so I'd prefer to not put it into one of these two categories. It could be split into two separate settings or just remain under General.
  • The welcome screen is not an overlay. Other than that I'd welcome the overlay category.
  • Windowed mode should definitely go to the graphics settings IMO (even though it doesn't influence the renderer)
  • Splitting the network settings makes sense too IMO.

However we have to consider that the General category is nearly empty afterwards, so it would look a bit awkward when opened, which I'd prefer to avoid.

put welcome general

binaries/data/mods/public/gui/options/options.json
321

oh lol
that goes out

maybe we can set now the new categories as suggested be
as far as i can see we got now new options design https://imgur.com/a/zLj1u

i think the new categories are reasonable especialy for general options page

binaries/data/mods/public/gui/options/options.xml
128 ↗(On Diff #3164)

congrats.

ffffffff updated this revision to Diff 4563.Dec 5 2017, 5:06 PM
ffffffff edited the summary of this revision. (Show Details)

Suggestion for option gui.

ffffffff updated this revision to Diff 4565.Dec 5 2017, 5:08 PM

correction.

ffffffff edited the summary of this revision. (Show Details)Dec 5 2017, 5:08 PM
ffffffff edited the summary of this revision. (Show Details)
elexis added inline comments.Dec 5 2017, 5:17 PM
binaries/data/mods/public/gui/options/options.json
34

The welcome screen has nothing to do with overlays in games. Not sure that we need this option to begin with (it should and does always open if there is a new version once and if the user always wants to have it show up he can tick the checkbox in the welcome screen itself. I guess we can keep it anyway.

Ok to split the 5 overlay options to a separate tab.

Detailed Tooltips also has nothing to do with overlays.

58

It seems above settings are all about the session, but how could we phrase it?

61

Leave the tooltip empty if there is no description

111

ok

401–402

Not happy with making this "chat". Since this is mostly about notifications from the simulation, whereas chatting is mostly about user sent text. Id vote to keep as is because "Notifications" could be confused with the overlays.

ffffffff added inline comments.Dec 6 2017, 1:30 PM
binaries/data/mods/public/gui/options/options.json
401–402

but chat timestamp then putting in ok?

ffffffff updated this revision to Diff 4599.Dec 6 2017, 1:36 PM

abit bigger window
welcome back to general
chat revert
tooltip empty

ffffffff edited the summary of this revision. (Show Details)Dec 6 2017, 1:37 PM

im not sure about the position of overlays maybe at last tab?

last tab (overlays)

elexis added a comment.Dec 6 2017, 1:59 PM

Chat timestamp still shouldnt go to the chat notifications.

The number of tabs is getting too big IMO, but seems still better to keep it split than to merge.
I'd put the Overlays and Chat Notifications as the last two items.

In D797#44548, @elexis wrote:

Chat timestamp still shouldnt go to the chat notifications.

The number of tabs is getting too big IMO, but seems still better to keep it split than to merge.
I'd put the Overlays and Chat Notifications as the last two items.

sure?

im realy think chat timestamp is realy chat related

ffffffff added inline comments.Dec 6 2017, 3:46 PM
binaries/data/mods/public/gui/options/options.json
58

dk

ffffffff updated this revision to Diff 4742.Dec 12 2017, 2:39 AM
ffffffff edited the summary of this revision. (Show Details)Dec 12 2017, 2:41 AM
elexis resigned from this revision.Dec 12 2017, 8:37 PM

ok got idea

game sets into game setup

ffffffff added inline comments.Dec 15 2017, 6:14 PM
binaries/data/mods/public/gui/options/options.json
58

should be game setup as its about game settings

ffffffff added subscribers: elexis, Imarok, bb.EditedDec 18 2017, 8:02 PM

also possible all game play options in new categorie game play...

like 10-12?

maybe like this


from general

ffffffff edited the summary of this revision. (Show Details)Dec 18 2017, 8:17 PM
ffffffff edited the summary of this revision. (Show Details)
ffffffff added subscribers: Hannibal_Barca, temple.

You requested a comment on IRC: I would prefer the "Overlays" category because it's more clear what goes into it. A "Gameplay" category could include more options than those you listed: windowed mode, detailed tooltips, all sound and graphics settings, and even chat notification settings influence gameplay. It's overbroad.

(Actually I think I prefer the way it is in a22 with all options on one screen, that way you can see everything at a glance without having to click.)

You requested a comment on IRC: I would prefer the "Overlays" category because it's more clear what goes into it. A "Gameplay" category could include more options than those you listed: windowed mode, detailed tooltips, all sound and graphics settings, and even chat notification settings influence gameplay. It's overbroad.

(Actually I think I prefer the way it is in a22 with all options on one screen, that way you can see everything at a glance without having to click.)

na i wanted to make clear line here as for in game "play" settings, so detailed tooltips is in, windowed mode affect all game not in, chat notifications lined out by seperate categorie (as are some), same sound and graphic (lined out categorie as are some.) u think game "play" wouldnt fit? should generaly connect some different settings for ingame "play":)

Range overlays (like the aura range) and text "overlays" like the ingame time are not related. It's a coincidence that someone chose the same words.

They're not related in the code, but the word "overlay" does describe them. They are things that are painted on top of (overlay) the game simulation.

I like the idea of a game play category with the options that can give you an edge when playing,
like Detailed tooltips, all visual auras, wounded units, batch size, ceasefire time (maybe) and Unit slihouettes (not sure anyone uses this for performance).
The chat timestamp seems good in Lobby together with backlog and next to chat notifications tab.
FPS overlay maybe next to fps throttling (?)
I feel like the observers stuff should be separated, ppl always ask how to modify that.

this needs rebase or something, options.json conflicts

Yes. Ok i will rebase. Thanks for the opinion (AND test ofc!!!)XD. Great to hear. Maybe we should put observer limit and late observer option into game setup categorie. (I thought it once anyway). There is better due to game setup option as it is.

ffffffff updated this revision to Diff 4882.Dec 22 2017, 5:49 PM

I am just making update here as proposed by the comments from the players. Really feeling here the same from daily game. Let's look.

ffffffff updated this revision to Diff 4883.Dec 22 2017, 5:54 PM

FPS overlay crowds graphics settings i keep in general categorie. Realtime overlay same goes also general. Both overall seeable in game. Window mode to graphics categorie. Game play categorie getting all related in-game sets. Game setup gets observer sets as it "sets up" game setup related options same like assign player. Chat timestamp option im not sure. Feeling it can be lobby but its add gamewide timestamps to chats (what should related to general). But from terms perspective feeling lobby categorie is not bad. have alook:)

ffffffff edited the summary of this revision. (Show Details)Dec 22 2017, 9:13 PM

I like spec options in game setup.
I like very much the game play category but I don't think background pause, gametime overlay and network warning have anything to do with it.
Shouldn't batch size be an integer input box with min=1 and little arrows to increase/decrease?
(like <input type=number min=1 step=1> in html)

True. This three go back to general. Yea, arrows is a good idea for number input boxes. Needs some patch there.

But Ceasefire Time Overlay actualy also not, maybe renaming the categorie to "In-Game"? Or we put the options back to General categorie.

In-Game categorie can look this. Opinions?

I really prefer Game play category and options network warnings, gametime overlay and backward pause moved to general tab because that way people can fine tune only options that will help them be more effective in game.

ffffffff updated this revision to Diff 5028.Jan 2 2018, 12:14 PM

game play categorie finished.

mapkoc added a comment.Jan 2 2018, 8:09 PM

Maybe update images here?

ffffffff updated the Trac tickets for this revision.Jan 18 2018, 7:10 AM
ffffffff updated this revision to Diff 5497.Jan 25 2018, 11:01 PM

r21003 rebase

ffffffff edited the summary of this revision. (Show Details)Jan 25 2018, 11:02 PM

Maybe we could get this now in the code @elexis.

bb added a comment.Jan 30 2018, 4:08 PM

Having a tab for Game Play stuff seems good, and gives us some space in the general tab
Some options have been added => rebase

binaries/data/mods/public/gui/options/options.json
58

move below the overlays

95–96

keep the overlays together

106

not a graphics option, should stay in general

322

if you know something nice feel free to add, otherwise remove the keyword

379–396

no gamesetup options, doesn't fit anywhere really, so keep them in general, or in-game if you really want to move them

ffffffff added inline comments.Jan 31 2018, 5:09 PM
binaries/data/mods/public/gui/options/options.json
106

y

bb requested changes to this revision.Feb 6 2018, 6:01 PM

see above

This revision now requires changes to proceed.Feb 6 2018, 6:01 PM
ffffffff updated this revision to Diff 5702.Feb 7 2018, 4:51 PM
ffffffff edited the summary of this revision. (Show Details)

i would just go like this https://imgur.com/a/Av1OK now and we're fine

binaries/data/mods/public/gui/options/options.json
379–396

why its not, this setting up the game? it the only option it regards to, same late observer join

elexis added inline comments.Feb 7 2018, 6:10 PM
binaries/data/mods/public/gui/options/options.json
379–396

Those are networking options, not gamesetup options.
Gamesetup only contains code that should be relevant to the simulation or map options.
Besides that, the observer settings can be changed in running games too.

ffffffff added inline comments.Feb 7 2018, 7:16 PM
binaries/data/mods/public/gui/options/options.json
379–396

For me observer count and late join option is only about the game setup and can be changed in-game.

ffffffff updated this revision to Diff 5721.Feb 8 2018, 7:10 PM

https://imgur.com/a/WKn8z
observer limit/late join in general

bb accepted this revision.Feb 9 2018, 7:04 PM

"Detailed tooltips" should be moved aswell

Have gameplay as lowest tab => ok
Move chat notifications in there => ok

changes trivial => accept

binaries/data/mods/public/gui/options/options.json
409

while at it we should add some periods in the tooltips

This revision is now accepted and ready to land.Feb 9 2018, 7:04 PM
elexis added inline comments.Feb 9 2018, 8:02 PM
binaries/data/mods/public/gui/options/options.json
23

Of all the possible moves, moving windowed mode to graphics seemed the most obvious one to me. It shouldn't matter how crowded it is, what's more important is the logical grouping and that's more a graphics setting, no?

40

This is ingame-only, isn't it?

71

This one is-ingame too, the overlay settings wasn't a too bad idea, but not uncontroversial, so can be done elsewhere.

85

want network settings eventually, maybe not now if there are only that few (want dropped enet packets)

402

Ingame? I was struggling with this name all along. Grouping below seems ok.

bb added inline comments.Feb 9 2018, 8:37 PM
binaries/data/mods/public/gui/options/options.json
40

(yes see comment above)

71

agree to get the overlays into an own tab in another patch

85

(maybe the two lobby settings could be merged in that, dunno)

ffffffff closed this revision.Feb 10 2018, 2:58 PM

Network settings categorie could be "observer limit, + join, chat backlog, chat timestamp, network warnings"?
Lobby categorie for now delete and put game rating column option in general settings. btw why dont we have chat backlog in gamesetup?

ffffffff edited the summary of this revision. (Show Details)Feb 11 2018, 6:42 PM

sorry i closed that @bb that was accidentically. we need still commit. thanks you