Also fixes the other issue (the setting was only applied if the options screen was first opened).
Details
- Reviewers
fabio vladislavbelov FeXoR Imarok - Commits
- rP19822: Fix incompatible value for WaterUgly warning on opening the options screen.
- Trac Tickets
- #4230
Verify that the game works as expected for different values of waterugly.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build is green
Updating workspaces. Build (release)... Build (debug)... Running debug tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/236/ for more details.
Build is green
Updating workspaces. Build (release)... Build (debug)... Running debug tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/237/ for more details.
@fabio, could you test that? The code looks good but you are more aware of the graphics options world :)
Good ticket, it's an annoying message. I've tested the patch, it works for Windows, the message doesn't appear anymore.
How to reproduce on SVN (Windows):
- Remove all configs
- Open game
- Open options and disable Activate Water Effects
- Apply & Save (make sure that there is waterugly = "true" in user.cfg)
- Reopen game
- Open options
Can't reproduce. user.cfg does contain waterugly = "true". WIth and without local.cfg it doesn't bug (all on linux). Sure that isn't related to your guys local.cfg file? Otherwise it will be an interesting quest why this behavior is different depending on the platform.
waterugly must be changed in default.cfg, right?
fatherbushido FeXoR and me could not reproduce this issue with the provided steps on unix and windows.
Imarok could.
There is a bug with this revision: after doing vlads steps to reproduce, click on reset.
The waterUgly setting will not be reset.
Fixes the bug described in the ticket.
The reset bug is an other bug, indirectly connected with this patch. (#4652