E.g. sheeps of the enemy should not appear in FOW nor on the minimap
https://github.com/0ad/0ad/blob/master/binaries/data/mods/public/simulation/templates/template_unit_fauna.xml has RetainInFog set to true.
https://github.com/0ad/0ad/blob/6a43d8528e444c7f745227105983718159a3558b/binaries/data/mods/public/simulation/templates/template_unit.xml#L122 has it set to false.
Details
Details
- Reviewers
Stan - Commits
- rP20248: Domesticated animals shouldn't be visible in FOW
- Trac Tickets
- #3201
test it
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
(Too bad that there aren't help tags in the schema of Visbility that define RetainInFog)
Comment Actions
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jenkins-master:8080/job/phabricator_lint/506/ for more details.
Comment Actions
The patch is good and works as expected
I think animals were retained in fog so that you could see them when attacking them.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jenkins-master:8080/job/phabricator/1998/ for more details.