Page MenuHomeWildfire Games
Differential D291

Relic auras fixup
ClosedPublic
Actions

Authored by Hannibal_Barca on Apr 4 2017, 10:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 15, 6:37 PM
Unknown Object (File)
Fri, Sep 13, 12:18 PM
Unknown Object (File)
Apr 27 2017, 5:13 PM
Unknown Object (File)
Apr 26 2017, 8:56 PM
Unknown Object (File)
Apr 21 2017, 7:19 PM
Subscribers
bb
borg-
elexis
fatherbushido
Grugnas
Vulcan
Tokens
"Like" token, awarded by elexis.

Details

Reviewers
elexis
Commits
rP19384: Fix three catafalque auras.
Summary

Fixed some "bugs" found in the newly committed patch of D269:

  • 2nd, unnecessary empty line removed.
  • population max modification type changed from "global" to "player"
  • previously not working macedonian loot aura fixed and modified
  • Cavalry excluded from benefits of Spartan aura (spartans were famed for their hoplites)

Also tested in-game the not-so-visible auras, such as:
Ambiorix XP requirements and farming penalty
New macedonian loot aura
Roman gather bonus aura for women

Other auras have all been tested, but some might have been overlooked.

Test Plan

Test all auras to see if they give what is promised.
Check for possible improvements in description or aura.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 1012
Build 1596: Vulcan BuildJenkins

Event Timeline

Hannibal_Barca created this revision.Apr 4 2017, 10:33 PM
Hannibal_Barca edited the summary of this revision. (Show Details)
elexis awarded a token.Apr 4 2017, 10:34 PM
Vulcan added a subscriber: Vulcan.Apr 4 2017, 11:17 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/696/ for more details.

Harbormaster completed remote builds in B1012: Diff 1099.Apr 4 2017, 11:17 PM
Grugnas added inline comments.Apr 5 2017, 9:23 AM
binaries/data/mods/public/simulation/data/auras/catafalques/mace_catafalque.json
3

did you have problems multiplying Looter resources?
are you sure that this aura should affect structures too?
I'd suggest you to watch at trac #4503

Hannibal_Barca added a comment.Apr 5 2017, 5:17 PM

Yes, % didn't work when I tested it (you might have overlooked this in review)
Yes, this aura has to affect structures too or we can make a new aura.

elexis mentioned this in D269: Civ specific catafalque templates and auras.Apr 8 2017, 5:24 AM
elexis accepted this revision.Apr 8 2017, 5:36 AM

So far so good, but should have also

  • Changed the +10% armor to +1 armor, since having 1.1 armor is surely not what we wanted
  • fixed the order of resources to food/wood/metal/stone
binaries/data/mods/public/simulation/data/auras/catafalques/mace_catafalque.json
3

Units that can receive loot when they killed enemies use the Looter component.
But the loot they get is the sum of Looter of the killer plus the Loot of the killed entity.
But since the defaults in Looter are all 0, multiplying those still yields zero.

This revision is now accepted and ready to land.Apr 8 2017, 5:36 AM
Closed by commit rP19384: Fix three catafalque auras. (authored by elexis). · Explain WhyApr 8 2017, 5:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1099

View Options

binaries/data/mods/public/simulation/data/auras/catafalques/mace_catafalque.json

Loading...
View Options

binaries/data/mods/public/simulation/data/auras/catafalques/sele_catafalque_2.json

Loading...
View Options

binaries/data/mods/public/simulation/data/auras/catafalques/spart_catafalque_2.json

Loading...
View Options

binaries/data/mods/public/simulation/templates/other/catafalque/athen_catafalque.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/other/catafalque/brit_catafalque.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/other/catafalque/cart_catafalque.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/other/catafalque/gaul_catafalque.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/other/catafalque/iber_catafalque.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/other/catafalque/mace_catafalque.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/other/catafalque/maur_catafalque.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/other/catafalque/pers_catafalque.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/other/catafalque/ptol_catafalque.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/other/catafalque/rome_catafalque.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/other/catafalque/spart_catafalque.xml

Loading...
Wildfire Games · Phabricator