Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/671/ for more details.

• Adding Gallaecio to quickly read through the strings and perhaps find some improvements or issues. For one of the strings I'm wondering whether it isn't too explicit with regards to violent history.
• We're trying to find a nice balance of the bonuses of the different relics, so it were great if the numbers Hannibal and me came up with are confimed by Grugnas and borg-. (We need to keep in mnd that we not only want attack bonuses and not only consider 1v1 games).

Unlike persian palace which gives at a rate of 1-1-0.75-0.75 or a wonder which gives 0.5-0.5-0.5-0.5/s, this catafalque gives only 1 resource.
Your logic is that single gathering rate should be > all gathering rate, I applied that logic here. Since we can call Stone and Metal "Precious Resources", it means that the Palace gets 1.5/ second, along with a bonus of food and wood. The Wonder also has a rate of 1 precious resource/second with same food and wood bonus.

In light of this and that +25% loot isn't much, I think we should keep it as it is. Reducing rate would make it much inferior to other catafalques which don't have such an obvious benefit.

I'm glad you took in consideration my logic, but I would say the same for its application:

While economic reforms aura  gives a 10% gather speed to any worker,   Iron Pelanors gives 10% gather speed to metal workers only.

While Persian palace gives 0.75metal /sec and Wonder gives 0.5 metal / sec at phase 3, potentially the macedonian catafalque can yield more than 2000 metal in 40 min, basically higher than the persian palace income, the wonder income or a Brennus aura income. (theorically a catafalque captured at minute 0 would produce 2400 metal in 40 minutes, but i like to be realistic).

we should have civ specific catafalque templates. This allows
(1) We can name a great leader that remains in each catafalque spawned
(2) Those catafalques become unique, even if multiple of them exist on a map
(3) Each of these relics can receive a slight bonus, similar to heroes, for example auras or >resource trickle

Agree with the summary.

Some remarks, that's not really the question I ask, but the question which can be asked.

• splitting in folders seems a good idea. The same can be done for those auras perhaps. See @leper for that imo.
• ((nothing wrong but) consider that the relic are spawned as gaia (for auras))
• In the range of auras description we should have something like at end. "Effect Range: 50 meters" (I read some complains on transifex about that).
• I know that we need some abstraction, but it sounds really wrong to have a relic of Philip V which is born after all the others macedonians hero in the game.
• I really like the historic work and the provided description.
• Most of the aura's description should be move to Identity tooltip.
• I read in a french forum complains about aura of our hero (it sounds a bit too much magical). Again we are in abstraction. Here it sounds even worse. But I am not really disturb by that, just the description seems to justify the effect, which sounds bad. How what a guy did alive can have effect when we get his bones. I understand the abstraction (people are happy and fight harder or gather faster), but we shouldn't try to justify it. Moving most of the auras description to the Identity tooltip again should do the job.
• The other thing which is annoying is the fact that a civ related catafalque have effect on another civ. (Perhaps going on some powerfull effect on civ specific building is a thing to explore)
• I would not make comment on the different modifications, they seem different enough. Such discussion lead often to eternal subjective discussion. Imo we don't need to have them perfectly balanced (I like some imbalance). (I thought to garrison aura too but that's not relevant). The essential thing is too keep them different enough and not too redundant with the heros aura. (Some really powerfull things can also be considered).
• Icon for global auras doesn't seem really good (there should be some in the current auras I guess). Keep them for the moment :p
• It sounds a bit weird to have Indibil in a catafalque and perhaps also alive :)
• I like that we are back to one of the essential aspect of the game (historical "accuracy") and I like the well documented work and the related strings. I am just a bit sad that we didn't already do that work for the other heros (3 iberians, 1 roman) and for the missing team bonuses (despite some discussions - even a long one with the author of that diff). See Indibil for example.

I understand your passion for this game and your concern to be accurate ;)
But with this aura, I think the owning player will have a much harder time, be it a diplomacy, all vs all or a team game due to the fact that everyone will want to own such a valuable object. So the cost of keeping it adds up, meanwhile still making it worthwhile to collect as many catafalques as you can(unlike the current attack-magnets :p).

Edit: this was typed to grugnas

In D269#11048, @fatherbushido wrote:

Agree with the summary.

Thanks for your consideration. I was worried concerns might arise once it's committed ;-)

folders

Agree. Wasn't sure whether it works. But as it works for team bonuses, we should do it here too. Also move hero auras afterwards.

"Effect Range: 50 meters"

True, should be done until we have generic aura tooltips.

relic of Philip V which is born after all the others macedonian heroes

Indeed seems weird, but we have this issue with trainable heroes too and in case we take that seriously we would have to add a lot of changes to most things in the games, for example which civ can encounter which other civ. So meh.

• I really like the historic work and the provided description.

Me too, will educate players, which is one of the purposes of this game!

• Most of the aura's description should be move to Identity tooltip.

How what a guy did alive can have effect when we get his bones

Remarked by others as well. The idea is that the soldiers and workers are motivated by the ideas that the now dead guy spread. So not necessarily a conflict.

civ related catafalque have effect on another civ

Not really an issue. Alexander the great did an honorful funeral at a temple for some persian hero. We can interpret it as honoring the leaders of other civs too or getting the fame of having captured those.

-modifications eternal subjective discussion

yes -.-

• Icon for global auras

good point, should be removed

Indibil in a catafalque and perhaps also alive :)

Nope, it's Mandonius

a bit sad that we didn't already do that work for the other heros (3 iberians, 1 roman) and for the missing team bonuses

Patches welcome by anyone and it seems Grugnas is at it currently

In D269#11063, @elexis wrote:

In D269#11048, @fatherbushido wrote:

Indibil in a catafalque and perhaps also alive :)

Nope, it's Mandonius

I scrambled

EDIT: @Hannibal_Barca can you say to who you speak above (it seems it's to me as it's obviously not to me)

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/677/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/682/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/683/ for more details.

In D269#11223, @fatherbushido wrote:

Move the not modification part of the auras description elsewhere (history tooltip should be displayed someday).

Requirements:
R1 XML string states all relevant history of that man or woman
R2 Aura string states the effects of that aura
R3 Aura string should not contain any history
R4 Aura effect should be reproducibly derived from history

In order to derive the aura from historical background, that historical background must be stated explicitly somewhere, so that everyone (players and future editors) can reproduce the reasoning of the aura effect.
If we add the historical reasoning to the Aura string, we violate R3.
If we add the historical reasoning to the XML string

• we violate R1 in some cases, because some auras are derived from circumstancial events, not from the main history.
• we lose the connotation of the strings being reasoning. The history of the person can be seen as independent of the aura, not as a justification of the aura.
• we then mix 2-3 unrelated events in that string

Example Iberian:

Along with his brother Indibil, Mandonius commanded the Iberian recruits and mercenaries that took part in the Punic Wars.
Following the fall of Indibil in battle, Mandonius led the survivors to safety.

Best attempt to merge:

Along with his brother Indibil, Mandonius commanded the Iberian recruits and mercenaries that took part in the Punic Wars. Finally the two brothers met their downfall in a rebellion against the Romans. Following the fall of Indibil in battle, Mandonius led the survivors to safety.

The last sentence seems entirely unrelated to the history but only related to the aura.

Example Macedonians:

Allied with Rome, Philip reorganized the country's internal affairs and finances, leaving as a legacy reopened mines and a new currency. Gain a slow trickle of metal.
During the First Macedonian War, Philip and his troops sacked Thermum, the religious and political centre of Aetolia

From https://en.wikipedia.org/wiki/Philip_V_of_Macedon we can see that this figurehead participated in many events: Social War, First Macedonian War, Expansion in the Aegean, Second Macedonian War and Alliance with Rome.
But the string now only picks few of them selectively and leaves our major history.

Hannibal and me sat down for five more hours to rewrite the strings to see if we can merge them, but the counterexamples remain.
Having the major history ones in the XML files and the circumstances in the JS file is also weird. If we'd do that, there would be no reason not to have all of them in the aura files.

Keeping the historical reasoning of the auras in the aura file has the advantage that we can write an actual description in the XML file that has a good history string as it ought to.

Diff which has historic background in the xml files according to the wishes of fatherbushido.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/684/ for more details.

Else I don't understand what was the empty diff.
Was a fast review asked by the author of the diff (I assume).
Sorry I didn't test all unit one by one. I guess that's what every accepter did.
(i forgot, I don't know if health is enough clear compared to max health)

(Not related to that diff but a SelectionGroupName for catafalque could be nice.)

This is the version with history in xml files just in case anyone is interested.

"an 80 meter range" is grammatically correct as far as i know
spartan aura will be addressed, overlooked the fact that it affects champion spear cavalry at the moment.

In D269#11468, @Hannibal_Barca wrote:

This is the version with history in xml files just in case anyone is interested.

The 4th is a bit late for April fool.

"an 80 meter range" is grammatically correct as far as i know

I didn't affirm it wasn't. I just wanted to know for myself.

spartan aura will be addressed, overlooked the fact that it affects champion spear cavalry at the moment.

My comment didn't presumed that.