Fixes debug build on macOS
AbandonedPublic
Actions

Authored by vladislavbelov on Jan 13 2020, 7:20 PM.

Details

Reviewers

Summary

The link was failure for me because of lack of mozjs-debug. The line was missing since rP22627. Maybe the problem was before.

Test Plan

Apply the patch on macOS
Clean workspaces/builds/libraries
Build libraries
Build game

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 10776
Build 18739: Vulcan Build	Jenkins
Build 18738: Vulcan Build (macOS)	Jenkins
Build 18737: Vulcan Build (Windows)	Jenkins

Event Timeline

vladislavbelov created this revision.Jan 13 2020, 7:20 PM

vladislavbelov mentioned this in rP22627: Upgrade SpiderMonkey to version 45.0.2, refs #4893..

vladislavbelov added inline comments.

libraries/osx/build-osx-libs.sh
977	The same line.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1027/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/123/display/redirect

Harbormaster failed remote builds in B10776: Diff 11002!Jan 13 2020, 7:22 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1545/display/redirect

Hey! This is already in D2523.

Krinkle added a subscriber: Krinkle.Feb 4 2020, 9:22 PM

Superseeded. See above.

Revision Contents
Changeset List

Path

Size

libraries/

osx/

build-osx-libs.sh

1 line

Diff 11002

View Options

libraries/osx/build-osx-libs.sh

Fixes debug build on macOSAbandonedPublicActions