Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP22627

Upgrade SpiderMonkey to version 45.0.2, refs #4893.
rP22627
Actions

Tags

None

Subscribers

Tokens

"Party Time" token, awarded by elexis.

Description

Upgrade SpiderMonkey to version 45.0.2, refs #4893.

Various build changes, in particular NSPR is not needed on Unix anymore
Add js/Initialization.h to source/scriptinterface/ScriptEngine.h
Use nullptr instead of JS::NullPtr(), see https://bugzilla.mozilla.org/show_bug.cgi?id=1164602
Remove JS::RuntimeOptionsRef.varObjFix, see https://bugzilla.mozilla.org/show_bug.cgi?id=1171177
Remove uses of AutoIdArray, see https://bugzilla.mozilla.org/show_bug.cgi?id=1191529
JS_InternUCStringN has been renamed, see https://bugzilla.mozilla.org/show_bug.cgi?id=1178581
JS::Evaluate now takes scope chains explicitly, see https://bugzilla.mozilla.org/show_bug.cgi?id=1097987
Array functions (such as JS_IsArrayObject) are fallible and output to params, see https://bugzilla.mozilla.org/show_bug.cgi?id=1179003
Remove JSCLASS_CACHED_PROTO_WIDTH workaround in our code, see https://bugzilla.mozilla.org/show_bug.cgi?id=1236373
Remove compile'n go (setCompileAndGo) and replace it by setIsRunOnce which will become the default in the future, see https://bugzilla.mozilla.org/show_bug.cgi?id=679939
Mark shared memory in direct access operations (JS_GetUint16ArrayData and JS_GetUint8ArrayData), see https://bugzilla.mozilla.org/show_bug.cgi?id=1176214
Use new JS::ObjectOpResult, see https://bugzilla.mozilla.org/show_bug.cgi?id=1113369

Thanks to wraitii, elexis, Krinkle and historic_bruno for contributions and comments, and to gentz, madpilot, s0600204 and Stan for testing and indirect contributions.

Differential Revision: https://code.wildfiregames.com/D1510

Details

Committed

Itms	Aug 8 2019, 12:37 AM

Differential Revision

D1510: Update to Spidermonkey 45.0.2

Parents

rP22626: Fix gcc 8 compiler warning in FileIo.cpp about truncating use of strncpy…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 8780
Build 14398: Trigger Windows Autobuild
Build 14397: Post-Commit Build	Jenkins

Event Timeline

Itms committed rP22627: Upgrade SpiderMonkey to version 45.0.2, refs #4893..Aug 8 2019, 12:37 AM

Itms added an edge: D1510: Update to Spidermonkey 45.0.2.

elexis awarded a token.Aug 8 2019, 12:39 AM

Harbormaster failed to build B8780: rP22627: Upgrade SpiderMonkey to version 45.0.2, refs #4893.!Aug 8 2019, 1:06 AM

The setIsRunOnce addition must be reverted.

/ps/trunk/source/gui/IGUIObject.cpp
349	The GUI is not covered by the unit tests, but this also fails in debug mode.
/ps/trunk/source/scriptinterface/ScriptInterface.cpp
867	Silly me didn't test this in debug mode, which is where SM assertions are checked.

Itms mentioned this in rP22629: Revert use of the `isRunOnce` flag after removal in rP22627 of compile'n go….Aug 8 2019, 11:06 AM

elexis mentioned this in D2170: --with-system-mozjs45.Aug 11 2019, 10:15 PM

elexis mentioned this in rP22660: Update update-workspaces.sh and premake5.lua with the with-system-mozjs45 flag….Aug 13 2019, 1:31 PM

Could this still be https://bugzilla.mozilla.org/show_bug.cgi?id=1245783#c36 which is only fixed in SM49?
refs rP18762, rP18767

vladislavbelov mentioned this in D2566: Fixes debug build on macOS.Jan 13 2020, 7:20 PM

vladislavbelov added a subscriber: vladislavbelov.

vladislavbelov added inline comments.

/ps/trunk/libraries/osx/build-osx-libs.sh
976	This line is missed for the debug build. Fixed in D2566.

(From https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Releases/45

SpiderMonkey 45 contains known security vulnerabilities.

CVE doesnt list spidermonkey, so I suppose that refers to a subset of https://www.cvedetails.com/vulnerability-list/vendor_id-452/product_id-22101/version_id-202242/)

Changes (32)

Path

Size

ps/

trunk/

build/

premake/

extern_libs5.lua

workspaces/

clean-workspaces.sh

libraries/

osx/

build-osx-libs.sh

source/

spidermonkey/

ExportJSPropertyDescriptor.diff

FixLinking.diff

FixMozglueStatic.diff

FixTracelogger.diff

FixVersionDetection.diff

FixVersionDetectionConfigure.diff

FixZLibMozBuild.diff

RemoveNSPRDependency.diff

mozjs-38.2.1.rc0.tar.bz2

mozjs-45.0.2.tar.bz2

source/

gui/

scripting/

JSInterface_IGUIObject.cpp

JSInterface_IGUIObject.h

ps/

VisualReplay.cpp

scriptinterface/

ScriptConversions.h

ScriptInterface.cpp

simulation2/

components/

CCmpAIManager.cpp

scripting/

EngineScriptConversions.cpp

serialization/

BinarySerializer.cpp

StdDeserializer.cpp

system/

rP22627

ps/trunk/build/premake/extern_libs5.lua

Loading...

ps/trunk/build/workspaces/clean-workspaces.sh

Loading...

ps/trunk/libraries/osx/build-osx-libs.sh

Loading...

ps/trunk/libraries/source/spidermonkey/ExportJSPropertyDescriptor.diff

Loading...

ps/trunk/libraries/source/spidermonkey/FixLinking.diff

Loading...

ps/trunk/libraries/source/spidermonkey/FixMozglueStatic.diff

Loading...

ps/trunk/libraries/source/spidermonkey/FixNonx86.diff

Loading...

ps/trunk/libraries/source/spidermonkey/FixTracelogger.diff

Loading...

ps/trunk/libraries/source/spidermonkey/FixVersionDetection.diff

Loading...

ps/trunk/libraries/source/spidermonkey/FixVersionDetectionConfigure.diff

Loading...

ps/trunk/libraries/source/spidermonkey/FixZLibMozBuild.diff

Loading...

ps/trunk/libraries/source/spidermonkey/README.txt

Loading...

ps/trunk/libraries/source/spidermonkey/RemoveNSPRDependency.diff

Loading...

ps/trunk/libraries/source/spidermonkey/build.sh

Loading...

ps/trunk/libraries/source/spidermonkey/mozjs-38.2.1.rc0.tar.bz2

Loading...

ps/trunk/libraries/source/spidermonkey/mozjs-45.0.2.tar.bz2

Loading...

ps/trunk/libraries/source/spidermonkey/patch.sh

Loading...

ps/trunk/source/gui/IGUIObject.cpp

Loading...

ps/trunk/source/gui/IGUIObject.h

Loading...

ps/trunk/source/gui/scripting/JSInterface_IGUIObject.cpp

Loading...

ps/trunk/source/gui/scripting/JSInterface_IGUIObject.h

Loading...

ps/trunk/source/ps/ModIo.cpp

Loading...

ps/trunk/source/ps/VisualReplay.cpp

Loading...

ps/trunk/source/scriptinterface/ScriptConversions.h

Loading...

ps/trunk/source/scriptinterface/ScriptEngine.h

Loading...

ps/trunk/source/scriptinterface/ScriptInterface.cpp

Loading...

ps/trunk/source/scriptinterface/ScriptTypes.h

Loading...

ps/trunk/source/simulation2/components/CCmpAIManager.cpp

Loading...

ps/trunk/source/simulation2/scripting/EngineScriptConversions.cpp

Loading...

ps/trunk/source/simulation2/serialization/BinarySerializer.cpp

Loading...

ps/trunk/source/simulation2/serialization/StdDeserializer.cpp

Loading...

ps/trunk/source/simulation2/system/ParamNode.cpp

Loading...