Page MenuHomeWildfire Games

Krinkle (Timo Tijhof)
Engineering

Projects

User Details

User Since
Jun 15 2019, 3:22 AM (5 w, 22 h)

GitHub: Krinkle
Twitter: @TimoTijhof
Wildfire Games Forum: Krinkle
Interests: JavaScript macOS Continuous Integration Localisation NL (Dutch) Localisation DE (German)


Recent Activity

Today

Krinkle updated the diff for D284: lobby: Display observer count in gameslist.
Sun, Jul 21, 1:22 AM
Krinkle updated the diff for D284: lobby: Display observer count in gameslist.
  • Rebased on latest trunk.
  • Re-used earlier result of parsing the game.players string.
  • Implemented the suggestion of displaying (N) instead of +N.
  • Increase colour and brightness for consistency with other text.
Sun, Jul 21, 1:21 AM
Krinkle added inline comments to D284: lobby: Display observer count in gameslist.
Sun, Jul 21, 1:14 AM
Krinkle added inline comments to D284: lobby: Display observer count in gameslist.
Sun, Jul 21, 1:14 AM
Krinkle commandeered D284: lobby: Display observer count in gameslist.
Sun, Jul 21, 12:48 AM

Yesterday

Krinkle updated the diff for D1993: petra: Fix all ESLint and JSHint warnings.
Sat, Jul 20, 10:20 PM
Krinkle added inline comments to D2080: Remove pointless Eval calls creating empty objects and arrays.
Sat, Jul 20, 10:09 PM
Krinkle updated the summary of D2103: petra: Remove redundant 'PETRA' re-assignments.
Sat, Jul 20, 10:05 PM
Krinkle updated the summary of D2103: petra: Remove redundant 'PETRA' re-assignments.
Sat, Jul 20, 10:04 PM
Krinkle added a comment to D2103: petra: Remove redundant 'PETRA' re-assignments.

This has been split out of D2103 as being the only semantic change (due to fixing a quality issue rather than a style issue). This way D2103, can focus solely on auto-fixed style changes.

Sat, Jul 20, 10:01 PM
Krinkle updated the summary of D2103: petra: Remove redundant 'PETRA' re-assignments.
Sat, Jul 20, 9:59 PM
Krinkle created D2103: petra: Remove redundant 'PETRA' re-assignments.
Sat, Jul 20, 9:59 PM
Krinkle added a comment to rP22518: Fix incorrect use of setlocale() in cppformat CStr tests following rP22378.

From Jenkins:

Sat, Jul 20, 9:39 PM
Krinkle updated the diff for D2070: Linting: Remove controversial 'curly' eslint rules.

Reduced to only curly. Keeping no-multi-spaces enabled, which per @elexis is desirable to enforce, but just something we need to fix in a few existing files.

Sat, Jul 20, 9:36 PM
Krinkle updated the summary of D2070: Linting: Remove controversial 'curly' eslint rules.
Sat, Jul 20, 9:35 PM
Krinkle updated the Trac tickets for D2004: Linter: Fix ESLint semicolon-related warnings.
Sat, Jul 20, 9:33 PM
Krinkle updated the Trac tickets for D2003: Linting: Enable 'no-floating-decimal' rule in ESLint.
Sat, Jul 20, 9:33 PM
Krinkle updated the Trac tickets for D1993: petra: Fix all ESLint and JSHint warnings.
Sat, Jul 20, 9:32 PM
Krinkle updated the Trac tickets for D2070: Linting: Remove controversial 'curly' eslint rules.
Sat, Jul 20, 9:31 PM
Krinkle added inline comments to D2080: Remove pointless Eval calls creating empty objects and arrays.
Sat, Jul 20, 7:25 PM

Wed, Jul 17

Krinkle planned changes to D2090: glooxwrapper: Remove unused private 'm_Owned' in Jingle::Session::Jingle.

Causes more warnings. Needs additional changes to either accommodate the absence of this field, or additional changes to make the original version not cause warnings.

Wed, Jul 17, 7:06 PM
Krinkle added a comment to D2090: glooxwrapper: Remove unused private 'm_Owned' in Jingle::Session::Jingle.

Okay, it can't just be removed as-is.

Wed, Jul 17, 2:43 AM
Krinkle created D2090: glooxwrapper: Remove unused private 'm_Owned' in Jingle::Session::Jingle.
Wed, Jul 17, 2:33 AM
Krinkle resigned from rP22487: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions..

Fixed by rP22488.

Wed, Jul 17, 2:18 AM
Krinkle added 1 auditor(s) for rP22487: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.: Krinkle.

Note to self: rename FAILVOID to FAIL_VOID.

Wed, Jul 17, 12:54 AM
Krinkle added inline comments to rP22487: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions..
Wed, Jul 17, 12:54 AM

Tue, Jul 16

Krinkle added inline comments to D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.
Tue, Jul 16, 11:52 PM
Krinkle updated the diff for D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.

Removed not so useful comment.

Tue, Jul 16, 11:52 PM
Krinkle added inline comments to D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.
Tue, Jul 16, 11:10 PM
Krinkle updated the diff for D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.

Add failure checks for JS_GetProperty and JS::Construct. Also removed the redundant ret.setObject/obj.getObject indirection in favour of letting JS::Construct populate ret directly. Seems to work, and the type hints match. Don't know this is "right", though.

Tue, Jul 16, 11:09 PM
Krinkle updated the diff for D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.

Switch from long-form RootedValue/ToJSVal, to the shorter JS::Value#setNumber() form instead.

Tue, Jul 16, 10:34 PM

Mon, Jul 15

Krinkle added inline comments to D2080: Remove pointless Eval calls creating empty objects and arrays.
Mon, Jul 15, 8:20 PM
Krinkle added a comment to D2070: Linting: Remove controversial 'curly' eslint rules.

According to ESLint 6, on latest trunk, checking binaries/data/, there are:

Mon, Jul 15, 7:14 PM
Krinkle updated the summary of D1993: petra: Fix all ESLint and JSHint warnings.
Mon, Jul 15, 6:50 PM
Krinkle added a comment to D1993: petra: Fix all ESLint and JSHint warnings.

It seems the Jenkins build did not apply the parent patch from the stack, hence there are violations found (naturally) for the rules we proposed to disable (curly, and no-multi-spaces).

Mon, Jul 15, 6:48 PM
Krinkle added a comment to D2070: Linting: Remove controversial 'curly' eslint rules.

@elexis I've been told four different things by four different people :)

Mon, Jul 15, 6:44 PM
Krinkle updated the diff for D1993: petra: Fix all ESLint and JSHint warnings.

Now depends on D2070.

Mon, Jul 15, 6:38 PM
Krinkle updated the diff for D2070: Linting: Remove controversial 'curly' eslint rules.
Mon, Jul 15, 6:38 PM
Krinkle updated the test plan for D1993: petra: Fix all ESLint and JSHint warnings.
Mon, Jul 15, 6:30 PM
Krinkle planned changes to D1993: petra: Fix all ESLint and JSHint warnings.

I'll redo this diff on top of D2070 locally. In particular, it'll mean it won't try to "improve" around curly braces.

Mon, Jul 15, 4:46 AM
Krinkle added inline comments to D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.
Mon, Jul 15, 4:30 AM
Krinkle added inline comments to D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.
Mon, Jul 15, 4:24 AM
Krinkle added inline comments to D2079: Adds snapping to edges for buildings.
Mon, Jul 15, 1:07 AM
Krinkle added inline comments to D2079: Adds snapping to edges for buildings.
Mon, Jul 15, 1:04 AM

Sun, Jul 14

Krinkle updated the diff for D2070: Linting: Remove controversial 'curly' eslint rules.

(Rebase)

Sun, Jul 14, 9:01 PM
Krinkle updated the diff for D2003: Linting: Enable 'no-floating-decimal' rule in ESLint.
Sun, Jul 14, 1:22 AM

Sat, Jul 13

Krinkle updated the diff for D2070: Linting: Remove controversial 'curly' eslint rules.
Sat, Jul 13, 11:51 PM
Krinkle updated the diff for D2003: Linting: Enable 'no-floating-decimal' rule in ESLint.
Sat, Jul 13, 11:39 PM
Krinkle updated the diff for D2003: Linting: Enable 'no-floating-decimal' rule in ESLint.
Sat, Jul 13, 11:27 PM
Krinkle added inline comments to D2003: Linting: Enable 'no-floating-decimal' rule in ESLint.
Sat, Jul 13, 11:17 PM
Krinkle updated the diff for D2003: Linting: Enable 'no-floating-decimal' rule in ESLint.
Sat, Jul 13, 11:16 PM
Krinkle updated the summary of D2003: Linting: Enable 'no-floating-decimal' rule in ESLint.
Sat, Jul 13, 11:09 PM
Krinkle created D2070: Linting: Remove controversial 'curly' eslint rules.
Sat, Jul 13, 11:06 PM

Fri, Jul 12

Krinkle awarded D1693: Avoid unnecessary updates from updateSettingsPanelPosition a Orange Medal token.
Fri, Jul 12, 3:59 AM

Mon, Jul 1

Krinkle added a comment to D2013: Fix incorrect use of setlocale() in cppformat CStr tests.

@wraitii Go ahead :)

Mon, Jul 1, 9:01 PM

Sun, Jun 30

Krinkle added a comment to D2005: Standardize "Territory Influence" in tooltips.

A few options mentioned so far:

Sun, Jun 30, 12:44 AM
Krinkle resigned from D1971: Support attack-ground for ranged units..
Sun, Jun 30, 12:14 AM

Sat, Jun 29

Krinkle added inline comments to D2005: Standardize "Territory Influence" in tooltips.
Sat, Jun 29, 11:41 PM
Krinkle awarded D1803: Communicate field diminishing returns to the player a Orange Medal token.
Sat, Jun 29, 1:30 AM
Krinkle awarded rP22203: Communicate field diminishing returns to the player in the fields tooltip a Orange Medal token.
Sat, Jun 29, 1:30 AM
Krinkle updated the test plan for D2005: Standardize "Territory Influence" in tooltips.
Sat, Jun 29, 1:25 AM
Krinkle added inline comments to D2004: Linter: Fix ESLint semicolon-related warnings.
Sat, Jun 29, 1:23 AM

Wed, Jun 26

Krinkle created D2013: Fix incorrect use of setlocale() in cppformat CStr tests.
Wed, Jun 26, 1:50 AM

Mon, Jun 24

Krinkle added a comment to D2005: Standardize "Territory Influence" in tooltips.
In D2005#83640, @Nescio wrote:

! @Krinkle wrote:
I'm not very familiar with auras yet, can you elaborate on that? Is there a Trac task for that?

Have a look at the screenshots you posted. As you can see all relevant information of the aura is already displayed automatically (the "Religious Fervor" line). Which means the tooltips of iber_monument.xml, maur_pillar_ashoka.xml, and pers_ishtar_gate.xml can now be purged.

Mon, Jun 24, 11:25 PM
Krinkle updated subscribers of D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.

Yes. Test plan I wrote in the commit myself includes those steps, and I've confirmed them locally as well before submitting. The game compiles, starts, and can create a game and select/move units without errors.

Did you test (de)serialising?

Mon, Jun 24, 8:58 PM

Sun, Jun 23

Krinkle added a comment to D2005: Standardize "Territory Influence" in tooltips.
In D2005#83597, @Nescio wrote:

Although I'm not opposed to the idea per se, I'm not convinced the proposed implementation would really be an improvement.

Sun, Jun 23, 10:28 PM

Sat, Jun 22

Krinkle added inline comments to D2005: Standardize "Territory Influence" in tooltips.
Sat, Jun 22, 11:00 PM
Krinkle updated the diff for D2005: Standardize "Territory Influence" in tooltips.

(resolved TODO)

Sat, Jun 22, 10:36 PM
Krinkle added a comment to D2005: Standardize "Territory Influence" in tooltips.
BeforeAfter
Sat, Jun 22, 10:36 PM
Krinkle updated the diff for D2005: Standardize "Territory Influence" in tooltips.
Sat, Jun 22, 10:05 PM
Krinkle added a comment to D2005: Standardize "Territory Influence" in tooltips.
Sat, Jun 22, 9:38 PM
Krinkle created D2005: Standardize "Territory Influence" in tooltips.
Sat, Jun 22, 9:33 PM
Krinkle added a comment to D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.

Did you reproduce @Itms steps before the patch?

Sat, Jun 22, 8:18 PM
Krinkle added inline comments to D1971: Support attack-ground for ranged units..
Sat, Jun 22, 8:15 PM
Krinkle added inline comments to D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.
Sat, Jun 22, 2:41 AM

Fri, Jun 21

Krinkle added a comment to D1988: Workaround differences between libc and libstd string stream parsing of float/doubles.

Looks like the conversation is coming back around to where we were at D1978, but with higher confidence and better understanding.

Fri, Jun 21, 10:43 PM
Krinkle requested changes to D1971: Support attack-ground for ranged units..
Fri, Jun 21, 10:33 PM
Krinkle updated the summary of D2003: Linting: Enable 'no-floating-decimal' rule in ESLint.
Fri, Jun 21, 9:55 PM
Krinkle updated the diff for D2004: Linter: Fix ESLint semicolon-related warnings.

(Re-upload of same diff with more context lines to aid in review.)

Fri, Jun 21, 9:47 PM
Krinkle added a comment to D1990: Add Krinkle to 0 A.D.'s programming credits.

Looks accurate to me :)

Fri, Jun 21, 9:43 PM

Jun 20 2019

Krinkle added a comment to D1691: Remove boost "system" from Mac OS build system..

I tried to test this on macOS 10.14 Mojave, but couldn't get it to work.

Jun 20 2019, 4:49 AM
Krinkle added a comment to D1483: Use Homebrew to fetch OSX libraries instead of compiling them all.

I think this means versions are no longer controlled and libs no longer statically linked, thus the build no longer standalone and deterministic.

Jun 20 2019, 4:36 AM
Krinkle created D2004: Linter: Fix ESLint semicolon-related warnings.
Jun 20 2019, 1:45 AM
Krinkle retitled D1993: petra: Fix all ESLint and JSHint warnings from petra: Fix up most eslint warnings to petra: Fix all ESLint and JSHint warnings.
Jun 20 2019, 1:14 AM
Krinkle created D2003: Linting: Enable 'no-floating-decimal' rule in ESLint.
Jun 20 2019, 1:14 AM
Krinkle updated the diff for D1993: petra: Fix all ESLint and JSHint warnings.

Fixed the two remaining JSHint warnings as well.

Jun 20 2019, 12:58 AM
Krinkle added a comment to D1993: petra: Fix all ESLint and JSHint warnings.
In D1993#83352, @Stan wrote:

Maybe you can fix the last two warning (trailing dots)

Jun 20 2019, 12:19 AM

Jun 19 2019

Krinkle added inline comments to D1993: petra: Fix all ESLint and JSHint warnings.
Jun 19 2019, 11:28 PM
Krinkle updated the diff for D1993: petra: Fix all ESLint and JSHint warnings.
  • Used eslint --fix to automatically fix the curly warnings as well per the 0AD coding conventions.
  • Implemented the proposal for making the PETRA module files to use a slightly simpler structure. The previous structure had some extra indirection with variable overrides that didn't actually work (as ESLint correctly flagged), and turned out to be redundant anyhow.
Jun 19 2019, 11:06 PM
Krinkle added a comment to D1993: petra: Fix all ESLint and JSHint warnings.
In D1993#83293, @Stan wrote:

Before this get committed you might as well want to fix the warnings that appeared in the Vulkan console.

Jun 19 2019, 8:57 PM
Krinkle added inline comments to D1993: petra: Fix all ESLint and JSHint warnings.
Jun 19 2019, 8:55 PM
Krinkle added a comment to D1993: petra: Fix all ESLint and JSHint warnings.

Hoping to see this land relatively soon to avoid merge conflicts, after that I'll move on to the next area to lint :)

Jun 19 2019, 6:04 PM
Krinkle added a reviewer for D1993: petra: Fix all ESLint and JSHint warnings: Restricted Owners Package.
Jun 19 2019, 6:03 PM

Jun 18 2019

Krinkle added inline comments to D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.
Jun 18 2019, 1:07 AM

Jun 16 2019

Krinkle added a comment to D1617: implement Travis code integration testing.

While I support Travis CI, as mentioned it will be limited to daily post-merge builds from the GitHub mirror.

Jun 16 2019, 11:54 PM
Krinkle updated Krinkle.
Jun 16 2019, 11:49 PM
Krinkle added a member for macOS Developers: Krinkle.
Jun 16 2019, 11:47 PM
Krinkle updated the diff for D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.

Fixed the bug caught by Vector3D roundtrip test. Was accidentally setting y twice, and not z.

Jun 16 2019, 11:37 PM
Krinkle added inline comments to D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.
Jun 16 2019, 11:34 PM
Krinkle added a comment to D1993: petra: Fix all ESLint and JSHint warnings.

The full list of warnings that existed here before this commit:

Jun 16 2019, 10:53 PM