Page MenuHomeWildfire Games

Krinkle (Timo Tijhof)
Engineering

Projects

User Details

User Since
Jun 15 2019, 3:22 AM (42 w, 6 d)

Blog: https://timotijhof.net
Twitter: @TimoTijhof
GitHub: Krinkle
Wildfire Games Forum: Krinkle
Interests: JavaScript macOS Continuous Integration Localisation NL (Dutch)


Recent Activity

Sat, Apr 4

Krinkle requested changes to D2689: Update fmt to the most recent release.

I'm happy to help, with we do have a macOS worker in the Jenkins pipeline already. It'd be good to see that passing first:
https://jenkins.wildfiregames.com/blue/organizations/jenkins/macos-differential/detail/macos-differential/542/pipeline/41

Sat, Apr 4, 8:46 PM

Fri, Apr 3

Krinkle added a comment to D2689: Update fmt to the most recent release.

I can help with testing on macOS. Unfortunately, it seems trunk is not compiling well currently on macOS due to a problem with NVTT. I've filed https://trac.wildfiregames.com/ticket/5710.

Fri, Apr 3, 4:58 AM

Mar 11 2020

Krinkle updated the summary of D2649: build-osx-libs: Compare lib version instead of dir mtime.
Mar 11 2020, 4:19 AM · macOS Developers
Krinkle added a project to D2649: build-osx-libs: Compare lib version instead of dir mtime: macOS Developers.
Mar 11 2020, 4:18 AM · macOS Developers
Krinkle updated subscribers of D2649: build-osx-libs: Compare lib version instead of dir mtime.
Mar 11 2020, 4:18 AM · macOS Developers

Mar 1 2020

Stan awarded D2649: build-osx-libs: Compare lib version instead of dir mtime a Love token.
Mar 1 2020, 11:41 PM · macOS Developers
Krinkle created D2649: build-osx-libs: Compare lib version instead of dir mtime.
Mar 1 2020, 11:39 PM · macOS Developers
Krinkle accepted D2563: NVTT build fixes.

I've confirmed that the nvtt issue still exists on latest trunk for me (using macOS 10.14.6), and re-confirmed that with this patch applied, it builds nicely without issue.

Mar 1 2020, 10:47 PM

Feb 4 2020

Krinkle awarded D2563: NVTT build fixes a Orange Medal token.
Feb 4 2020, 9:23 PM

Feb 3 2020

Krinkle updated the diff for D2279: UnitAI: Fix ESLint coding style warnings.
Feb 3 2020, 10:54 PM
Krinkle added a comment to D2279: UnitAI: Fix ESLint coding style warnings.

Rebased to resolve merge conflicts.

Feb 3 2020, 3:28 AM
Krinkle updated the summary of D2279: UnitAI: Fix ESLint coding style warnings.
Feb 3 2020, 3:27 AM

Jan 7 2020

Krinkle added a comment to rP23305: Upgrade NVTT to version 2.1.1, fixes #4549..

Thanks, I've tried that now. (Also, I was expecting the script to track the version of lib it built instead of boolean. Seems simple to implement, will consider that later.)

Jan 7 2020, 12:50 AM

Jan 6 2020

Krinkle added a comment to D2523: Jenkins scripts and tweaks for OSX.

Ref https://trac.wildfiregames.com/ticket/5595 :)

Jan 6 2020, 9:29 PM · macOS Developers
Krinkle added a comment to rP23305: Upgrade NVTT to version 2.1.1, fixes #4549..

I'm having the same issue on macOS 10.14.6 Mojave.

Jan 6 2020, 4:53 AM

Dec 19 2019

Krinkle awarded D2483: Gamesetup class rewrite a Love token.
Dec 19 2019, 4:04 AM

Dec 10 2019

Krinkle added a comment to D2459: Play an animation when buildings a researching techs..

Should this be limited to the current player's own researching? Or also their allies? What about enemies?

Dec 10 2019, 2:59 AM

Dec 8 2019

Krinkle added inline comments to D1633: PerlinPainter add to rmgen..
Dec 8 2019, 3:17 AM

Dec 7 2019

Krinkle updated the test plan for D2005: Standardize "Territory Influence" in tooltips.
Dec 7 2019, 10:10 PM
Krinkle updated the summary of D2005: Standardize "Territory Influence" in tooltips.
Dec 7 2019, 10:07 PM
Krinkle updated the Trac tickets for D2452: Linting: Remove "no-lone-blocks" rule for ESLint.
Dec 7 2019, 10:06 PM
Krinkle retitled D2452: Linting: Remove "no-lone-blocks" rule for ESLint from lobby: Fix remaining ESLint warnings to Linting: Remove "no-lone-blocks" rule for ESLint.
Dec 7 2019, 10:05 PM
Krinkle added inline comments to rP23172: Rewrite lobby page to use class semantics, add more gamedetails labels, improve….
Dec 7 2019, 10:05 PM
Krinkle updated the diff for D2452: Linting: Remove "no-lone-blocks" rule for ESLint.
Dec 7 2019, 10:03 PM

Dec 5 2019

Krinkle updated the diff for D2005: Standardize "Territory Influence" in tooltips.

(Rebased.)

Dec 5 2019, 11:53 PM
Krinkle updated the diff for D2279: UnitAI: Fix ESLint coding style warnings.

Rebased to account for other changes in the repos since mid-September.

Dec 5 2019, 11:51 PM
Krinkle added inline comments to rP23172: Rewrite lobby page to use class semantics, add more gamedetails labels, improve….
Dec 5 2019, 11:50 PM
Krinkle created D2452: Linting: Remove "no-lone-blocks" rule for ESLint.
Dec 5 2019, 11:49 PM
Krinkle awarded rP23172: Rewrite lobby page to use class semantics, add more gamedetails labels, improve… a Orange Medal token.
Dec 5 2019, 11:37 PM
Krinkle abandoned D2261: lobby,gamesetup: Fix remaining ESLint warnings.

Superseded by rP23172. Looks like three other issues were introduced there but I will fix those separately so as to not confuse the references to this patch number.

Dec 5 2019, 11:34 PM
Krinkle added inline comments to rP23172: Rewrite lobby page to use class semantics, add more gamedetails labels, improve….
Dec 5 2019, 11:33 PM

Oct 18 2019

Krinkle updated Krinkle.
Oct 18 2019, 9:56 PM

Oct 6 2019

Krinkle added inline comments to D2261: lobby,gamesetup: Fix remaining ESLint warnings.
Oct 6 2019, 1:45 AM
Krinkle added inline comments to D2261: lobby,gamesetup: Fix remaining ESLint warnings.
Oct 6 2019, 1:45 AM

Sep 29 2019

Krinkle updated the diff for D2279: UnitAI: Fix ESLint coding style warnings.

Updated IsAnimal to use stricter !== undefined check instead of bool cast.

Sep 29 2019, 1:35 AM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sep 29 2019, 1:34 AM

Sep 25 2019

Krinkle resigned from rP22881: ptolemy houses, Enrique's pines.
Sep 25 2019, 9:04 PM
Krinkle added inline comments to D284: lobby: Display observer count in gameslist.
Sep 25 2019, 9:01 PM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sep 25 2019, 8:56 PM

Sep 22 2019

Krinkle added inline comments to D2261: lobby,gamesetup: Fix remaining ESLint warnings.
Sep 22 2019, 10:08 PM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sep 22 2019, 10:04 PM
Krinkle raised a concern with rP22881: ptolemy houses, Enrique's pines.

Found during today's test match on r22960.

Sep 22 2019, 12:31 AM

Sep 15 2019

Krinkle awarded D966: Don't show silhouettes through fields and berries a Orange Medal token.
Sep 15 2019, 1:41 AM

Sep 14 2019

Krinkle added inline comments to D284: lobby: Display observer count in gameslist.
Sep 14 2019, 8:13 PM
Krinkle updated the diff for D284: lobby: Display observer count in gameslist.

(Updated translation info to say "human" instead of "non-bot" player.)

Sep 14 2019, 8:07 PM
Krinkle updated the diff for D2279: UnitAI: Fix ESLint coding style warnings.
Sep 14 2019, 7:57 PM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sep 14 2019, 7:57 PM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sep 14 2019, 7:02 PM
Krinkle updated the diff for D2279: UnitAI: Fix ESLint coding style warnings.

Added line breaks in a multi-line conditional.

Sep 14 2019, 6:58 AM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sep 14 2019, 6:57 AM
Krinkle updated the diff for D2279: UnitAI: Fix ESLint coding style warnings.

Removed redundant parenthesis.

Sep 14 2019, 6:49 AM
Krinkle updated the diff for D2005: Standardize "Territory Influence" in tooltips.

Rebased to re-trigger CI which had a false negative it seems.

Sep 14 2019, 5:28 AM

Sep 13 2019

Krinkle updated the diff for D284: lobby: Display observer count in gameslist.
Sep 13 2019, 1:52 AM
Krinkle added inline comments to D284: lobby: Display observer count in gameslist.
Sep 13 2019, 1:50 AM
Krinkle updated the diff for D284: lobby: Display observer count in gameslist.

Addressed concerns raised on previous diff.

Sep 13 2019, 1:50 AM
Krinkle planned changes to D2279: UnitAI: Fix ESLint coding style warnings.
Sep 13 2019, 12:08 AM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sep 13 2019, 12:08 AM

Sep 10 2019

Krinkle updated the summary of D2279: UnitAI: Fix ESLint coding style warnings.
Sep 10 2019, 3:38 AM
Krinkle created D2279: UnitAI: Fix ESLint coding style warnings.
Sep 10 2019, 3:38 AM

Sep 8 2019

Krinkle added a comment to D2247: [gui]: no decimals for armor tooltip.

Perhaps a "temporary" compromise could be to keep 1 digit only if the number is less than 1? I think as long as it is above 1, players may be more forgiving of rounding errors

Sep 8 2019, 4:42 PM

Sep 7 2019

Krinkle updated the diff for D2261: lobby,gamesetup: Fix remaining ESLint warnings.
Sep 7 2019, 10:38 PM

Sep 6 2019

Krinkle added inline comments to D2240: Move Mainmenu from XML to JS and use object oriented JS.
Sep 6 2019, 2:45 AM

Sep 5 2019

Krinkle updated the test plan for D2261: lobby,gamesetup: Fix remaining ESLint warnings.
Sep 5 2019, 1:17 AM
Krinkle created D2261: lobby,gamesetup: Fix remaining ESLint warnings.
Sep 5 2019, 1:14 AM

Sep 3 2019

Krinkle added inline comments to rP20697: Add helper function to apply arbitrary GUI tags (such as font and color)..
Sep 3 2019, 7:07 PM
Krinkle added inline comments to rP20697: Add helper function to apply arbitrary GUI tags (such as font and color)..
Sep 3 2019, 7:06 PM

Sep 2 2019

Krinkle updated the summary of D284: lobby: Display observer count in gameslist.
Sep 2 2019, 3:18 AM
Krinkle updated the diff for D284: lobby: Display observer count in gameslist.
Sep 2 2019, 2:41 AM
Krinkle added inline comments to D284: lobby: Display observer count in gameslist.
Sep 2 2019, 2:40 AM
Krinkle updated the diff for D284: lobby: Display observer count in gameslist.

Per CR:

  • Factored out color to a global variable.
  • Make use of the newer setStringTags function.
  • Keep translate() call inline (this means it isn't cached, but I guess that's fine?).
Sep 2 2019, 2:40 AM
Krinkle awarded D2079: Adds snapping to edges for buildings a Orange Medal token.
Sep 2 2019, 2:09 AM
Krinkle added a comment to rP21984: Corinthian Helmet Update:.

Created a thread at https://wildfiregames.com/forum/index.php?/topic/26940-hovering-shrubbery-bushes/.

Sep 2 2019, 12:10 AM

Sep 1 2019

Krinkle updated the diff for D2005: Standardize "Territory Influence" in tooltips.

Rebased on latest trunk.

Sep 1 2019, 7:16 PM
Krinkle added inline comments to D2240: Move Mainmenu from XML to JS and use object oriented JS.
Sep 1 2019, 4:15 PM
Krinkle added inline comments to D2213: Delete CSimulation2 m_MapSettings and redundant getters.
Sep 1 2019, 1:43 AM
Krinkle added inline comments to D2240: Move Mainmenu from XML to JS and use object oriented JS.
Sep 1 2019, 1:35 AM
Krinkle added inline comments to D2240: Move Mainmenu from XML to JS and use object oriented JS.
Sep 1 2019, 1:34 AM

Aug 31 2019

Krinkle created D2238: simulation: Use Object.create(parent) to create inheriting objects.
Aug 31 2019, 6:12 PM
Krinkle updated the summary of D2237: Linting: Enable no-caller and no-irregular-whitespace in ESLint.
Aug 31 2019, 5:26 PM
Krinkle created D2237: Linting: Enable no-caller and no-irregular-whitespace in ESLint.
Aug 31 2019, 5:25 PM
Krinkle updated the test plan for D1993: petra: Fix all ESLint and JSHint warnings.
Aug 31 2019, 5:08 PM
Krinkle updated the diff for D1993: petra: Fix all ESLint and JSHint warnings.
Aug 31 2019, 4:58 PM
Krinkle updated the summary of D1993: petra: Fix all ESLint and JSHint warnings.
Aug 31 2019, 4:57 PM

Aug 29 2019

Krinkle updated the diff for D2103: petra: Remove redundant 'PETRA' variable indirection.
Aug 29 2019, 2:53 PM

Aug 26 2019

elexis awarded D2103: petra: Remove redundant 'PETRA' variable indirection a Like token.
Aug 26 2019, 12:46 AM

Aug 25 2019

Krinkle updated the diff for D2103: petra: Remove redundant 'PETRA' variable indirection.
Aug 25 2019, 11:56 PM

Aug 23 2019

Krinkle reclaimed D2090: glooxwrapper: Remove unused private 'm_Owned' in Jingle::Session::Jingle.
Aug 23 2019, 1:56 PM

Aug 18 2019

Krinkle added inline comments to D1767: Rewrite Profiler2's GUI using D3 / CanvasJS.
Aug 18 2019, 2:46 PM

Aug 6 2019

Krinkle updated the diff for D2147: gui/gamesetup: Fix no-unmodified-loop-condition warning on 'g_IsNetworked'.

(Rebased)

Aug 6 2019, 10:21 PM
Krinkle updated the diff for D2146: gui/common: Fix ESLint code quality violations.

(Rebased)

Aug 6 2019, 10:20 PM

Aug 4 2019

Krinkle updated the diff for D2147: gui/gamesetup: Fix no-unmodified-loop-condition warning on 'g_IsNetworked'.
Aug 4 2019, 8:58 PM
Krinkle updated the Trac tickets for D2147: gui/gamesetup: Fix no-unmodified-loop-condition warning on 'g_IsNetworked'.
Aug 4 2019, 8:21 PM
Krinkle created D2147: gui/gamesetup: Fix no-unmodified-loop-condition warning on 'g_IsNetworked'.
Aug 4 2019, 8:21 PM
Krinkle created D2146: gui/common: Fix ESLint code quality violations.
Aug 4 2019, 7:59 PM
Krinkle updated the test plan for D2103: petra: Remove redundant 'PETRA' variable indirection.
Aug 4 2019, 1:19 AM

Jul 28 2019

Krinkle updated the diff for D2005: Standardize "Territory Influence" in tooltips.

Appearance:

  • Change phrasing away from the status quo of "Buildings in the territory do not decay", to be like @elexis suggestion: "This structure provides territory rooting".
  • Make the Territory tooltip included when hovering icons in the Tech Tree, this should make it relatively easy for players to quickly find which buildings can provide territory rooting. This change was done by moving the function from viewer#g_InfoFunctions to draw#g_StatsFunctions *thus more like getPopulationBonusTooltip, and less like getAurasTooltip). This two side-effects:
    • In the "More information" dialog, it is now crammed in the top part, instead of in the more spaced out body area.
    • When selecting an existing structure on the map that has rooting and hovering the central panel on the screen, this tooltip is not included.
Jul 28 2019, 5:12 PM
Krinkle updated the diff for D284: lobby: Display observer count in gameslist.
  • Use the coloredText() function instead of an inline [color] construct (the utility was added in Dec 2017, a few months after the patch started).
  • Switched from postfix to prefix increment.
  • Switch away from (N) format, back to +N, and allow the observer count formatting to be translated.
  • Change observer count colour from yellow to grey, so that the player count remains more prominent.
Jul 28 2019, 4:27 PM
Krinkle awarded D1781: Fix lobby chat performance issue. a Orange Medal token.
Jul 28 2019, 3:51 PM

Jul 27 2019

Krinkle updated the summary of D2103: petra: Remove redundant 'PETRA' variable indirection.
Jul 27 2019, 5:21 PM
Krinkle updated the summary of D2103: petra: Remove redundant 'PETRA' variable indirection.
Jul 27 2019, 5:18 PM