- User Since
- Jun 15 2019, 3:22 AM (5 w, 22 h)
- Rebased on latest trunk.
- Re-used earlier result of parsing the game.players string.
- Implemented the suggestion of displaying (N) instead of +N.
- Increase colour and brightness for consistency with other text.
Reduced to only curly. Keeping no-multi-spaces enabled, which per @elexis is desirable to enforce, but just something we need to fix in a few existing files.
Wed, Jul 17
Causes more warnings. Needs additional changes to either accommodate the absence of this field, or additional changes to make the original version not cause warnings.
Okay, it can't just be removed as-is.
Fixed by rP22488.
Note to self: rename FAILVOID to FAIL_VOID.
Tue, Jul 16
Removed not so useful comment.
Add failure checks for JS_GetProperty and JS::Construct. Also removed the redundant ret.setObject/obj.getObject indirection in favour of letting JS::Construct populate ret directly. Seems to work, and the type hints match. Don't know this is "right", though.
Switch from long-form RootedValue/ToJSVal, to the shorter JS::Value#setNumber() form instead.
Mon, Jul 15
According to ESLint 6, on latest trunk, checking binaries/data/, there are:
It seems the Jenkins build did not apply the parent patch from the stack, hence there are violations found (naturally) for the rules we proposed to disable (curly, and no-multi-spaces).
@elexis I've been told four different things by four different people :)
Now depends on D2070.
I'll redo this diff on top of D2070 locally. In particular, it'll mean it won't try to "improve" around curly braces.
Sun, Jul 14
Sat, Jul 13
Fri, Jul 12
Mon, Jul 1
@wraitii Go ahead :)
Sun, Jun 30
A few options mentioned so far:
Sat, Jun 29
Wed, Jun 26
Mon, Jun 24
Sun, Jun 23
Sat, Jun 22
Fri, Jun 21
Looks like the conversation is coming back around to where we were at D1978, but with higher confidence and better understanding.
(Re-upload of same diff with more context lines to aid in review.)
Looks accurate to me :)
Jun 20 2019
I tried to test this on macOS 10.14 Mojave, but couldn't get it to work.
I think this means versions are no longer controlled and libs no longer statically linked, thus the build no longer standalone and deterministic.
Fixed the two remaining JSHint warnings as well.
Jun 19 2019
- Used eslint --fix to automatically fix the curly warnings as well per the 0AD coding conventions.
- Implemented the proposal for making the PETRA module files to use a slightly simpler structure. The previous structure had some extra indirection with variable overrides that didn't actually work (as ESLint correctly flagged), and turned out to be redundant anyhow.
Hoping to see this land relatively soon to avoid merge conflicts, after that I'll move on to the next area to lint :)
Jun 18 2019
Jun 16 2019
While I support Travis CI, as mentioned it will be limited to daily post-merge builds from the GitHub mirror.
Fixed the bug caught by Vector3D roundtrip test. Was accidentally setting y twice, and not z.