Page MenuHomeWildfire Games

Krinkle (Timo Tijhof)
Engineering

Projects

User Details

User Since
Jun 15 2019, 3:22 AM (13 w, 1 d)

GitHub: Krinkle
Twitter: @TimoTijhof
Wildfire Games Forum: Krinkle
Interests: JavaScript macOS Continuous Integration Localisation NL (Dutch) Localisation DE (German)


Recent Activity

Today

Krinkle awarded D966: Don't show silhouettes through fields and berries a Orange Medal token.
Sun, Sep 15, 1:41 AM

Yesterday

Krinkle added inline comments to D284: lobby: Display observer count in gameslist.
Sat, Sep 14, 8:13 PM
Krinkle updated the diff for D284: lobby: Display observer count in gameslist.

(Updated translation info to say "human" instead of "non-bot" player.)

Sat, Sep 14, 8:07 PM
Krinkle updated the diff for D2279: UnitAI: Fix ESLint coding style warnings.
Sat, Sep 14, 7:57 PM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sat, Sep 14, 7:57 PM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sat, Sep 14, 7:02 PM
Krinkle updated the diff for D2279: UnitAI: Fix ESLint coding style warnings.

Added line breaks in a multi-line conditional.

Sat, Sep 14, 6:58 AM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sat, Sep 14, 6:57 AM
Krinkle updated the diff for D2279: UnitAI: Fix ESLint coding style warnings.

Removed redundant parenthesis.

Sat, Sep 14, 6:49 AM
Krinkle updated the diff for D2005: Standardize "Territory Influence" in tooltips.

Rebased to re-trigger CI which had a false negative it seems.

Sat, Sep 14, 5:28 AM

Fri, Sep 13

Krinkle updated the diff for D284: lobby: Display observer count in gameslist.
Fri, Sep 13, 1:52 AM
Krinkle added inline comments to D284: lobby: Display observer count in gameslist.
Fri, Sep 13, 1:50 AM
Krinkle updated the diff for D284: lobby: Display observer count in gameslist.

Addressed concerns raised on previous diff.

Fri, Sep 13, 1:50 AM
Krinkle planned changes to D2279: UnitAI: Fix ESLint coding style warnings.
Fri, Sep 13, 12:08 AM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Fri, Sep 13, 12:08 AM

Tue, Sep 10

Krinkle updated the summary of D2279: UnitAI: Fix ESLint coding style warnings.
Tue, Sep 10, 3:38 AM
Krinkle created D2279: UnitAI: Fix ESLint coding style warnings.
Tue, Sep 10, 3:38 AM

Sun, Sep 8

Krinkle added a comment to D2247: no decimals for armor tooltip.

Perhaps a "temporary" compromise could be to keep 1 digit only if the number is less than 1? I think as long as it is above 1, players may be more forgiving of rounding errors

Sun, Sep 8, 4:42 PM

Sat, Sep 7

Krinkle updated the diff for D2261: lobby,gamesetup: Fix remaining ESLint warnings.
Sat, Sep 7, 10:38 PM

Fri, Sep 6

Krinkle added inline comments to D2240: Move Mainmenu from XML to JS and use object oriented JS.
Fri, Sep 6, 2:45 AM

Thu, Sep 5

Krinkle updated the test plan for D2261: lobby,gamesetup: Fix remaining ESLint warnings.
Thu, Sep 5, 1:17 AM
Krinkle created D2261: lobby,gamesetup: Fix remaining ESLint warnings.
Thu, Sep 5, 1:14 AM

Tue, Sep 3

Krinkle added inline comments to rP20697: Add helper function to apply arbitrary GUI tags (such as font and color)..
Tue, Sep 3, 7:07 PM
Krinkle added inline comments to rP20697: Add helper function to apply arbitrary GUI tags (such as font and color)..
Tue, Sep 3, 7:06 PM

Mon, Sep 2

Krinkle updated the summary of D284: lobby: Display observer count in gameslist.
Mon, Sep 2, 3:18 AM
Krinkle updated the diff for D284: lobby: Display observer count in gameslist.
Mon, Sep 2, 2:41 AM
Krinkle added inline comments to D284: lobby: Display observer count in gameslist.
Mon, Sep 2, 2:40 AM
Krinkle updated the diff for D284: lobby: Display observer count in gameslist.

Per CR:

  • Factored out color to a global variable.
  • Make use of the newer setStringTags function.
  • Keep translate() call inline (this means it isn't cached, but I guess that's fine?).
Mon, Sep 2, 2:40 AM
Krinkle awarded D2079: Adds snapping to edges for buildings a Orange Medal token.
Mon, Sep 2, 2:09 AM
Krinkle added a comment to rP21984: Corinthian Helmet Update:.

Created a thread at https://wildfiregames.com/forum/index.php?/topic/26940-hovering-shrubbery-bushes/.

Mon, Sep 2, 12:10 AM

Sun, Sep 1

Krinkle updated the diff for D2005: Standardize "Territory Influence" in tooltips.

Rebased on latest trunk.

Sun, Sep 1, 7:16 PM
Krinkle added inline comments to D2240: Move Mainmenu from XML to JS and use object oriented JS.
Sun, Sep 1, 4:15 PM
Krinkle added inline comments to D2213: Delete CSimulation2 m_MapSettings and redundant getters.
Sun, Sep 1, 1:43 AM
Krinkle added inline comments to D2240: Move Mainmenu from XML to JS and use object oriented JS.
Sun, Sep 1, 1:35 AM
Krinkle added inline comments to D2240: Move Mainmenu from XML to JS and use object oriented JS.
Sun, Sep 1, 1:34 AM

Sat, Aug 31

Krinkle created D2238: simulation: Use Object.create(parent) to create inheriting objects.
Sat, Aug 31, 6:12 PM
Krinkle updated the summary of D2237: Linting: Enable no-caller and no-irregular-whitespace in ESLint.
Sat, Aug 31, 5:26 PM
Krinkle created D2237: Linting: Enable no-caller and no-irregular-whitespace in ESLint.
Sat, Aug 31, 5:25 PM
Krinkle updated the test plan for D1993: petra: Fix all ESLint and JSHint warnings.
Sat, Aug 31, 5:08 PM
Krinkle updated the diff for D1993: petra: Fix all ESLint and JSHint warnings.
Sat, Aug 31, 4:58 PM
Krinkle updated the summary of D1993: petra: Fix all ESLint and JSHint warnings.
Sat, Aug 31, 4:57 PM

Thu, Aug 29

Krinkle updated the diff for D2103: petra: Remove redundant 'PETRA' variable indirection.
Thu, Aug 29, 2:53 PM

Mon, Aug 26

elexis awarded D2103: petra: Remove redundant 'PETRA' variable indirection a Like token.
Mon, Aug 26, 12:46 AM

Sun, Aug 25

Krinkle updated the diff for D2103: petra: Remove redundant 'PETRA' variable indirection.
Sun, Aug 25, 11:56 PM

Fri, Aug 23

Krinkle reclaimed D2090: glooxwrapper: Remove unused private 'm_Owned' in Jingle::Session::Jingle.
Fri, Aug 23, 1:56 PM

Sun, Aug 18

Krinkle added inline comments to D1767: Rewrite Profiler2's GUI using D3 / CanvasJS.
Sun, Aug 18, 2:46 PM

Aug 6 2019

Krinkle updated the diff for D2147: gui/gamesetup: Fix no-unmodified-loop-condition warning on 'g_IsNetworked'.

(Rebased)

Aug 6 2019, 10:21 PM
Krinkle updated the diff for D2146: gui/common: Fix ESLint code quality violations.

(Rebased)

Aug 6 2019, 10:20 PM

Aug 4 2019

Krinkle updated the diff for D2147: gui/gamesetup: Fix no-unmodified-loop-condition warning on 'g_IsNetworked'.
Aug 4 2019, 8:58 PM
Krinkle updated the Trac tickets for D2147: gui/gamesetup: Fix no-unmodified-loop-condition warning on 'g_IsNetworked'.
Aug 4 2019, 8:21 PM
Krinkle created D2147: gui/gamesetup: Fix no-unmodified-loop-condition warning on 'g_IsNetworked'.
Aug 4 2019, 8:21 PM
Krinkle created D2146: gui/common: Fix ESLint code quality violations.
Aug 4 2019, 7:59 PM
Krinkle updated the test plan for D2103: petra: Remove redundant 'PETRA' variable indirection.
Aug 4 2019, 1:19 AM

Jul 28 2019

Krinkle updated the diff for D2005: Standardize "Territory Influence" in tooltips.

Appearance:

  • Change phrasing away from the status quo of "Buildings in the territory do not decay", to be like @elexis suggestion: "This structure provides territory rooting".
  • Make the Territory tooltip included when hovering icons in the Tech Tree, this should make it relatively easy for players to quickly find which buildings can provide territory rooting. This change was done by moving the function from viewer#g_InfoFunctions to draw#g_StatsFunctions *thus more like getPopulationBonusTooltip, and less like getAurasTooltip). This two side-effects:
    • In the "More information" dialog, it is now crammed in the top part, instead of in the more spaced out body area.
    • When selecting an existing structure on the map that has rooting and hovering the central panel on the screen, this tooltip is not included.
Jul 28 2019, 5:12 PM
Krinkle updated the diff for D284: lobby: Display observer count in gameslist.
  • Use the coloredText() function instead of an inline [color] construct (the utility was added in Dec 2017, a few months after the patch started).
  • Switched from postfix to prefix increment.
  • Switch away from (N) format, back to +N, and allow the observer count formatting to be translated.
  • Change observer count colour from yellow to grey, so that the player count remains more prominent.
Jul 28 2019, 4:27 PM
Krinkle awarded D1781: Fix lobby chat performance issue. a Orange Medal token.
Jul 28 2019, 3:51 PM

Jul 27 2019

Krinkle updated the summary of D2103: petra: Remove redundant 'PETRA' variable indirection.
Jul 27 2019, 5:21 PM
Krinkle updated the summary of D2103: petra: Remove redundant 'PETRA' variable indirection.
Jul 27 2019, 5:18 PM
Krinkle updated the diff for D2103: petra: Remove redundant 'PETRA' variable indirection.

(Rebased. Hopefully Jenkins is working again properly now.)

Jul 27 2019, 5:15 PM

Jul 24 2019

Krinkle added inline comments to D284: lobby: Display observer count in gameslist.
Jul 24 2019, 2:30 AM

Jul 21 2019

Krinkle accepted D2080: Replace Eval calls with new ScriptInterface CreateObject and CreateArray functions.

LGTM! Statically reviewers and everything looks functionally identical, with one or two naming improvements.

Jul 21 2019, 11:44 PM
Krinkle added inline comments to D2080: Replace Eval calls with new ScriptInterface CreateObject and CreateArray functions.
Jul 21 2019, 10:51 PM
Krinkle added inline comments to D1684: Pass callback function to PushGuiPage and unify PopGuiPage/PopGuiPageCB.
Jul 21 2019, 3:04 AM
Krinkle updated the diff for D284: lobby: Display observer count in gameslist.
Jul 21 2019, 1:22 AM
Krinkle updated the diff for D284: lobby: Display observer count in gameslist.
  • Rebased on latest trunk.
  • Re-used earlier result of parsing the game.players string.
  • Implemented the suggestion of displaying (N) instead of +N.
  • Increase colour and brightness for consistency with other text.
Jul 21 2019, 1:21 AM
Krinkle added inline comments to D284: lobby: Display observer count in gameslist.
Jul 21 2019, 1:14 AM
Krinkle added inline comments to D284: lobby: Display observer count in gameslist.
Jul 21 2019, 1:14 AM
Krinkle commandeered D284: lobby: Display observer count in gameslist.
Jul 21 2019, 12:48 AM

Jul 20 2019

Krinkle updated the diff for D1993: petra: Fix all ESLint and JSHint warnings.
Jul 20 2019, 10:20 PM
Krinkle added inline comments to D2080: Replace Eval calls with new ScriptInterface CreateObject and CreateArray functions.
Jul 20 2019, 10:09 PM
Krinkle updated the summary of D2103: petra: Remove redundant 'PETRA' variable indirection.
Jul 20 2019, 10:05 PM
Krinkle updated the summary of D2103: petra: Remove redundant 'PETRA' variable indirection.
Jul 20 2019, 10:04 PM
Krinkle added a comment to D2103: petra: Remove redundant 'PETRA' variable indirection.

This has been split out of D2103 as being the only semantic change (due to fixing a quality issue rather than a style issue). This way D2103, can focus solely on auto-fixed style changes.

Jul 20 2019, 10:01 PM
Krinkle updated the summary of D2103: petra: Remove redundant 'PETRA' variable indirection.
Jul 20 2019, 9:59 PM
Krinkle created D2103: petra: Remove redundant 'PETRA' variable indirection.
Jul 20 2019, 9:59 PM
Krinkle added a comment to rP22518: Fix incorrect use of setlocale() in cppformat CStr tests following rP22378.

From Jenkins:

Jul 20 2019, 9:39 PM
Krinkle updated the diff for D2070: Linting: Remove controversial 'curly' eslint rules.

Reduced to only curly. Keeping no-multi-spaces enabled, which per @elexis is desirable to enforce, but just something we need to fix in a few existing files.

Jul 20 2019, 9:36 PM
Krinkle updated the summary of D2070: Linting: Remove controversial 'curly' eslint rules.
Jul 20 2019, 9:35 PM
Krinkle updated the Trac tickets for D2004: Linter: Fix ESLint semicolon-related warnings.
Jul 20 2019, 9:33 PM
Krinkle updated the Trac tickets for D2003: Linting: Enable 'no-floating-decimal' rule in ESLint.
Jul 20 2019, 9:33 PM
Krinkle updated the Trac tickets for D1993: petra: Fix all ESLint and JSHint warnings.
Jul 20 2019, 9:32 PM
Krinkle updated the Trac tickets for D2070: Linting: Remove controversial 'curly' eslint rules.
Jul 20 2019, 9:31 PM
Krinkle added inline comments to D2080: Replace Eval calls with new ScriptInterface CreateObject and CreateArray functions.
Jul 20 2019, 7:25 PM

Jul 17 2019

Krinkle planned changes to D2090: glooxwrapper: Remove unused private 'm_Owned' in Jingle::Session::Jingle.

Causes more warnings. Needs additional changes to either accommodate the absence of this field, or additional changes to make the original version not cause warnings.

Jul 17 2019, 7:06 PM
Krinkle added a comment to D2090: glooxwrapper: Remove unused private 'm_Owned' in Jingle::Session::Jingle.

Okay, it can't just be removed as-is.

Jul 17 2019, 2:43 AM
Krinkle created D2090: glooxwrapper: Remove unused private 'm_Owned' in Jingle::Session::Jingle.
Jul 17 2019, 2:33 AM
Krinkle resigned from rP22487: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions..

Fixed by rP22488.

Jul 17 2019, 2:18 AM
Krinkle added 1 auditor(s) for rP22487: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.: Krinkle.

Note to self: rename FAILVOID to FAIL_VOID.

Jul 17 2019, 12:54 AM
Krinkle added inline comments to rP22487: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions..
Jul 17 2019, 12:54 AM

Jul 16 2019

Krinkle added inline comments to D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.
Jul 16 2019, 11:52 PM
Krinkle updated the diff for D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.

Removed not so useful comment.

Jul 16 2019, 11:52 PM
Krinkle added inline comments to D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.
Jul 16 2019, 11:10 PM
Krinkle updated the diff for D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.

Add failure checks for JS_GetProperty and JS::Construct. Also removed the redundant ret.setObject/obj.getObject indirection in favour of letting JS::Construct populate ret directly. Seems to work, and the type hints match. Don't know this is "right", though.

Jul 16 2019, 11:09 PM
Krinkle updated the diff for D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.

Switched from long-form RootedValue/ToJSVal, to the shorter JS::Value#setNumber() form instead, per @elexis suggestion.

Jul 16 2019, 10:34 PM

Jul 15 2019

Krinkle added inline comments to D2080: Replace Eval calls with new ScriptInterface CreateObject and CreateArray functions.
Jul 15 2019, 8:20 PM
Krinkle added a comment to D2070: Linting: Remove controversial 'curly' eslint rules.

According to ESLint 6, on latest trunk, checking binaries/data/, there are:

Jul 15 2019, 7:14 PM
Krinkle updated the summary of D1993: petra: Fix all ESLint and JSHint warnings.
Jul 15 2019, 6:50 PM
Krinkle added a comment to D1993: petra: Fix all ESLint and JSHint warnings.

It seems the Jenkins build did not apply the parent patch from the stack, hence there are violations found (naturally) for the rules we proposed to disable (curly, and no-multi-spaces).

Jul 15 2019, 6:48 PM
Krinkle added a comment to D2070: Linting: Remove controversial 'curly' eslint rules.

@elexis I've been told four different things by four different people :)

Jul 15 2019, 6:44 PM
Krinkle updated the diff for D1993: petra: Fix all ESLint and JSHint warnings.

Now depends on D2070.

Jul 15 2019, 6:38 PM