Page MenuHomeWildfire Games

Krinkle (Timo Tijhof)
Engineering

Projects

User Details

User Since
Jun 15 2019, 3:22 AM (66 w, 5 d)

Blog: https://timotijhof.net
Fediverse: @krinkle@mastodon.technology
GitHub: Krinkle
Wildfire Games Forum: Krinkle
Interests: JavaScript macOS Continuous Integration Localisation NL (Dutch)


Recent Activity

Sat, Sep 19

Krinkle added a comment to D2827: build-osx-libs: Update SDL to 2.0.12 (fix macOS 10.14+).

@Itms ping :)

Sat, Sep 19, 3:52 AM
Krinkle awarded D3004: Do not display right click tooltip when it is not supported right now a Orange Medal token.
Sat, Sep 19, 3:51 AM
Krinkle awarded rP24024: Clean Formation.js a Love token.
Sat, Sep 19, 3:48 AM
Krinkle abandoned D1617: implement Travis code integration testing.
Sat, Sep 19, 3:47 AM

Jun 21 2020

Krinkle added reviewers for D2827: build-osx-libs: Update SDL to 2.0.12 (fix macOS 10.14+): Itms, macOS Developers.
Jun 21 2020, 6:57 PM
Krinkle removed a reviewer for D2827: build-osx-libs: Update SDL to 2.0.12 (fix macOS 10.14+): macOS Developers.
Jun 21 2020, 6:56 PM
Krinkle created D2827: build-osx-libs: Update SDL to 2.0.12 (fix macOS 10.14+).
Jun 21 2020, 6:55 PM
Krinkle added a comment to D1671: Workaround for the SDL bug on macOS Mojave.
In D1671#66081, @Itms wrote:

Itms, could you point me where do you see about drop 10.9 to 10.11, because when i tried sdl2.0.9 i didnt change minimal osx version and builded normally

Yes, but if you linked Metal dynamically, users of the built bundle will not be able to start the game if they are below 10.11. Did I misunderstand something about the availability of Metal for older versions?

Jun 21 2020, 1:40 AM

Jun 20 2020

Krinkle added a comment to D2563: NVTT build fixes.

For what it's worth, I can no longer reproduce any kind of build failure with macOS 10.15 on latest trunk. It seems the GnuTLS, ICU and other libs changes have made this go away?

Jun 20 2020, 11:57 PM

Jun 14 2020

Krinkle awarded D2789: SSE Vector3D a Orange Medal token.
Jun 14 2020, 5:40 PM
Krinkle accepted D2766: Stop downloading boost from sourceforge.
Jun 14 2020, 1:52 AM

May 17 2020

Krinkle added a comment to D2746: Correctly serialize/deserialize user-defined JS objects..

The lexical scope of how test_vector.js is executed might need to change, I'm not sure. It's possible that it is already fine though. I can take a closer look later.

May 17 2020, 10:28 PM
Krinkle added inline comments to D2649: build-osx-libs: Compare lib version instead of dir mtime.
May 17 2020, 10:05 PM · macOS Developers
Krinkle added a comment to D2649: build-osx-libs: Compare lib version instead of dir mtime.
In D2649#115710, @Itms wrote:

[…] Currently if devs forget to bump the value of LIB_VERSION for SpiderMonkey, it won't build, because it won't find the archive.

May 17 2020, 9:35 PM · macOS Developers
Krinkle updated the diff for D2649: build-osx-libs: Compare lib version instead of dir mtime.

Hoist bundled lib versions to top of file. Add version suffix for nvtt as well.

May 17 2020, 9:35 PM · macOS Developers
Krinkle updated subscribers of D2649: build-osx-libs: Compare lib version instead of dir mtime.
May 17 2020, 1:26 AM · macOS Developers
Krinkle updated the diff for D2649: build-osx-libs: Compare lib version instead of dir mtime.
May 17 2020, 1:25 AM · macOS Developers
Krinkle updated the diff for D2649: build-osx-libs: Compare lib version instead of dir mtime.

Rebased.

May 17 2020, 1:22 AM · macOS Developers

May 3 2020

Krinkle added inline comments to D2718: Show correct cursor over minimap.
May 3 2020, 3:54 AM
Krinkle awarded D2718: Show correct cursor over minimap a Love token.
May 3 2020, 3:54 AM

May 2 2020

Krinkle added reviewers for D2717: build-osx-libs: Unbreak ICU 59 build (upstream URL changed): Restricted Owners Package, Itms.
May 2 2020, 7:27 PM
Krinkle added reviewers for D2716: build-osx-libs: Update GnuTLS to 3.6.13 (unbreak macOS 10.15): Restricted Owners Package, Itms.
May 2 2020, 7:26 PM
Krinkle added a comment to D2279: UnitAI: Fix ESLint coding style warnings.

Rebased, and also fixed two style regressions (trailing space, missing semi colon) that were introduced in trunk in recent weeks.

May 2 2020, 7:24 PM
Krinkle updated the diff for D2279: UnitAI: Fix ESLint coding style warnings.
May 2 2020, 7:24 PM
Krinkle added reviewers for D2279: UnitAI: Fix ESLint coding style warnings: Restricted Owners Package, elexis.
May 2 2020, 7:11 PM
Krinkle updated subscribers of D2279: UnitAI: Fix ESLint coding style warnings.
May 2 2020, 7:11 PM
Krinkle updated subscribers of D2716: build-osx-libs: Update GnuTLS to 3.6.13 (unbreak macOS 10.15).
May 2 2020, 6:52 PM

May 1 2020

Krinkle updated Krinkle.
May 1 2020, 11:49 PM
Krinkle created D2717: build-osx-libs: Unbreak ICU 59 build (upstream URL changed).
May 1 2020, 9:26 PM
Krinkle created D2716: build-osx-libs: Update GnuTLS to 3.6.13 (unbreak macOS 10.15).
May 1 2020, 9:17 PM

Apr 13 2020

Krinkle requested changes to D2689: Update fmt to the most recent release.

I have done the following on macOS 10.14 Mojave

  • Checkout latest trunk with D2563 and D2649 applied.
  • Perform a complete and clean build (libraries/osx/build-osx-libs.sh -j3, clean-workspace.sh, update-workspaces.sh -3, gcc$ make pyrogenesis -j3).
  • Apply this patch (D2689).
  • Re-run libraries/osx/build-osx-libs.sh -j3, which will only (re)compile fmt.
    • This step passed without errors.
  • Re-run clean-workspace.sh, update-workspaces.sh -3.
    • This step passed without errors.
  • Run gcc$ make pyrogenesis -j3
    • This step fails. Error attached below.
Apr 13 2020, 2:06 AM

Apr 4 2020

Krinkle requested changes to D2689: Update fmt to the most recent release.

I'm happy to help, with we do have a macOS worker in the Jenkins pipeline already. It'd be good to see that passing first:
https://jenkins.wildfiregames.com/blue/organizations/jenkins/macos-differential/detail/macos-differential/542/pipeline/41

Apr 4 2020, 8:46 PM

Apr 3 2020

Krinkle added a comment to D2689: Update fmt to the most recent release.

I can help with testing on macOS. Unfortunately, it seems trunk is not compiling well currently on macOS due to a problem with NVTT. I've filed https://trac.wildfiregames.com/ticket/5710.

Apr 3 2020, 4:58 AM

Mar 11 2020

Krinkle updated the summary of D2649: build-osx-libs: Compare lib version instead of dir mtime.
Mar 11 2020, 4:19 AM · macOS Developers
Krinkle added a project to D2649: build-osx-libs: Compare lib version instead of dir mtime: macOS Developers.
Mar 11 2020, 4:18 AM · macOS Developers
Krinkle updated subscribers of D2649: build-osx-libs: Compare lib version instead of dir mtime.
Mar 11 2020, 4:18 AM · macOS Developers

Mar 1 2020

Stan awarded D2649: build-osx-libs: Compare lib version instead of dir mtime a Love token.
Mar 1 2020, 11:41 PM · macOS Developers
Krinkle created D2649: build-osx-libs: Compare lib version instead of dir mtime.
Mar 1 2020, 11:39 PM · macOS Developers
Krinkle accepted D2563: NVTT build fixes.

I've confirmed that the nvtt issue still exists on latest trunk for me (using macOS 10.14.6), and re-confirmed that with this patch applied, it builds nicely without issue.

Mar 1 2020, 10:47 PM

Feb 4 2020

Krinkle awarded D2563: NVTT build fixes a Orange Medal token.
Feb 4 2020, 9:23 PM

Feb 3 2020

Krinkle updated the diff for D2279: UnitAI: Fix ESLint coding style warnings.
Feb 3 2020, 10:54 PM
Krinkle added a comment to D2279: UnitAI: Fix ESLint coding style warnings.

Rebased to resolve merge conflicts.

Feb 3 2020, 3:28 AM
Krinkle updated the summary of D2279: UnitAI: Fix ESLint coding style warnings.
Feb 3 2020, 3:27 AM

Jan 7 2020

Krinkle added a comment to rP23305: Upgrade NVTT to version 2.1.1, fixes #4549..

Thanks, I've tried that now. (Also, I was expecting the script to track the version of lib it built instead of boolean. Seems simple to implement, will consider that later.)

Jan 7 2020, 12:50 AM

Jan 6 2020

Krinkle added a comment to D2523: Jenkins scripts and tweaks for OSX.

Ref https://trac.wildfiregames.com/ticket/5595 :)

Jan 6 2020, 9:29 PM · macOS Developers
Krinkle added a comment to rP23305: Upgrade NVTT to version 2.1.1, fixes #4549..

I'm having the same issue on macOS 10.14.6 Mojave.

Jan 6 2020, 4:53 AM

Dec 19 2019

Krinkle awarded D2483: Gamesetup class rewrite a Love token.
Dec 19 2019, 4:04 AM

Dec 10 2019

Krinkle added a comment to D2459: Play an animation when buildings a researching techs..

Should this be limited to the current player's own researching? Or also their allies? What about enemies?

Dec 10 2019, 2:59 AM

Dec 8 2019

Krinkle added inline comments to D1633: PerlinPainter add to rmgen..
Dec 8 2019, 3:17 AM

Dec 7 2019

Krinkle updated the test plan for D2005: Standardize "Territory Influence" in tooltips.
Dec 7 2019, 10:10 PM
Krinkle updated the summary of D2005: Standardize "Territory Influence" in tooltips.
Dec 7 2019, 10:07 PM
Krinkle updated the Trac tickets for D2452: Linting: Remove "no-lone-blocks" rule for ESLint.
Dec 7 2019, 10:06 PM
Krinkle retitled D2452: Linting: Remove "no-lone-blocks" rule for ESLint from lobby: Fix remaining ESLint warnings to Linting: Remove "no-lone-blocks" rule for ESLint.
Dec 7 2019, 10:05 PM
Krinkle added inline comments to rP23172: Rewrite lobby page to use class semantics, add more gamedetails labels, improve….
Dec 7 2019, 10:05 PM
Krinkle updated the diff for D2452: Linting: Remove "no-lone-blocks" rule for ESLint.
Dec 7 2019, 10:03 PM

Dec 5 2019

Krinkle updated the diff for D2005: Standardize "Territory Influence" in tooltips.

(Rebased.)

Dec 5 2019, 11:53 PM
Krinkle updated the diff for D2279: UnitAI: Fix ESLint coding style warnings.

Rebased to account for other changes in the repos since mid-September.

Dec 5 2019, 11:51 PM
Krinkle added inline comments to rP23172: Rewrite lobby page to use class semantics, add more gamedetails labels, improve….
Dec 5 2019, 11:50 PM
Krinkle created D2452: Linting: Remove "no-lone-blocks" rule for ESLint.
Dec 5 2019, 11:49 PM
Krinkle awarded rP23172: Rewrite lobby page to use class semantics, add more gamedetails labels, improve… a Orange Medal token.
Dec 5 2019, 11:37 PM
Krinkle abandoned D2261: lobby,gamesetup: Fix remaining ESLint warnings.

Superseded by rP23172. Looks like three other issues were introduced there but I will fix those separately so as to not confuse the references to this patch number.

Dec 5 2019, 11:34 PM
Krinkle added inline comments to rP23172: Rewrite lobby page to use class semantics, add more gamedetails labels, improve….
Dec 5 2019, 11:33 PM

Oct 18 2019

Krinkle updated Krinkle.
Oct 18 2019, 9:56 PM

Oct 6 2019

Krinkle added inline comments to D2261: lobby,gamesetup: Fix remaining ESLint warnings.
Oct 6 2019, 1:45 AM
Krinkle added inline comments to D2261: lobby,gamesetup: Fix remaining ESLint warnings.
Oct 6 2019, 1:45 AM

Sep 29 2019

Krinkle updated the diff for D2279: UnitAI: Fix ESLint coding style warnings.

Updated IsAnimal to use stricter !== undefined check instead of bool cast.

Sep 29 2019, 1:35 AM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sep 29 2019, 1:34 AM

Sep 25 2019

Krinkle resigned from rP22881: ptolemy houses, Enrique's pines.
Sep 25 2019, 9:04 PM
Krinkle added inline comments to D284: lobby: Display observer count in gameslist.
Sep 25 2019, 9:01 PM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sep 25 2019, 8:56 PM

Sep 22 2019

Krinkle added inline comments to D2261: lobby,gamesetup: Fix remaining ESLint warnings.
Sep 22 2019, 10:08 PM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sep 22 2019, 10:04 PM
Krinkle raised a concern with rP22881: ptolemy houses, Enrique's pines.

Found during today's test match on r22960.

Sep 22 2019, 12:31 AM

Sep 15 2019

Krinkle awarded D966: Don't show silhouettes through fields and berries a Orange Medal token.
Sep 15 2019, 1:41 AM

Sep 14 2019

Krinkle added inline comments to D284: lobby: Display observer count in gameslist.
Sep 14 2019, 8:13 PM
Krinkle updated the diff for D284: lobby: Display observer count in gameslist.

(Updated translation info to say "human" instead of "non-bot" player.)

Sep 14 2019, 8:07 PM
Krinkle updated the diff for D2279: UnitAI: Fix ESLint coding style warnings.
Sep 14 2019, 7:57 PM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sep 14 2019, 7:57 PM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sep 14 2019, 7:02 PM
Krinkle updated the diff for D2279: UnitAI: Fix ESLint coding style warnings.

Added line breaks in a multi-line conditional.

Sep 14 2019, 6:58 AM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sep 14 2019, 6:57 AM
Krinkle updated the diff for D2279: UnitAI: Fix ESLint coding style warnings.

Removed redundant parenthesis.

Sep 14 2019, 6:49 AM
Krinkle updated the diff for D2005: Standardize "Territory Influence" in tooltips.

Rebased to re-trigger CI which had a false negative it seems.

Sep 14 2019, 5:28 AM

Sep 13 2019

Krinkle updated the diff for D284: lobby: Display observer count in gameslist.
Sep 13 2019, 1:52 AM
Krinkle added inline comments to D284: lobby: Display observer count in gameslist.
Sep 13 2019, 1:50 AM
Krinkle updated the diff for D284: lobby: Display observer count in gameslist.

Addressed concerns raised on previous diff.

Sep 13 2019, 1:50 AM
Krinkle planned changes to D2279: UnitAI: Fix ESLint coding style warnings.
Sep 13 2019, 12:08 AM
Krinkle added inline comments to D2279: UnitAI: Fix ESLint coding style warnings.
Sep 13 2019, 12:08 AM

Sep 10 2019

Krinkle updated the summary of D2279: UnitAI: Fix ESLint coding style warnings.
Sep 10 2019, 3:38 AM
Krinkle created D2279: UnitAI: Fix ESLint coding style warnings.
Sep 10 2019, 3:38 AM

Sep 8 2019

Krinkle added a comment to D2247: [gui] omit unnecessary decimals for resistance tooltip.

Perhaps a "temporary" compromise could be to keep 1 digit only if the number is less than 1? I think as long as it is above 1, players may be more forgiving of rounding errors

Sep 8 2019, 4:42 PM

Sep 7 2019

Krinkle updated the diff for D2261: lobby,gamesetup: Fix remaining ESLint warnings.
Sep 7 2019, 10:38 PM

Sep 6 2019

Krinkle added inline comments to D2240: Move Mainmenu from XML to JS and use object oriented JS.
Sep 6 2019, 2:45 AM

Sep 5 2019

Krinkle updated the test plan for D2261: lobby,gamesetup: Fix remaining ESLint warnings.
Sep 5 2019, 1:17 AM
Krinkle created D2261: lobby,gamesetup: Fix remaining ESLint warnings.
Sep 5 2019, 1:14 AM

Sep 3 2019

Krinkle added inline comments to rP20697: Add helper function to apply arbitrary GUI tags (such as font and color)..
Sep 3 2019, 7:07 PM
Krinkle added inline comments to rP20697: Add helper function to apply arbitrary GUI tags (such as font and color)..
Sep 3 2019, 7:06 PM

Sep 2 2019

Krinkle updated the summary of D284: lobby: Display observer count in gameslist.
Sep 2 2019, 3:18 AM
Krinkle updated the diff for D284: lobby: Display observer count in gameslist.
Sep 2 2019, 2:41 AM
Krinkle added inline comments to D284: lobby: Display observer count in gameslist.
Sep 2 2019, 2:40 AM