Cleanup of Capturable
var => let
periods, caps
JSdocs where useful
don't get the hitpoints twice
Differential D2826
Cleanup of Capturable bb on Jun 20 2020, 11:12 PM. Authored by
Details
Cleanup of Capturable var => let Let the bots run
Diff Detail
Event Timeline
Comment Actions Note that I deliberately avoided the cmpOwnership.GetOwner calls, the need a slightly more subtle care Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Linter detected issues: Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (spaced-comment): | | Expected space or tab after '//' in comment. |----| | /zpool0/trunk/binaries/data/mods/public/simulation/components/Capturable.js | |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Capturable.js | 19| 19| this.cp = []; | 20| 20| }; | 21| 21| | 22| |-//// Interface functions //// | | 22|+// // Interface functions //// | 23| 23| | 24| 24| /** | 25| 25| * Returns the current capture points array. | | [NORMAL] ESLintBear (spaced-comment): | | Expected space or tab after '//' in comment. |----| | /zpool0/trunk/binaries/data/mods/public/simulation/components/Capturable.js | |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Capturable.js | 159| 159| return sourceEnemyCp > 0; | 160| 160| }; | 161| 161| | 162| |-//// Private functions //// | | 162|+// // Private functions //// | 163| 163| | 164| 164| /** | 165| 165| * This has to be called whenever the capture points are changed. | | [NORMAL] ESLintBear (spaced-comment): | | Expected space or tab after '//' in comment. |----| | /zpool0/trunk/binaries/data/mods/public/simulation/components/Capturable.js | |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Capturable.js | 301| 301| this.CheckTimer(); | 302| 302| }; | 303| 303| | 304| |-//// Message Listeners //// | | 304|+// // Message Listeners //// | 305| 305| | 306| 306| Capturable.prototype.OnValueModification = function(msg) | 307| 307| { Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2510/display/redirect
Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (spaced-comment): | | Expected space or tab after '//' in comment. |----| | /zpool0/trunk/binaries/data/mods/public/simulation/components/Capturable.js | |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Capturable.js | 19| 19| this.cp = []; | 20| 20| }; | 21| 21| | 22| |-//// Interface functions //// | | 22|+// // Interface functions //// | 23| 23| | 24| 24| /** | 25| 25| * Returns the current capture points array. | | [NORMAL] ESLintBear (spaced-comment): | | Expected space or tab after '//' in comment. |----| | /zpool0/trunk/binaries/data/mods/public/simulation/components/Capturable.js | |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Capturable.js | 159| 159| return sourceEnemyCp > 0; | 160| 160| }; | 161| 161| | 162| |-//// Private functions //// | | 162|+// // Private functions //// | 163| 163| | 164| 164| /** | 165| 165| * This has to be called whenever the capture points are changed. | | [NORMAL] ESLintBear (spaced-comment): | | Expected space or tab after '//' in comment. |----| | /zpool0/trunk/binaries/data/mods/public/simulation/components/Capturable.js | |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Capturable.js | 301| 301| this.CheckTimer(); | 302| 302| }; | 303| 303| | 304| |-//// Message Listeners //// | | 304|+// // Message Listeners //// | 305| 305| | 306| 306| Capturable.prototype.OnValueModification = function(msg) | 307| 307| { Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2742/display/redirect |