This should not affect any users of the MT_EntityRenamed, as all of them currently use OnGlobalEntityRenamed.
Details
Details
- Reviewers
elexis mimo - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP20038: Change some occurrences of BroadcastMessage where an entity id is available to…
Verify the game still works correctly when entities are renamed.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- selections
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 2590 Build 4379: Vulcan Build Jenkins Build 4378: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1729/ for more details.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1734/ for more details.
Comment Actions
Did you search for things like OnGlobalEntityRenamed? Sometimes it's not only one entity that needs an update.
Comment Actions
Yes, I did: all places where this message is subscribed to use OnGlobalEntityRenamed, so this shouldn't change any behavior.
Comment Actions
Code looks good, and tested on a 4 AIs replay that it does not change the hash value.