Details
Details
Check that the tests run
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Test succeeds.
A testcase where one can train templates of two different civs might catch some edge case if one wants to add more coverage.
binaries/data/mods/public/simulation/components/tests/test_ProductionQueue.js | ||
---|---|---|
16 ↗ | (On Diff #4633) | classic |
21 ↗ | (On Diff #4633) | (I meant one template per line, so that all start with units/ at the same location) |
78 ↗ | (On Diff #4633) | I guess one of the reviewers could have been more skeptical |
118 ↗ | (On Diff #4633) | foo( bar, [x1, x2]); or foo( bar [ x1, x2 ]); or |
131 ↗ | (On Diff #4633) | (Someone could have used arrays or Sets when introducing the thing) |