Reported by pilino1234 on Transifex.
Details
- Reviewers
bb - Commits
- rP22122: Rephrase the description of the wonder victory condition
Only affect a user-visible string.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 6303 Build 10458: Vulcan Build
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/614/display/redirect
binaries/data/mods/public/simulation/data/settings/victory_conditions/wonder.json | ||
---|---|---|
6 | hmm, grammer i guess, in the proposed string, owners is plural right? while there is only 1 owner of a wonder |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/640/display/redirect
Perhaps "allied victory mode"? (At least the phrasing in our code, gamemode used to be synonymous with victory condition.)
The current wonder victory behavior to reset the timer if someone of that team is defeated or changed the alliance.
That behavior is currently marked as contested in rP21441 and might be changed.
If the previous alliance and defeat conditions (excluding the originally reported bug) were restored, the sentence would be deleted.
(Otherwise the string should be improved to also contain the information that the timer is reset upon defeat.)