Water height at the slider will be updated after the tool was disabled. Because currently we don't any way to notify EnvironmentSettings about engine changes.
Details
Details
- Reviewers
trompetin17 - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Owners Package (Owns No Changed Paths) - Commits
- rP22445: Adds an tool to pick water high by terrain click in Atlas.
- Apply the patch and compile the game
- Run Atlas
- Make sure that the tool works
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 8186 Build 13336: Vulcan Build Jenkins
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Environment/Environment.h | 1| /*·Copyright·(C)·2009·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2009" source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Environment/Environment.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/tools/atlas/GameInterface/Messages.h | 211| » » ); | | [MAJOR] CPPCheckBear (syntaxError): | | Invalid number of character '{' when these macros are defined: 'MESSAGESSETUP_NOTFIRST'. source/tools/atlas/GameInterface/Handlers/EnvironmentHandlers.cpp | 1| /*·Copyright·(C)·2016·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2016" source/tools/atlas/GameInterface/Handlers/EnvironmentHandlers.cpp | 211| » » m_OldWaterHeight·=·cmpWaterManager->GetWaterLevel( | | [MAJOR] CPPCheckBear (syntaxError): | | Invalid number of character '{' when these macros are defined: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/differential/1895/display/redirect
Comment Actions
Tested on OSX Mojave
- Select PickWaterHeight click in a different position
- Toggle PickWaterHeight, Slider Water Height Updated
- Select PickWaterHeight and move slider Water Height
nothing was broken form my test
ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Environment/Environment.cpp | ||
---|---|---|
296 ↗ | (On Diff #8795) | This line is missing a WXUNUSED macro, causes a build warning on gcc: Environment.cpp ../../../source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Environment/Environment.cpp: In member function ‘void EnvironmentSidebar::OnPickWaterHeight(wxCommandEvent&)’: ../../../source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Environment/Environment.cpp:296:60: warning: unused parameter ‘evt’ [-Wunused-parameter] void EnvironmentSidebar::OnPickWaterHeight(wxCommandEvent& evt) |