HomeWildfire Games
Diffusion 0 A.D. Public Repository rP22445

Adds an tool to pick water high by terrain click in Atlas.
rP22445
Actions

Description

Adds an tool to pick water high by terrain click in Atlas.

Reviewed By: trompetin17
Differential Revision: https://code.wildfiregames.com/D2037

Details

Committed
vladislavbelovJul 9 2019, 8:16 PM
Reviewer
trompetin17
Differential Revision
D2037: [ATLAS] Adds a tool to pick water high by terrain click
Parents
rP22444: [Windows] Automated build.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 8262
Build 13475: Trigger Windows Autobuild
Build 13474: Post-Commit BuildJenkins

Event Timeline

vladislavbelov committed rP22445: Adds an tool to pick water high by terrain click in Atlas..Jul 9 2019, 8:16 PM
Harbormaster completed building B8262: rP22445: Adds an tool to pick water high by terrain click in Atlas..Jul 9 2019, 8:34 PM
Stan added a subscriber: Stan.Jul 18 2019, 2:43 PM
Stan added inline comments.
/ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Environment/Environment.cpp
296

Missing WXUNUSED(evt).

warning C4100: 'evt': unreferenced formal parameter

elexis raised a concern with this commit.Jul 19 2019, 2:50 PM
elexis added a subscriber: elexis.

gcc9 picks it up as well.

This commit now has outstanding concerns.Jul 19 2019, 2:50 PM
vladislavbelov mentioned this in rP22548: Fixes compiler warning about unused variable introduced in rP22445..Jul 25 2019, 1:25 AM
elexis removed an auditor: elexis.Jul 25 2019, 1:28 AM

Thanks

This commit no longer requires audit.Jul 25 2019, 1:28 AM

Changes (5)

PathSize
ps/
trunk/
source/
tools/
atlas/
AtlasUI/
ScenarioEditor/
Sections/
Environment/
Tools/
GameInterface/
Handlers/

rP22445

View Options

ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Environment/Environment.cpp

Loading...
View Options

ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Environment/Environment.h

Loading...
View Options

ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/Tools/PickWaterHeight.cpp

Loading...
View Options

ps/trunk/source/tools/atlas/GameInterface/Handlers/EnvironmentHandlers.cpp

Loading...
View Options

ps/trunk/source/tools/atlas/GameInterface/Messages.h

Loading...
Wildfire Games ยท Phabricator