Page MenuHomeWildfire Games
Differential D2228

correct Greek specific names of structures
ClosedPublic
Actions

Authored by Nescio on Aug 25 2019, 9:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 13, 3:38 PM
Unknown Object (File)
Tue, Sep 10, 10:19 PM
Unknown Object (File)
Tue, Sep 10, 3:36 AM
Unknown Object (File)
Mon, Sep 9, 7:39 PM
Unknown Object (File)
Mon, Sep 9, 4:40 AM
Unknown Object (File)
Sun, Sep 8, 5:20 AM
Unknown Object (File)
Sat, Sep 7, 12:05 PM
Unknown Object (File)
Tue, Sep 3, 5:19 PM
View All 17 Files
Subscribers
Itms
Restricted Owners Package

Details

Reviewers
Stan
Commits
rP23244: Correct Greek specific names of structures.
Summary

This patch corrects the structure specific names for the Greek factions (athen, mace, ptol, sele, spart), as discussed with @Anaxandridas ho Skandiates at https://wildfiregames.com/forum/index.php?/topic/25268-specific-name-review-structures/
Related: D1750 (kush), D1757 (brit, gaul), D1935 (pers), D1999 (rome), D2025 (technologies).

Test Plan

Check for mistakes and omissions.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9086
Build 14887: Vulcan BuildJenkins
Build 14886: arc lint + arc unit

Event Timeline

Nescio created this revision.Aug 25 2019, 9:20 PM
Vulcan added a comment.Aug 25 2019, 9:24 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/495/display/redirect

Harbormaster completed remote builds in B9086: Diff 9515.Aug 25 2019, 9:24 PM
Stan added a comment.Dec 16 2019, 9:46 AM

Nescio aren't we missing some now for Amphiteaters, sorry I totally forgot about this patch :/

Nescio added a comment.Dec 16 2019, 11:44 AM

Amphitheatres are Italic or Roman, not Greek.

Nescio updated this revision to Diff 10614.Dec 16 2019, 12:17 PM

rebased

Stan requested changes to this revision.Dec 16 2019, 12:18 PM

Can you rebase the patch? Sorry for the inconvenience...

This revision now requires changes to proceed.Dec 16 2019, 12:18 PM
Stan accepted this revision.Dec 16 2019, 12:19 PM

Lol too slow XD

This revision is now accepted and ready to land.Dec 16 2019, 12:19 PM
This revision was landed with ongoing or failed builds.Dec 16 2019, 12:30 PM
Closed by commit rP23244: Correct Greek specific names of structures. (authored by Stan). · Explain Why
This revision was automatically updated to reflect the committed changes.
Stan added a commit: rP23244: Correct Greek specific names of structures..
Owners added a subscriber: Restricted Owners Package.Dec 16 2019, 12:30 PM
Nescio added a comment.Dec 16 2019, 12:35 PM

D2155 and D2157 are also correcting some specific names.

Nescio added a comment.Dec 16 2019, 12:51 PM

And D2025.

Vulcan added a comment.Dec 16 2019, 1:01 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/773/display/redirect

Vulcan added a comment.Dec 16 2019, 1:09 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1289/display/redirect

Harbormaster completed remote builds in B10331: Diff 10614.Dec 16 2019, 1:09 PM

Large Diff

This large diff affects 144 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
simulation/
templates/
structures/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
3 lines
2 lines
1 line
2 lines
1 line
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
1 line
1 line
1 line
1 line
1 line
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
3 lines
1 line
2 lines
1 line
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
4 lines
2 lines
1 line
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
1 line
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
1 line
1 line
2 lines
2 lines
1 line
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
1 line
1 line
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
3 lines
2 lines
2 lines
1 line
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines

Diff 9515

View Options

binaries/data/mods/public/simulation/templates/structures/athen_barracks.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_blacksmith.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_civil_centre.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_corral.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_defense_tower.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_dock.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_farmstead.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_field.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_fortress.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_gymnasion.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_house.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_market.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_outpost.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_prytaneion.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_range.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_royal_stoa.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_sentry_tower.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_stable.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_storehouse.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_temple.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_theatron.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_wall_gate.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_wall_long.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_wall_medium.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_wall_short.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_wall_tower.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_wallset_stone.xml

View Options

binaries/data/mods/public/simulation/templates/structures/athen_wonder.xml

View Options

binaries/data/mods/public/simulation/templates/structures/cart_elephant_stables.xml

View Options

binaries/data/mods/public/simulation/templates/structures/cart_embassy.xml

View Options

binaries/data/mods/public/simulation/templates/structures/cart_fortress.xml

View Options

binaries/data/mods/public/simulation/templates/structures/cart_outpost.xml

View Options

binaries/data/mods/public/simulation/templates/structures/iber_outpost.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_barracks.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_blacksmith.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_civil_centre.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_corral.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_defense_tower.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_dock.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_farmstead.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_field.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_fortress.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_house.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_library.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_market.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_outpost.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_range.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_royal_stoa.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_sentry_tower.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_stable.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_storehouse.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_temple.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_theatron.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_wall_gate.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_wall_long.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_wall_medium.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_wall_short.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_wall_tower.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_wallset_stone.xml

View Options

binaries/data/mods/public/simulation/templates/structures/mace_wonder.xml

View Options

binaries/data/mods/public/simulation/templates/structures/merc_camp_egyptian.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_barracks.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_blacksmith.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_civil_centre.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_corral.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_defense_tower.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_dock.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_elephant_stables.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_farmstead.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_field.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_fortress.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_house.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_library.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_lighthouse.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_market.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_mercenary_camp.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_military_colony.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_outpost.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_range.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_sentry_tower.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_stable.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_storehouse.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_temple.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_wall_gate.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_wall_long.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_wall_medium.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_wall_short.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_wall_tower.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_wallset_stone.xml

View Options

binaries/data/mods/public/simulation/templates/structures/ptol_wonder.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_barracks.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_blacksmith.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_civil_centre.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_corral.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_defense_tower.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_dock.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_elephant_stables.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_farmstead.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_field.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_house.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_library.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_market.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_military_colony.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_outpost.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_range.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_sentry_tower.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_stable.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_storehouse.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_temple.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_wall_gate.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_wall_long.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_wall_medium.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_wall_short.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_wall_tower.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_wallset_stone.xml

View Options

binaries/data/mods/public/simulation/templates/structures/sele_wonder.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_barracks.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_blacksmith.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_civil_centre.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_corral.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_defense_tower.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_dock.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_farmstead.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_field.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_fortress.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_gerousia.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_house.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_market.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_outpost.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_range.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_royal_stoa.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_sentry_tower.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_stable.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_storehouse.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_syssiton.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_temple.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_theatron.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_wall_gate.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_wall_long.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_wall_medium.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_wall_short.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_wall_tower.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_wallset_stone.xml

View Options

binaries/data/mods/public/simulation/templates/structures/spart_wonder.xml

Wildfire Games · Phabricator