Differential D2307

improve default.cfg comments
Needs ReviewPublic
Actions

Authored by Nescio on Sep 19 2019, 9:00 PM.

Tags

None

Subscribers

Tokens

"Like" token, awarded by elexis.

Details

Reviewers

Summary

See discussion with @elexis in D2305.

[EDIT]: End sentences with a full stop.

Test Plan

Check for mistakes and omissions.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 9535
Build 15928: Vulcan Build	Jenkins
Build 15927: Vulcan Build (Windows)	Jenkins
Build 15926: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	0 ms	Jenkins > TestGuiManager::test_hotkeysState Error: Expected (hotkey_pressed_value == true), found (false != true) Error: Expected (hotkey_pressed_value == true), found (false != true)
	0 ms	Jenkins > TestAllocators::test_da
	0 ms	Jenkins > TestAllocators::test_da
	0 ms	Jenkins > TestAllocators::test_da
	0 ms	Jenkins > TestAtlasObjectXML::test_parse_attributes1
		View Full Test Results (1 Failed · 968 Passed)

Event Timeline

Nescio created this revision.Sep 19 2019, 9:00 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/766/display/redirect

Harbormaster failed remote builds in B9484: Diff 9869!Sep 19 2019, 9:02 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/254/display/redirect

elexis awarded a token.Sep 20 2019, 1:25 PM

Nescio mentioned this in D2309: Fix missing tooltip function in replay menu following loadgame and savegame unification rP22923 / D2290.Sep 21 2019, 9:24 AM

Nescio mentioned this in D2305: more gui/manual/intro.txt improvements.Sep 21 2019, 9:36 AM

"or replay"

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/277/display/redirect

Harbormaster failed remote builds in B9535: Diff 9902!Sep 22 2019, 9:52 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/789/display/redirect

Do we want periods after comments?

End sentences with a full stop.

binaries/data/config/default.cfg
489	Ugly American spelling.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/291/display/redirect

Nescio updated this revision to Diff 9924.Sep 22 2019, 9:30 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/292/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/806/display/redirect

Harbormaster completed remote builds in B9558: Diff 9923.Sep 22 2019, 9:31 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/807/display/redirect

Harbormaster completed remote builds in B9559: Diff 9924.Sep 22 2019, 9:34 PM

Revision Contents
Changeset List

Path

Size

binaries/

data/

config/

62 lines

Diff 9902

binaries/data/config/default.cfg

Loading...