Page MenuHomeWildfire Games

Vantha ( )
User

Projects

User Details

User Since
Mar 30 2024, 10:25 PM (4 w, 2 d)

Recent Activity

Sun, Apr 28

Vantha updated the diff for D5256: Remove Roman numerals from bot names.
Sun, Apr 28, 8:14 PM

Fri, Apr 26

Vantha added inline comments to D5256: Remove Roman numerals from bot names.
Fri, Apr 26, 9:16 AM
Vantha updated the diff for D5256: Remove Roman numerals from bot names.
Fri, Apr 26, 9:16 AM

Wed, Apr 24

Vantha added inline comments to D5256: Remove Roman numerals from bot names.
Wed, Apr 24, 9:14 PM
Vantha updated the diff for D5256: Remove Roman numerals from bot names.

I addressed most of the suggestions.

Wed, Apr 24, 9:13 PM
Vantha updated the diff for D5256: Remove Roman numerals from bot names.

Ok, updated the diff. Is this how you wanted the comments?

Wed, Apr 24, 3:29 PM

Tue, Apr 23

Vantha updated the diff for D5256: Remove Roman numerals from bot names.

Like this?

Tue, Apr 23, 8:30 PM
Vantha updated the diff for D5256: Remove Roman numerals from bot names.

I added/updated the comments. Do you also want a comment before line 95? This.CountLabel is already marked for translation at this point (and has a comment explaining what it is).

Tue, Apr 23, 12:20 PM

Sun, Apr 21

Vantha updated the diff for D5256: Remove Roman numerals from bot names.

Ok, nice. Made the change and added the trac ticket.

Sun, Apr 21, 12:11 AM

Sat, Apr 20

Vantha added inline comments to D5256: Remove Roman numerals from bot names.
Sat, Apr 20, 12:02 AM
Vantha updated the diff for D5256: Remove Roman numerals from bot names.

Ok, I made the change.

Sat, Apr 20, 12:01 AM

Fri, Apr 19

Vantha added a comment to D5256: Remove Roman numerals from bot names.

OK, and what's preferred?

Fri, Apr 19, 5:34 PM

Thu, Apr 18

Vantha added a comment to D5256: Remove Roman numerals from bot names.

Before this diff the "forat translation" is allways done. That's almost certainly an issue.

Not sure what you mean by this, though. What should I change?

Thu, Apr 18, 6:51 PM
Vantha updated the diff for D5256: Remove Roman numerals from bot names.
Thu, Apr 18, 6:49 PM
Vantha added a comment to D5256: Remove Roman numerals from bot names.

I don't like it when data is mutated. (With the +=)
If one wants to know what's in the variable one has to reason about every point where it get's mutated.
If it's const one only has to reason abot the initialization.
Ideally there should be a chosenName and a translatedChosenName:

const translatedChosenName = this.settings.isNetworked ? chosenName : translate(chosenName);

elexis just wrote me again :)
User visible strings shouldn't be concatinated by + (or +=).

Thu, Apr 18, 3:01 PM
Vantha updated the diff for D5256: Remove Roman numerals from bot names.
Thu, Apr 18, 2:38 PM

Wed, Apr 17

Vantha added inline comments to D5256: Remove Roman numerals from bot names.
Wed, Apr 17, 8:22 PM
Vantha added a comment to D5256: Remove Roman numerals from bot names.

I never saw Template Literals in this codepase. I don't object it. :)

Wed, Apr 17, 8:19 PM
Vantha updated the diff for D5256: Remove Roman numerals from bot names.
Wed, Apr 17, 8:03 PM

Mon, Apr 8

Vantha updated the diff for D5256: Remove Roman numerals from bot names.

The Mauryan emperors were sorted chronologically. I put them in alphabetical order too.

Mon, Apr 8, 6:22 PM
Vantha added a comment to D5256: Remove Roman numerals from bot names.

When the AINames are empty or don't exist, the game already throws errors before the step of choosing the names.

Mon, Apr 8, 1:37 PM
Vantha updated the diff for D5256: Remove Roman numerals from bot names.

changing three let to const

Mon, Apr 8, 1:30 PM

Sun, Apr 7

Vantha requested review of D5256: Remove Roman numerals from bot names.
Sun, Apr 7, 3:29 PM