Page MenuHomeWildfire Games
Differential D4996

Disable all logging of network messages in release mode
AbandonedPublic
Actions

Authored by Stan on May 11 2023, 11:32 AM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Trac Tickets
#6794
Summary

People have recently (re)discovered that they can read everything that happens in the game from the logs.

More elaborate mods can reveal more information, but this is ground level 0 of cheating.

Test Plan

Find a better solution. Anyone can make a js mod and reactivate the chat logging

Diff Detail

Event Timeline

Stan created this revision.May 11 2023, 11:32 AM
Vulcan added a comment.May 11 2023, 11:40 AM

Successful build - Chance fights ever on the side of the prudent.

Debug:
     9>e:\jenkins\workspace\vs2015-differential\source\network\nethost.cpp(40): warning C4002: too many arguments for function-like macro invocation 'LOGNETWORKMESSAGE' [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\network.vcxproj]
     9>e:\jenkins\workspace\vs2015-differential\source\network\nethost.cpp(34): warning C4100: 'peerName': unreferenced formal parameter [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\network.vcxproj]
     9>e:\jenkins\workspace\vs2015-differential\source\network\netclient.cpp(311): warning C4002: too many arguments for function-like macro invocation 'LOGNETWORKMESSAGE' [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\network.vcxproj]
     9>e:\jenkins\workspace\vs2015-differential\source\network\netserver.cpp(297): warning C4002: too many arguments for function-like macro invocation 'LOGNETWORKMESSAGE' [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\network.vcxproj]
     9>e:\jenkins\workspace\vs2015-differential\source\network\netsession.cpp(144): warning C4002: too many arguments for function-like macro invocation 'LOGNETWORKMESSAGE' [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\network.vcxproj]
Release:
     7>e:\jenkins\workspace\vs2015-differential\source\network\nethost.cpp(40): warning C4002: too many arguments for function-like macro invocation 'LOGNETWORKMESSAGE' [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\network.vcxproj]
     7>e:\jenkins\workspace\vs2015-differential\source\network\nethost.cpp(34): warning C4100: 'peerName': unreferenced formal parameter [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\network.vcxproj]
     7>e:\jenkins\workspace\vs2015-differential\source\network\netclient.cpp(311): warning C4002: too many arguments for function-like macro invocation 'LOGNETWORKMESSAGE' [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\network.vcxproj]
     7>e:\jenkins\workspace\vs2015-differential\source\network\netserver.cpp(297): warning C4002: too many arguments for function-like macro invocation 'LOGNETWORKMESSAGE' [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\network.vcxproj]
     7>e:\jenkins\workspace\vs2015-differential\source\network\netserver.cpp(297): warning C4390: ';': empty controlled statement found; is this the intent? [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\network.vcxproj]
     7>e:\jenkins\workspace\vs2015-differential\source\network\netsession.cpp(144): warning C4002: too many arguments for function-like macro invocation 'LOGNETWORKMESSAGE' [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\network.vcxproj]

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8052/display/redirect

Vulcan added a comment.May 11 2023, 11:47 AM

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-gcc7.txt
../../../source/network/NetClient.cpp:46:5: warning: "NDEBUG" is not defined, evaluates to 0 [-Wundef]
 #if NDEBUG
     ^~~~~~
../../../source/network/NetClient.cpp:311:93: error: macro "LOGNETWORKMESSAGE" passed 3 arguments, but takes just 1
  LOGNETWORKMESSAGE("NetClient: connecting to server at %s:%i", m_ServerAddress, m_ServerPort);
                                                                                             ^
../../../source/network/NetClient.cpp:573:116: error: macro "LOGNETWORKMESSAGERENDER" passed 2 arguments, but takes just 1
   LOGNETWORKMESSAGERENDER("Serializing game at turn %u for rejoining player", m_ClientTurnManager->GetCurrentTurn());
                                                                                                                    ^
../../../source/network/NetClient.cpp:613:78: error: macro "LOGNETWORKMESSAGE" passed 2 arguments, but takes just 1
   LOGNETWORKMESSAGE("Rejoining client deserializing state at turn %u\n", turn);
                                                                              ^
../../../source/network/NetClient.cpp:719:119: error: macro "LOGNETWORKMESSAGE" passed 3 arguments, but takes just 1
  LOGNETWORKMESSAGE("Net: Authentication result: host=%u, %s", message->m_HostID, utf8_from_wstring(message->m_Message));
                                                                                                                       ^
../../../source/network/NetClient.cpp: In member function 'bool CNetClient::TryToConnect(const CStr8&, bool)':
../../../source/network/NetClient.cpp:311:2: error: 'LOGNETWORKMESSAGE' was not declared in this scope
  LOGNETWORKMESSAGE("NetClient: connecting to server at %s:%i", m_ServerAddress, m_ServerPort);
  ^~~~~~~~~~~~~~~~~
../../../source/network/NetClient.cpp: In member function 'bool CNetClient::HandleMessage(CNetMessage*)':
../../../source/network/NetClient.cpp:573:3: error: 'LOGNETWORKMESSAGERENDER' was not declared in this scope
   LOGNETWORKMESSAGERENDER("Serializing game at turn %u for rejoining player", m_ClientTurnManager->GetCurrentTurn());
   ^~~~~~~~~~~~~~~~~~~~~~~
../../../source/network/NetClient.cpp: In member function 'void CNetClient::LoadFinished()':
../../../source/network/NetClient.cpp:613:3: error: 'LOGNETWORKMESSAGE' was not declared in this scope
   LOGNETWORKMESSAGE("Rejoining client deserializing state at turn %u\n", turn);
   ^~~~~~~~~~~~~~~~~
../../../source/network/NetClient.cpp: In static member function 'static bool CNetClient::OnAuthenticate(void*, CFsmEvent*)':
../../../source/network/NetClient.cpp:719:2: error: 'LOGNETWORKMESSAGE' was not declared in this scope
  LOGNETWORKMESSAGE("Net: Authentication result: host=%u, %s", message->m_HostID, utf8_from_wstring(message->m_Message));
  ^~~~~~~~~~~~~~~~~
make[1]: *** [network.make:149: obj/network_Debug/NetClient.o] Error 1
make: *** [Makefile:79: network] Error 2

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/8638/display/redirect

Harbormaster completed remote builds in B21867: Diff 21786.May 11 2023, 12:20 PM
Vulcan added a comment.May 11 2023, 12:20 PM

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
../../../source/network/NetHost.cpp:26:5: warning: 'NDEBUG' is not defined, evaluates to 0 [-Wundef]
#if NDEBUG
    ^
../../../source/network/NetHost.cpp:40:65: error: too many arguments provided to function-like macro invocation
        LOGNETWORKMESSAGE("Net: Sending message %s of size %lu to %s", message->ToString().c_str(), (unsigned long)packet->dataLength, peerName);
                                                                       ^
../../../source/network/NetHost.cpp:30:9: note: macro 'LOGNETWORKMESSAGE' defined here
#define LOGNETWORKMESSAGE(msg) LOGMESSAGE(msg)
        ^
../../../source/network/NetHost.cpp:40:2: error: use of undeclared identifier 'LOGNETWORKMESSAGE'
        LOGNETWORKMESSAGE("Net: Sending message %s of size %lu to %s", message->ToString().c_str(), (unsigned long)packet->dataLength, peerName);
        ^
../../../source/network/NetHost.cpp:34:84: warning: unused parameter 'peerName' [-Wunused-parameter]
bool CNetHost::SendMessage(const CNetMessage* message, ENetPeer* peer, const char* peerName)
                                                                                   ^
2 warnings and 2 errors generated.
make[1]: *** [obj/network_Debug/NetHost.o] Error 1
make[1]: *** Waiting for unfinished jobs....
../../../source/network/NetSession.cpp:30:5: warning: 'NDEBUG' is not defined, evaluates to 0 [-Wundef]
#if NDEBUG
    ^
../../../source/network/NetServer.cpp:53:5: warning: 'NDEBUG' is not defined, evaluates to 0 [-Wundef]
#if NDEBUG
    ^
../../../source/network/NetSession.cpp:144:55: error: too many arguments provided to function-like macro invocation
                LOGNETWORKMESSAGE("Net client: Connected to %s:%u", hostname, (unsigned int)event.peer->address.port);
                                                                    ^
../../../source/network/NetSession.cpp:34:9: note: macro 'LOGNETWORKMESSAGE' defined here
#define LOGNETWORKMESSAGE(msg) LOGMESSAGE(msg)
        ^
../../../source/network/NetSession.cpp:144:3: error: use of undeclared identifier 'LOGNETWORKMESSAGE'
                LOGNETWORKMESSAGE("Net client: Connected to %s:%u", hostname, (unsigned int)event.peer->address.port);
                ^
../../../source/network/NetSession.cpp:197:82: error: too many arguments provided to function-like macro invocation
                                LOGNETWORKMESSAGE("Net client: Received message %s of size %lu from server", msg->ToString().c_str(), (unsigned long)msg->GetSerializedLength());
                                                                                                             ^
../../../source/network/NetSession.cpp:34:9: note: macro 'LOGNETWORKMESSAGE' defined here
#define LOGNETWORKMESSAGE(msg) LOGMESSAGE(msg)
        ^
../../../source/network/NetSession.cpp:197:5: error: use of undeclared identifier 'LOGNETWORKMESSAGE'
                                LOGNETWORKMESSAGE("Net client: Received message %s of size %lu from server", msg->ToString().c_str(), (unsigned long)msg->GetSerializedLength());
                                ^
1 warning and 4 errors generated.
make[1]: *** [obj/network_Debug/NetSession.o] Error 1
../../../source/network/NetServer.cpp:297:85: error: too many arguments provided to function-like macro invocation
                LOGNETWORKMESSAGE("Net server: attempting to use cached root descriptor URL: %s", rootDescURL.c_str());
                                                                                                  ^
../../../source/network/NetServer.cpp:57:9: note: macro 'LOGNETWORKMESSAGE' defined here
#define LOGNETWORKMESSAGE(msg) LOGMESSAGE(msg)
        ^
../../../source/network/NetServer.cpp:297:3: error: use of undeclared identifier 'LOGNETWORKMESSAGE'
                LOGNETWORKMESSAGE("Net server: attempting to use cached root descriptor URL: %s", rootDescURL.c_str());
                ^
../../../source/network/NetServer.cpp:304:58: error: too many arguments provided to function-like macro invocation
                LOGNETWORKMESSAGE("Net server: using cached IGD = %s", urls.controlURL);
                                                                       ^
../../../source/network/NetServer.cpp:57:9: note: macro 'LOGNETWORKMESSAGE' defined here
#define LOGNETWORKMESSAGE(msg) LOGMESSAGE(msg)
        ^
../../../source/network/NetServer.cpp:304:3: error: use of undeclared identifier 'LOGNETWORKMESSAGE'
                LOGNETWORKMESSAGE("Net server: using cached IGD = %s", urls.controlURL);
                ^
../../../source/network/NetServer.cpp:330:57: error: too many arguments provided to function-like macro invocation
                LOGNETWORKMESSAGE("Net server: found valid IGD = %s", urls.controlURL);
                                                                      ^
../../../source/network/NetServer.cpp:57:9: note: macro 'LOGNETWORKMESSAGE' defined here
#define LOGNETWORKMESSAGE(msg) LOGMESSAGE(msg)
        ^
../../../source/network/NetServer.cpp:330:3: error: use of undeclared identifier 'LOGNETWORKMESSAGE'
                LOGNETWORKMESSAGE("Net server: found valid IGD = %s", urls.controlURL);
                ^
../../../source/network/NetServer.cpp:333:103: error: too many arguments provided to function-like macro invocation
                LOGNETWORKMESSAGE("Net server: found a valid, not connected IGD = %s, will try to continue anyway", urls.controlURL);
                                                                                                                    ^
../../../source/network/NetServer.cpp:57:9: note: macro 'LOGNETWORKMESSAGE' defined here
#define LOGNETWORKMESSAGE(msg) LOGMESSAGE(msg)
        ^
../../../source/network/NetServer.cpp:333:3: error: use of undeclared identifier 'LOGNETWORKMESSAGE'
                LOGNETWORKMESSAGE("Net server: found a valid, not connected IGD = %s, will try to continue anyway", urls.controlURL);
                ^
../../../source/network/NetServer.cpp:336:110: error: too many arguments provided to function-like macro invocation
                LOGNETWORKMESSAGE("Net server: found a UPnP device unrecognized as IGD = %s, will try to continue anyway", urls.controlURL);
                                                                                                                           ^
../../../source/network/NetServer.cpp:57:9: note: macro 'LOGNETWORKMESSAGE' defined here
#define LOGNETWORKMESSAGE(msg) LOGMESSAGE(msg)
        ^
../../../source/network/NetServer.cpp:336:3: error: use of undeclared identifier 'LOGNETWORKMESSAGE'
                LOGNETWORKMESSAGE("Net server: found a UPnP device unrecognized as IGD = %s, will try to continue anyway", urls.controlURL);
                ^
../../../source/network/NetServer.cpp:346:82: error: too many arguments provided to function-like macro invocation
                LOGNETWORKMESSAGE("Net server: GetExternalIPAddress failed with code %d (%s)", ret, strupnperror(ret));
                                                                                               ^
../../../source/network/NetServer.cpp:57:9: note: macro 'LOGNETWORKMESSAGE' defined here
#define LOGNETWORKMESSAGE(msg) LOGMESSAGE(msg)
        ^
../../../source/network/NetServer.cpp:346:3: error: use of undeclared identifier 'LOGNETWORKMESSAGE'
                LOGNETWORKMESSAGE("Net server: GetExternalIPAddress failed with code %d (%s)", ret, strupnperror(ret));
                ^
../../../source/network/NetServer.cpp:350:58: error: too many arguments provided to function-like macro invocation
        LOGNETWORKMESSAGE("Net server: ExternalIPAddress = %s", externalIPAddress);
                                                                ^
../../../source/network/NetServer.cpp:57:9: note: macro 'LOGNETWORKMESSAGE' defined here
#define LOGNETWORKMESSAGE(msg) LOGMESSAGE(msg)
        ^
../../../source/network/NetServer.cpp:350:2: error: use of undeclared identifier 'LOGNETWORKMESSAGE'
        LOGNETWORKMESSAGE("Net server: ExternalIPAddress = %s", externalIPAddress);
        ^
../../../source/network/NetServer.cpp:358:7: error: too many arguments provided to function-like macro invocation
                           psPort, psPort, internalIPAddress, ret, strupnperror(ret));
                           ^
../../../source/network/NetServer.cpp:57:9: note: macro 'LOGNETWORKMESSAGE' defined here
#define LOGNETWORKMESSAGE(msg) LOGMESSAGE(msg)
        ^
../../../source/network/NetServer.cpp:357:3: error: use of undeclared identifier 'LOGNETWORKMESSAGE'
                LOGNETWORKMESSAGE("Net server: AddPortMapping(%s, %s, %s) failed with code %d (%s)",
                ^
../../../source/network/NetServer.cpp:375:91: error: too many arguments provided to function-like macro invocation
                LOGNETWORKMESSAGE("Net server: GetSpecificPortMappingEntry() failed with code %d (%s)", ret, strupnperror(ret));
                                                                                                        ^
../../../source/network/NetServer.cpp:57:9: note: macro 'LOGNETWORKMESSAGE' defined here
#define LOGNETWORKMESSAGE(msg) LOGMESSAGE(msg)
        ^
../../../source/network/NetServer.cpp:375:3: error: use of undeclared identifier 'LOGNETWORKMESSAGE'
                LOGNETWORKMESSAGE("Net server: GetSpecificPortMappingEntry() failed with code %d (%s)", ret, strupnperror(ret));
                ^
../../../source/network/NetServer.cpp:381:8: error: too many arguments provided to function-like macro invocation
                                   externalIPAddress, psPort, protocall, intClient, intPort, duration);
                                   ^
../../../source/network/NetServer.cpp:57:9: note: macro 'LOGNETWORKMESSAGE' defined here
#define LOGNETWORKMESSAGE(msg) LOGMESSAGE(msg)
        ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
1 warning and 20 errors generated.
make[1]: *** [obj/network_Debug/NetServer.o] Error 1
../../../source/network/NetClient.cpp:46:5: warning: 'NDEBUG' is not defined, evaluates to 0 [-Wundef]
#if NDEBUG
    ^
../../../source/network/NetClient.cpp:311:64: error: too many arguments provided to function-like macro invocation
        LOGNETWORKMESSAGE("NetClient: connecting to server at %s:%i", m_ServerAddress, m_ServerPort);
                                                                      ^
../../../source/network/NetClient.cpp:50:9: note: macro 'LOGNETWORKMESSAGE' defined here
#define LOGNETWORKMESSAGE(msg) LOGMESSAGE(msg)
        ^
../../../source/network/NetClient.cpp:311:2: error: use of undeclared identifier 'LOGNETWORKMESSAGE'
        LOGNETWORKMESSAGE("NetClient: connecting to server at %s:%i", m_ServerAddress, m_ServerPort);
        ^
../../../source/network/NetClient.cpp:573:79: error: too many arguments provided to function-like macro invocation
                LOGNETWORKMESSAGERENDER("Serializing game at turn %u for rejoining player", m_ClientTurnManager->GetCurrentTurn());
                                                                                            ^
../../../source/network/NetClient.cpp:51:9: note: macro 'LOGNETWORKMESSAGERENDER' defined here
#define LOGNETWORKMESSAGERENDER(msg) LOGMESSAGERENDER(msg)
        ^
../../../source/network/NetClient.cpp:573:3: error: use of undeclared identifier 'LOGNETWORKMESSAGERENDER'
                LOGNETWORKMESSAGERENDER("Serializing game at turn %u for rejoining player", m_ClientTurnManager->GetCurrentTurn());
                ^
../../../source/network/NetClient.cpp:613:74: error: too many arguments provided to function-like macro invocation
                LOGNETWORKMESSAGE("Rejoining client deserializing state at turn %u\n", turn);
                                                                                       ^
../../../source/network/NetClient.cpp:50:9: note: macro 'LOGNETWORKMESSAGE' defined here
#define LOGNETWORKMESSAGE(msg) LOGMESSAGE(msg)
        ^
../../../source/network/NetClient.cpp:613:3: error: use of undeclared identifier 'LOGNETWORKMESSAGE'
                LOGNETWORKMESSAGE("Rejoining client deserializing state at turn %u\n", turn);
                ^
../../../source/network/NetClient.cpp:719:63: error: too many arguments provided to function-like macro invocation
        LOGNETWORKMESSAGE("Net: Authentication result: host=%u, %s", message->m_HostID, utf8_from_wstring(message->m_Message));
                                                                     ^
../../../source/network/NetClient.cpp:50:9: note: macro 'LOGNETWORKMESSAGE' defined here
#define LOGNETWORKMESSAGE(msg) LOGMESSAGE(msg)
        ^
../../../source/network/NetClient.cpp:719:2: error: use of undeclared identifier 'LOGNETWORKMESSAGE'
        LOGNETWORKMESSAGE("Net: Authentication result: host=%u, %s", message->m_HostID, utf8_from_wstring(message->m_Message));
        ^
1 warning and 8 errors generated.
make[1]: *** [obj/network_Debug/NetClient.o] Error 1
make: *** [network] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/6963/display/redirect

Stan requested review of this revision.May 11 2023, 12:20 PM
Silier added a subscriber: Silier.May 11 2023, 1:18 PM

I am not sure you want to disable everything.
Some are quite useful even in release.

Stan added a comment.May 11 2023, 2:02 PM

@Silier, Ideally I wouldn't have to disable anything... Are they useful for developpers or useful for players?

Stan updated this revision to Diff 21788.May 11 2023, 10:26 PM

Try to fix compilation, reduce duplication.

Vulcan added a comment.May 11 2023, 10:58 PM

Successful build - Chance fights ever on the side of the prudent.

Debug:
     8>tinygettext.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\tinygettext.vcxproj]
    17>wsecure_crt.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>wprofiler.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>manifest.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>secure_crt.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>posix.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>vfs_path.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>file_stats.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
Release:
     7>e:\jenkins\workspace\vs2015-differential\source\network\nethost.cpp(26): warning C4100: 'peerName': unreferenced formal parameter [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\network.vcxproj]
     7>e:\jenkins\workspace\vs2015-differential\source\network\netserver.cpp(289): warning C4390: ';': empty controlled statement found; is this the intent? [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\network.vcxproj]

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8053/display/redirect

Stan added inline comments.May 11 2023, 11:11 PM
source/network/NetHost.cpp
27

peername is now unused.

source/network/NetServer.cpp
289

This is wonky now.

577

Typo.

Vulcan added a comment.May 12 2023, 12:14 AM

Successful build - Chance fights ever on the side of the prudent.

builderr-debug-clang8.txt
In file included from ../../../source/pch/gui/precompiled.h:27:
In file included from ../../../source/gui/ObjectBases/IGUIObject.h:29:
../../../source/gui/SettingTypes/CGUIHotkey.h:37:2: warning: explicitly defaulted move assignment operator is implicitly deleted [-Wdefaulted-function-deleted]
        MOVABLE(CGUIHotkey);
        ^
../../../source/lib/code_annotation.h:237:13: note: expanded from macro 'MOVABLE'
        className& operator=(className&&) = default
                   ^
../../../source/gui/SettingTypes/CGUIHotkey.h:31:20: note: move assignment operator of 'CGUIHotkey' is implicitly deleted because base class 'CGUISimpleSetting<CStr8>' has a deleted move assignment operator
class CGUIHotkey : public CGUISimpleSetting<CStr>
                   ^
../../../source/gui/CGUISetting.h:91:2: note: 'operator=' has been explicitly marked deleted here
        NONCOPYABLE(CGUISimpleSetting);
        ^
../../../source/lib/code_annotation.h:229:13: note: expanded from macro 'NONCOPYABLE'
        className& operator=(const className&) = delete
                   ^
1 warning generated.
In file included from ../../../source/gui/GUIObjectTypes.cpp:30:
../../../source/gui/ObjectTypes/COList.h:37:2: warning: explicitly defaulted move assignment operator is implicitly deleted [-Wdefaulted-function-deleted]
        MOVABLE(COListColumn);
        ^
../../../source/lib/code_annotation.h:237:13: note: expanded from macro 'MOVABLE'
        className& operator=(className&&) = default
                   ^
../../../source/gui/ObjectTypes/COList.h:41:27: note: move assignment operator of 'COListColumn' is implicitly deleted because field 'm_Heading' has a deleted move assignment operator
        CGUISimpleSetting<CStrW> m_Heading; // CGUIString??
                                 ^
../../../source/gui/CGUISetting.h:91:2: note: 'operator=' has been explicitly marked deleted here
        NONCOPYABLE(CGUISimpleSetting);
        ^
../../../source/lib/code_annotation.h:229:13: note: expanded from macro 'NONCOPYABLE'
        className& operator=(const className&) = delete
                   ^
1 warning generated.
In file included from ../../../source/gui/ObjectTypes/COList.cpp:20:
../../../source/gui/ObjectTypes/COList.h:37:2: warning: explicitly defaulted move assignment operator is implicitly deleted [-Wdefaulted-function-deleted]
        MOVABLE(COListColumn);
        ^
../../../source/lib/code_annotation.h:237:13: note: expanded from macro 'MOVABLE'
        className& operator=(className&&) = default
                   ^
../../../source/gui/ObjectTypes/COList.h:41:27: note: move assignment operator of 'COListColumn' is implicitly deleted because field 'm_Heading' has a deleted move assignment operator
        CGUISimpleSetting<CStrW> m_Heading; // CGUIString??
                                 ^
../../../source/gui/CGUISetting.h:91:2: note: 'operator=' has been explicitly marked deleted here
        NONCOPYABLE(CGUISimpleSetting);
        ^
../../../source/lib/code_annotation.h:229:13: note: expanded from macro 'NONCOPYABLE'
        className& operator=(const className&) = delete
                   ^
1 warning generated.
builderr-release-clang8.txt
../../../source/network/NetHost.cpp:26:84: warning: unused parameter 'peerName' [-Wunused-parameter]
bool CNetHost::SendMessage(const CNetMessage* message, ENetPeer* peer, const char* peerName)
                                                                                   ^
1 warning generated.
In file included from ../../../source/pch/gui/precompiled.h:27:
In file included from ../../../source/gui/ObjectBases/IGUIObject.h:29:
../../../source/gui/SettingTypes/CGUIHotkey.h:37:2: warning: explicitly defaulted move assignment operator is implicitly deleted [-Wdefaulted-function-deleted]
        MOVABLE(CGUIHotkey);
        ^
../../../source/lib/code_annotation.h:237:13: note: expanded from macro 'MOVABLE'
        className& operator=(className&&) = default
                   ^
../../../source/gui/SettingTypes/CGUIHotkey.h:31:20: note: move assignment operator of 'CGUIHotkey' is implicitly deleted because base class 'CGUISimpleSetting<CStr8>' has a deleted move assignment operator
class CGUIHotkey : public CGUISimpleSetting<CStr>
                   ^
../../../source/gui/CGUISetting.h:91:2: note: 'operator=' has been explicitly marked deleted here
        NONCOPYABLE(CGUISimpleSetting);
        ^
../../../source/lib/code_annotation.h:229:13: note: expanded from macro 'NONCOPYABLE'
        className& operator=(const className&) = delete
                   ^
1 warning generated.
In file included from ../../../source/gui/GUIObjectTypes.cpp:30:
../../../source/gui/ObjectTypes/COList.h:37:2: warning: explicitly defaulted move assignment operator is implicitly deleted [-Wdefaulted-function-deleted]
        MOVABLE(COListColumn);
        ^
../../../source/lib/code_annotation.h:237:13: note: expanded from macro 'MOVABLE'
        className& operator=(className&&) = default
                   ^
../../../source/gui/ObjectTypes/COList.h:41:27: note: move assignment operator of 'COListColumn' is implicitly deleted because field 'm_Heading' has a deleted move assignment operator
        CGUISimpleSetting<CStrW> m_Heading; // CGUIString??
                                 ^
../../../source/gui/CGUISetting.h:91:2: note: 'operator=' has been explicitly marked deleted here
        NONCOPYABLE(CGUISimpleSetting);
        ^
../../../source/lib/code_annotation.h:229:13: note: expanded from macro 'NONCOPYABLE'
        className& operator=(const className&) = delete
                   ^
1 warning generated.
In file included from ../../../source/gui/ObjectTypes/COList.cpp:20:
../../../source/gui/ObjectTypes/COList.h:37:2: warning: explicitly defaulted move assignment operator is implicitly deleted [-Wdefaulted-function-deleted]
        MOVABLE(COListColumn);
        ^
../../../source/lib/code_annotation.h:237:13: note: expanded from macro 'MOVABLE'
        className& operator=(className&&) = default
                   ^
../../../source/gui/ObjectTypes/COList.h:41:27: note: move assignment operator of 'COListColumn' is implicitly deleted because field 'm_Heading' has a deleted move assignment operator
        CGUISimpleSetting<CStrW> m_Heading; // CGUIString??
                                 ^
../../../source/gui/CGUISetting.h:91:2: note: 'operator=' has been explicitly marked deleted here
        NONCOPYABLE(CGUISimpleSetting);
        ^
../../../source/lib/code_annotation.h:229:13: note: expanded from macro 'NONCOPYABLE'
        className& operator=(const className&) = delete
                   ^
1 warning generated.
builderr-release-gcc7.txt
../../../source/network/NetHost.cpp: In static member function 'static bool CNetHost::SendMessage(const CNetMessage*, ENetPeer*, const char*)':
../../../source/network/NetHost.cpp:26:84: warning: unused parameter 'peerName' [-Wunused-parameter]
 bool CNetHost::SendMessage(const CNetMessage* message, ENetPeer* peer, const char* peerName)
                                                                                    ^~~~~~~~
../../../source/network/NetServer.cpp: In static member function 'static void CNetServerWorker::SetupUPnP()':
../../../source/network/NetServer.cpp:289:103: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
   LOGMESSAGEDEBUG("Net server: attempting to use cached root descriptor URL: %s", rootDescURL.c_str());
                                                                                                       ^
../../../source/network/NetSession.cpp: In member function 'void CNetClientSession::Flush()':
../../../source/network/NetSession.cpp:165:66: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
     LOGMESSAGEDEBUG("NetClient: Failed to send packet to server");
                                                                  ^
In member function 'void CInput::UpdateText(int, int, int)':
cc1plus: warning: 'void* __builtin_memset(void*, int, long unsigned int)': specified size 18446744073709551612 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/8639/display/redirect

Harbormaster completed remote builds in B21868: Diff 21788.May 12 2023, 6:00 AM
Vulcan added a comment.May 12 2023, 6:00 AM

Successful build - Chance fights ever on the side of the prudent.

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(tinygettext.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libglooxwrapper_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libscriptinterface_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel_dbg.a(dbghelp.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel_dbg.a(file_stats.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel_dbg.a(vfs_path.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//IOKit.framework/IOKit.tbd and library file /System/Library/Frameworks//IOKit.framework/IOKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//QuartzCore.framework/QuartzCore.tbd and library file /System/Library/Frameworks//QuartzCore.framework/QuartzCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Metal.framework/Metal.tbd and library file /System/Library/Frameworks//Metal.framework/Metal are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Security.framework/Security.tbd and library file /System/Library/Frameworks//Security.framework/Security are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//OpenAL.framework/OpenAL.tbd and library file /System/Library/Frameworks//OpenAL.framework/OpenAL are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ApplicationServices.framework/ApplicationServices.tbd and library file /System/Library/Frameworks//ApplicationServices.framework/ApplicationServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit.tbd and library file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData.tbd and library file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage.tbd and library file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics.tbd and library file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText.tbd and library file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO.tbd and library file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync.tbd and library file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices.tbd and library file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation.tbd and library file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation.tbd and library file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork.tbd and library file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//IOKit.framework/IOKit.tbd and library file /System/Library/Frameworks//IOKit.framework/IOKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//QuartzCore.framework/QuartzCore.tbd and library file /System/Library/Frameworks//QuartzCore.framework/QuartzCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Metal.framework/Metal.tbd and library file /System/Library/Frameworks//Metal.framework/Metal are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Security.framework/Security.tbd and library file /System/Library/Frameworks//Security.framework/Security are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//OpenAL.framework/OpenAL.tbd and library file /System/Library/Frameworks//OpenAL.framework/OpenAL are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit.tbd and library file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData.tbd and library file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ApplicationServices.framework/Versions/A/ApplicationServices.tbd and library file /System/Library/Frameworks//ApplicationServices.framework/Versions/A/ApplicationServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage.tbd and library file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation.tbd and library file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation.tbd and library file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics.tbd and library file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText.tbd and library file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO.tbd and library file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync.tbd and library file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices.tbd and library file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/Versions/A/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/Versions/A/CoreFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork.tbd and library file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.
builderr-release-macos.txt
../../../source/network/NetHost.cpp:26:84: warning: unused parameter 'peerName' [-Wunused-parameter]
bool CNetHost::SendMessage(const CNetMessage* message, ENetPeer* peer, const char* peerName)
                                                                                   ^
1 warning generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext.a(tinygettext.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libglooxwrapper.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libscriptinterface.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel.a(dbghelp.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel.a(file_stats.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel.a(vfs_path.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//IOKit.framework/IOKit.tbd and library file /System/Library/Frameworks//IOKit.framework/IOKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//QuartzCore.framework/QuartzCore.tbd and library file /System/Library/Frameworks//QuartzCore.framework/QuartzCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Metal.framework/Metal.tbd and library file /System/Library/Frameworks//Metal.framework/Metal are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Security.framework/Security.tbd and library file /System/Library/Frameworks//Security.framework/Security are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//OpenAL.framework/OpenAL.tbd and library file /System/Library/Frameworks//OpenAL.framework/OpenAL are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ApplicationServices.framework/ApplicationServices.tbd and library file /System/Library/Frameworks//ApplicationServices.framework/ApplicationServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit.tbd and library file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData.tbd and library file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage.tbd and library file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics.tbd and library file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText.tbd and library file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO.tbd and library file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync.tbd and library file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices.tbd and library file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation.tbd and library file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation.tbd and library file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork.tbd and library file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//IOKit.framework/IOKit.tbd and library file /System/Library/Frameworks//IOKit.framework/IOKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//QuartzCore.framework/QuartzCore.tbd and library file /System/Library/Frameworks//QuartzCore.framework/QuartzCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Metal.framework/Metal.tbd and library file /System/Library/Frameworks//Metal.framework/Metal are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Security.framework/Security.tbd and library file /System/Library/Frameworks//Security.framework/Security are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//OpenAL.framework/OpenAL.tbd and library file /System/Library/Frameworks//OpenAL.framework/OpenAL are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit.tbd and library file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData.tbd and library file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ApplicationServices.framework/Versions/A/ApplicationServices.tbd and library file /System/Library/Frameworks//ApplicationServices.framework/Versions/A/ApplicationServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage.tbd and library file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation.tbd and library file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation.tbd and library file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics.tbd and library file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText.tbd and library file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO.tbd and library file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync.tbd and library file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices.tbd and library file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/Versions/A/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/Versions/A/CoreFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork.tbd and library file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/6964/display/redirect

Stan added a subscriber: Itms.May 13 2023, 2:12 PM

@Itms any opinion on this?

phosit added a subscriber: phosit.May 13 2023, 5:04 PM

The loging where there for a reason. You should only remove thous who might reveal privat information. eg. the turn number isn't private.

source/network/NetHost.cpp
27

Then mark it [[maybe_unused]]...

Stan added a comment.May 13 2023, 6:15 PM

Actually we're not logging for a reason :D The only logs that I know are useful are the ones we're hiding. I doubt anyone ever uses the turn numbers for anything other than debugging, which is what a debug build is for :P

phosit added a comment.May 13 2023, 6:36 PM

This diff much more then it's suposed to do. (The summary only says something about not revealing information)
Especialy in the FF this shouldn't be done.

sera added a subscriber: sera.May 13 2023, 8:41 PM

The only messages worth censoring are those which an unsuspecting user probably shouldn't share when posting logs for debugging. Any more may just negatively impact the ability to debug issues and to provide help.

Stan updated this revision to Diff 21792.May 13 2023, 10:23 PM

Less suppression. There is almost nothing in the logs anymore anyway since logging messages leaks chat.
But this is a patch I'm forced to make rather than I want to make. So if anyone feels like taking over please do so.

Vulcan added a comment.May 13 2023, 10:27 PM

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-gcc7.txt
../../../source/network/NetHost.cpp:33:5: warning: "NDEBUG" is not defined, evaluates to 0 [-Wundef]
 #if NDEBUG
     ^~~~~~
../../../source/network/NetHost.cpp:35:6: error: #elif with no expression
 #elif
      ^
../../../source/network/NetHost.cpp: In static member function 'static bool CNetHost::SendMessage(const CNetMessage*, ENetPeer*, const char*)':
../../../source/network/NetHost.cpp:27:84: warning: unused parameter 'peerName' [-Wunused-parameter]
 bool CNetHost::SendMessage(const CNetMessage* message, ENetPeer* peer, const char* peerName)
                                                                                    ^~~~~~~~
make[1]: *** [network.make:161: obj/network_Debug/NetHost.o] Error 1
make: *** [Makefile:79: network] Error 2

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/8642/display/redirect

Stan updated this revision to Diff 21793.May 13 2023, 10:32 PM

Fix macro

Vulcan added a comment.May 13 2023, 10:33 PM

Build failure - The Moirai have given mortals hearts that can endure.

Debug:
     8>tinygettext.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\tinygettext.vcxproj]
     7>e:\jenkins\workspace\vs2015-differential\source\network\nethost.cpp(35): fatal error C1017: invalid integer constant expression [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\network.vcxproj]
    17>wsecure_crt.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>wprofiler.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>manifest.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>secure_crt.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>posix.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>vfs_path.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>file_stats.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8056/display/redirect

Vulcan added a comment.May 13 2023, 10:35 PM

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-gcc7.txt
../../../source/network/NetHost.cpp:35:6: error: #elif with no expression
 #elif
      ^
../../../source/network/NetHost.cpp: In static member function 'static bool CNetHost::SendMessage(const CNetMessage*, ENetPeer*, const char*)':
../../../source/network/NetHost.cpp:27:84: warning: unused parameter 'peerName' [-Wunused-parameter]
 bool CNetHost::SendMessage(const CNetMessage* message, ENetPeer* peer, const char* peerName)
                                                                                    ^~~~~~~~
make[1]: *** [network.make:161: obj/network_Debug/NetHost.o] Error 1
make: *** [Makefile:79: network] Error 2

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/8643/display/redirect

Vulcan added a comment.May 13 2023, 10:41 PM

Build failure - The Moirai have given mortals hearts that can endure.

Debug:
     7>e:\jenkins\workspace\vs2015-differential\source\network\nethost.cpp(35): fatal error C1017: invalid integer constant expression [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\network.vcxproj]
     8>tinygettext.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\tinygettext.vcxproj]
    17>wsecure_crt.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>wprofiler.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>manifest.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>secure_crt.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>posix.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>vfs_path.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]
    17>file_stats.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lowlevel.vcxproj]

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8057/display/redirect

Harbormaster completed remote builds in B21873: Diff 21792.May 13 2023, 11:18 PM
Vulcan added a comment.May 13 2023, 11:18 PM

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
../../../source/network/NetHost.cpp:33:5: warning: 'NDEBUG' is not defined, evaluates to 0 [-Wundef]
#if NDEBUG
    ^
../../../source/network/NetHost.cpp:35:6: error: expected value in expression
#elif
     ^
../../../source/network/NetHost.cpp:27:84: warning: unused parameter 'peerName' [-Wunused-parameter]
bool CNetHost::SendMessage(const CNetMessage* message, ENetPeer* peer, const char* peerName)
                                                                                   ^
2 warnings and 1 error generated.
make[1]: *** [obj/network_Debug/NetHost.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [network] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/6967/display/redirect

Vulcan added a comment.May 13 2023, 11:19 PM

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
../../../source/network/NetHost.cpp:35:6: error: expected value in expression
#elif
     ^
../../../source/network/NetHost.cpp:27:84: warning: unused parameter 'peerName' [-Wunused-parameter]
bool CNetHost::SendMessage(const CNetMessage* message, ENetPeer* peer, const char* peerName)
                                                                                   ^
1 warning and 1 error generated.
make[1]: *** [obj/network_Debug/NetHost.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [network] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/6968/display/redirect

Harbormaster completed remote builds in B21874: Diff 21793.May 13 2023, 11:19 PM
Norse_Harold added a subscriber: Norse_Harold.May 15 2023, 9:15 PM

Regarding GDPR regulations, the data isn't personal unless it can be connected back to a real European or UK person by way of other data reasonably available to the data controller. And, the GDPR isn't applicable unless additional lines are crossed by the data controller. Those lines are automated processing of data or storing the data in a structured format (think database records with distinctly labeled columns), and processing the data for other-than personal or household purposes. This is explained in the first few paragraphs of the GDPR, Article 1, which starts on page 32 of the linked PDF. It's easy to verify.

Logs of users and IPs are important for network security and intrusion response forensics. A proposal to remove the feature of logging of IPs from apache webserver would be met with incredulity and laughter unless the server is intended for extreme anonymity such as zero-logging VPNs and bittorrent search sites like Pirate Bay. Every 0ad game hosted by a user is a server, and responsible server administration involves paying attention to who is connecting to the server and intervening when there is abuse. The only way to intervene effectively is for the hoster to know the names and IPs of the users connecting to the server. This way, disruptive users can be effectively banned and/or reported for misconduct.

I advise against merging D4996 as it is written currently. I advise either discontinuing it or adding a user-controlled option to toggle the functionality of D4996 so that the log entries can be quickly restored without requiring rebuilding the game from source code. Only the top 1% of bad actors and top 1% of good actors seem to be willing and able to rebuild the game from source code.

An option to disable logging of certain pieces of information could have benefits for performance as it would reduce the amount of logging activity. In addition to such an option, or instead of it, I would support the display of a message when the user begins hosting, asking if the user plans to do automated processing of the logged data for purposes other than the hoster's own person or household. The message would encourage the hoster to be familiar with data protection laws throughout the world, and formulate and comply with a privacy policy. Privacy policy announcements for hosters could be posted in a forum topic. (Disclaimer: I don't expect new features to be implemented for alpha 27.)

Stan added a comment.May 16 2023, 10:52 AM

Notice this diff also removes the chat leak (as in you can no longer read your opponents chat messages using the mainlog.html) it's not just about removing IPs.

A proposal to remove the feature of logging of IPs from apache webserver would be met with incredulity and laughter unless the server is intended for extreme anonymity such as zero-logging VPNs and bittorrent search sites like Pirate Bay.

Sure, but we're talking about a personal private server here, not one hosted by some public agency.

I advise either discontinuing it or adding a user-controlled option to toggle the functionality

Adding a toggling functionnality would render it useless.

An option to disable logging of certain pieces of information could have benefits for performance as it would reduce the amount of logging activity.

If the check is done at runtime, it will have a penalty cost.

wraitii added a subscriber: wraitii.May 16 2023, 1:37 PM
In D4996#213093, @Stan wrote:

Notice this diff also removes the chat leak (as in you can no longer read your opponents chat messages using the mainlog.html) it's not just about removing IPs.

So long as the users don't use custom binaries, which isn't that much of a stretch IMO at this point.

Stan added a comment.May 16 2023, 2:20 PM

Well so far I haven't seen any player compile the game, install custom mods though, more often.

wraitii added a comment.May 16 2023, 5:30 PM
In D4996#213098, @Stan wrote:

Well so far I haven't seen any player compile the game, install custom mods though, more often.

That could be because it wasn't necessary, but it doesn't mean that we are actually protected. We ultimately have no real way of preventing cheating.
I think it'll ultimately be worth more implementing 'safety rating' / leagues in our MP lobbies and try and filter out bad actors there.

Itms added a comment.May 16 2023, 7:00 PM
In D4996#213057, @Stan wrote:

@Itms any opinion on this?

Here are my two cents on the latest version of the diff (didn't look at past versions) on which people have commented. (TL:DR I am mostly against this diff)

  • This should not be based on whether it is a release/debug builds. A debug build is very slow, nobody would be able to play an MP game with that. I am also against the introduction of a special LOGWARNINGDEBUG thing, it clutters the codebase. Let us keep the user-facing functionality identical in release and in debug.
  • As a consequence, either keep the log message, or remove it. In some cases, I would be OK with commenting out the logging and adding a TODO: this can be re-enabled when #ticket is fixed.
  • I am against removing the log calls in JS. This doesn't prevent anything, as it is trivial for a modder to add them back. The correct fix is not sending chat messages to everyone, only to recipients. This is doable but not trivial, and should be pushed to A28. A ticket should be created.
  • I am leaning against removing the printing of net messages in the engine. They can be useful for us for debugging (see sera's message). If they contain chat messages, see the previous bullet point. If they are duplicates of the messages logged by the scripts upon polling, maybe keep them and remove the log calls in JS instead, in order to reduce the clutter in the scripts. If they contain other sensitive information, let's discuss how to fix that, privately if necessary.
  • I am in favor of removing the IP printing of the server in the client's log. I don't see a situation where this information would help us debugging, since we don't manage the game hosting.
  • I am against removing the IP printing of clients in the server's log. As Harold said, those IPs are needed by the host to perform moderation and to protect against malevolent clients.
  • I am against removing the rest of the printing in the server's log. Everything related to port mapping, redirection, etc. must be logged in order to allow debugging. If sensitive information is publicized by a host when they report a bug, we will have to redact it from our bugtracker, but it is primarily the host's responsibility to handle this information in compliance with GDPR.
Stan abandoned this revision.May 17 2023, 11:43 AM

Alright then. Let's hope for the best. D4775 is something similar although it only prevents sending useless stuff to one of the clients.

Stan updated the Trac tickets for this revision.May 17 2023, 11:44 AM
Stan added a comment.May 17 2023, 11:52 AM

Ticket about commands: #6804

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
gui/
gamesetup/
NetMessages/
2 lines
gamesetup_mp/
3 lines
session/
2 lines
source/
network/
2 lines
5 lines
10 lines
4 lines
ps/
6 lines

Diff 21793

View Options

binaries/data/mods/public/gui/gamesetup/NetMessages/NetMessages.js

Loading...
View Options

binaries/data/mods/public/gui/gamesetup_mp/gamesetup_mp.js

Loading...
View Options

binaries/data/mods/public/gui/session/messages.js

Loading...
View Options

source/network/NetClient.cpp

Loading...
View Options

source/network/NetHost.cpp

Loading...
View Options

source/network/NetServer.cpp

Loading...
View Options

source/network/NetSession.cpp

Loading...
View Options

source/ps/CLogger.h

Loading...
Wildfire Games · Phabricator