HomeWildfire Games

Revert UnitAI changes of r19254 (besides the patrol comment) and use an exotic…

Description

Revert UnitAI changes of r19254 (besides the patrol comment) and use an exotic template instead.
The originally intended approach to support move-orders independent of the Identity classes can be discussed in an independent proposal.

Reviewed By: fatherbushido
Differential Revision: https://code.wildfiregames.com/D176

Details

Event Timeline

Besides using a hack instead of the IMO proper solution that I tried hard to get discussed and reviewed, that commit also broke the map (wolves instakilled by 50 slaughter attack). /me would raise a concern if it were technically possible.

fatherbushido added a subscriber: fatherbushido.EditedMar 28 2017, 2:26 PM

Besides using a hack instead of the IMO proper solution that I tried hard to get discussed and reviewed, that commit also broke the map (wolves instakilled by 50 slaughter attack). /me would raise a concern if it were technically possible.

That exotic template is really not something I would commit.
Imo you have to choose between an violent animal wolf (which could spawned where you want) or a unit wolf.
But as it's in the completly moddable part and doesn't conflic with anything, it's ok for me.
Thanks for considering requests.

;-)

(Thanks^2)

Besides using a hack instead of the IMO proper solution that I tried hard to get discussed and reviewed, that commit also broke the map (wolves instakilled by 50 slaughter attack). /me would raise a concern if it were technically possible.

Neither of us have thought about that when reading and testing the patch I guess. It really has to be fixed if my offer to delete the map is ruled out. Even 3 lone units can survive many wolves when the wolves die before they can deal any damage.

That exotic template is really not something I would commit.
Imo you have to choose between an violent animal wolf (which could spawned where you want) or a unit wolf.

Implies adding an exotic template, just different degrees of exoticness.
I don't think the INDIVIDUAL change, extending INDIVIDUAL by roaming from a trigger script and keeping the the UnitAI behavior depend on an arbitrarily defined Domestic class instead of a more descriptive CanMove will convince me anytime soon, but I will write the code nevertheless after D257. Also the other things I have contested about Domestic behavior (walk implemented, attack implemented, but attack-walk not implemented), missing ability to disable chicken movement and movement of INDIVIDUAL units should also be fixed IMO.
I'll make multiple proposals so we can decide for one and abolish the other, thus being able to lookup the abolished code in the future without having to go through historical revisions of multiple diffs.