Diffusion 0 A.D. Public Repository rP19346

Fix a vertex shader data pielup in the actor editor. It was reloading the…
AuditedrP19346
Actions

Description

Fix a vertex shader data pielup in the actor editor. It was reloading the shaders far too often.
Patch by Echotangoecho.
Differential Revision: https://code.wildfiregames.com/D93

Details

Auditors

elexis

Committed

wraitii

Mar 25 2017, 8:44 AM

Differential Revision

D329: Revert and fix rP19346

Parents

rP19345: Capture The Relic gamemode.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 890
Build 1395: Post-Commit Build	Jenkins

Event Timeline

wraitii committed rP19346: Fix a vertex shader data pielup in the actor editor. It was reloading the….Mar 25 2017, 8:44 AM

Harbormaster completed building B890: rP19346: Fix a vertex shader data pielup in the actor editor. It was reloading the….Mar 25 2017, 10:16 AM

This introduced a bug in atlas:

Start atlas
click on generate (which generates a random map with water)
click on the object tab (the thing with the man icon)

Observation: Water invisible
Expected result: Water not invisible

This commit now has outstanding concerns.Apr 13 2017, 8:00 PM

vladislavbelov added an edge: D329: Revert and fix rP19346.Apr 14 2017, 1:51 PM

wraitii mentioned this in rP19425: Revert and fix rP19346: fix water disappearing in Atlas when clicking on the….Apr 17 2017, 10:59 AM

This should be fixed by rP19425, right?

Didn't review the commit entirely, but the bug that made me raise the concern is indeed fixed by rP19425.
Thanks for the fix and reminder.

All concerns with this commit have now been addressed.Apr 23 2017, 12:06 AM

Changes (2)

Path

Size

ps/

trunk/

source/

renderer/

Renderer.cpp

tools/

atlas/

GameInterface/

ActorViewer.cpp

rP19346

View Options

ps/trunk/source/renderer/Renderer.cpp