HomeWildfire Games

Show all summary values as a graph
AuditedrP19517

Description

Show all summary values as a graph

Reviewed by: bb
Differential Revision: https://code.wildfiregames.com/D144

Details

Auditors
bb
elexis
Committed
ImarokMay 5 2017, 8:52 PM
Reviewer
bb
Differential Revision
D144: Show all summary values as a graph
Parents
rP19516: Correctly center ally command buttons
Branches
Unknown
Tags
Unknown
Build Status
Buildable 1468
Build 2321: Post-Commit BuildJenkins

Event Timeline

bb raised a concern with this commit.May 11 2017, 12:26 AM
bb added a subscriber: bb.
bb added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/StatisticsTracker.js
206

Before the game is started, during loading phase, this.sequences is not yet created, which is fine as long as the game doesn't crash or is closed during loading. Then it will trigger an error, this can be reproduced with ctrl+C during loading phase. It then crashes when trying to make the metaData.json
I guess we need to duplicate updateSequences here.

This commit now has outstanding concerns.May 11 2017, 12:26 AM
elexis added a subscriber: elexis.May 11 2017, 1:14 AM
elexis added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/StatisticsTracker.js
538

We shouldn't have speculation in the code. Are you looking for OnGlobalInitGame?

elexis raised a concern with this commit.May 11 2017, 3:53 PM
elexis added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/StatisticsTracker.js
533

prototype functions should start with a capital letter

elexis added inline comments.May 12 2017, 10:11 PM
/ps/trunk/binaries/data/mods/public/simulation/components/StatisticsTracker.js
533

Fixed by rP19564

538

speculation gone, question remains

elexis added inline comments.May 29 2017, 2:43 AM
/ps/trunk/binaries/data/mods/public/gui/summary/summary.js
170

(Perhaps the trick with the mock GUI objects from D516 can be reused to keep the numbers in XML.)

elexis added inline comments.Jun 9 2017, 2:36 AM
/ps/trunk/binaries/data/mods/public/simulation/components/StatisticsTracker.js
538

refs #4620

Imarok requested verification of this commit.Jun 11 2017, 6:08 PM
This commit now requires verification by auditors.Jun 11 2017, 6:08 PM
elexis accepted this commit.Jun 11 2017, 6:09 PM
elexis added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/StatisticsTracker.js
538

Fixed by rP19765, thanks!

bb accepted this commit.Jun 20 2017, 3:38 PM
All concerns with this commit have now been addressed.Jun 20 2017, 3:38 PM