HomeWildfire Games

Allow walls and fields to be captured by territory but not by capture attack…


Allow walls and fields to be captured by territory but not by capture attack, by using restricted classes. Reviewed by mimo and Imarok.
Differential Revision: https://code.wildfiregames.com/D450

Event Timeline

elexis added a subscriber: elexis.Jun 4 2017, 1:51 AM

On Danubius we can capture the gaia spikes and palisade walls via territory and then gaia destroys it's own defenses following that. We should add a special filter uncapturable, but that still needs AI support.
Could also add special templates for the time being, but that sounds ugly.

bb raised a concern with this commit.Jul 21 2017, 9:30 PM
bb added a subscriber: bb.

When revealing a wall and then making it hidden in FoW again, then when hovering the mouse over the wall (having a unit with capture attack in selection) the capture cursor is shown and when ordering the unit(s) will walk there and then be idle at that building. I guess this is due to some missed values in the mirage or some unmiraged component called.

This commit now has outstanding concerns.Jul 21 2017, 9:30 PM

bb uploaded the patch for his concern at D750.

I might add the concern that on Danubius, gaia destroys its own wooden walls after the player reached age 2 or 3 while the Spikes don't decay (D609).
By the looks of things, some maps like Gallic Fields (3) should have decaying palisade pieces including round edges and spikes, but on other maps like Danubius the templates should not decay.
So using an uncapturable special filter (or map specific templates #4676?) seems the right way to go (besides the fact that we should avoid other/ templates in the build list).

bb added a comment.Aug 16 2017, 8:04 PM

The first concern (about the cursor) is now fixed, leaving the audit for the other concern.

(I wonder if the concern shouldn't be removed now?)

bb accepted this commit.Jun 11 2018, 11:38 PM

Looks like fixed

All concerns with this commit have now been addressed.Jun 11 2018, 11:38 PM