Incorrect cursor when fogging during attack
ClosedPublic
Actions

Authored by bb on Jul 21 2017, 10:07 PM.

Details

Reviewers

mimo
Imarok
fatherbushido

Commits

rP19987: Fix the attack cursor when the target is outside FoW and restrictedClasses are…

Summary

As result of rP19694 when hovering a wall in FoW gives the capture cursor, and ordering results in idle units at the wall.
This is due to a missing mirage component (identity) so the classesList is empty, thus giving restricted classes on mirages doesn't help us.

Test Plan

Try capturing a miraged wall, and see that you fail now.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bb created this revision.Jul 21 2017, 10:07 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1757/ for more details.

Harbormaster completed remote builds in B2622: Diff 2929.Jul 21 2017, 11:38 PM

elexis mentioned this in rP19694: Allow walls and fields to be captured by territory but not by capture attack….Jul 31 2017, 4:56 PM

fatherbushido resigned from this revision.Aug 2 2017, 9:46 PM

Patch is good, and works as expected.

binaries/data/mods/public/simulation/components/Mirage.js
68 ↗	(On Diff #2929)	move the block before the foundation comment, or remove that and following comments.

This revision is now accepted and ready to land.Aug 16 2017, 1:37 PM

Closed by commit rP19987: Fix the attack cursor when the target is outside FoW and restrictedClasses are… (authored by bb). · Explain WhyAug 16 2017, 8:00 PM

This revision was automatically updated to reflect the committed changes.

thx for the review, the comments can be removed imo, but there are more of them and they should be removed all at once so leaving the comment for now.

bb mentioned this in D341: Move undeletable from health to identity.Nov 28 2017, 2:20 PM

temple mentioned this in D1078: Move identity classes to the mirage filter.Nov 28 2017, 8:56 PM

bb mentioned this in rP20573: Move undeletable tag to identity component, preparation for allowing units….Dec 3 2017, 9:55 PM

temple mentioned this in D1325: Fix OOS on rejoin by adding Identity classes to the mirage filter rather than the Mirage component.Feb 23 2018, 8:12 PM