Diffusion 0 A.D. Public Repository rP20322

Fix some style issues noticed by our linter
rP20322
Actions

Description

Fix some style issues noticed by our linter

Reviewed By: bb
Differential Revision: https://code.wildfiregames.com/D585

Details

Committed

Imarok

Oct 21 2017, 7:31 PM

Reviewer

Differential Revision

D585: Fix some style issues noticed by our linter

Parents

rP20321: Add id for IQ stanzas

Branches

Unknown

Tags

Unknown

Build Status

Buildable 3433
Build 5952: Post-Commit Build	Jenkins

Event Timeline

Imarok committed rP20322: Fix some style issues noticed by our linter.Oct 21 2017, 7:31 PM

Harbormaster completed building B3433: rP20322: Fix some style issues noticed by our linter.Oct 21 2017, 8:20 PM

Thanks for the big cleanup!

/ps/trunk/binaries/data/mods/public/gui/common/timer.js
64	sprintf could have been removed instead

elexis mentioned this in rP21659: Use the loading screen for autostart singleplayer/bot matches and replays too….Apr 4 2018, 8:46 PM

Changes (42)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

civinfo/

common/

functions_global_object.js

functions_utility.js

functions_utility_loadsave.js

credits/

gamesetup/

gamesetup_mp/

loading/

lobby/

locale/

manual/

msgbox/

options/

pregame/

backgrounds/

prelobby/

reference/

common/

replaymenu/

savedgames/

session/

selection_panels_helpers.js

summary/

rP20322

View Options

ps/trunk/binaries/data/mods/public/gui/civinfo/civinfo.js

View Options

ps/trunk/binaries/data/mods/public/gui/common/color.js

View Options

ps/trunk/binaries/data/mods/public/gui/common/colorFades.js

View Options

ps/trunk/binaries/data/mods/public/gui/common/functions_civinfo.js

View Options

ps/trunk/binaries/data/mods/public/gui/common/functions_global_object.js

View Options

ps/trunk/binaries/data/mods/public/gui/common/functions_utility.js

View Options

ps/trunk/binaries/data/mods/public/gui/common/functions_utility_loadsave.js

View Options

ps/trunk/binaries/data/mods/public/gui/common/gamedescription.js

View Options

ps/trunk/binaries/data/mods/public/gui/common/music.js

View Options

ps/trunk/binaries/data/mods/public/gui/common/settings.js

View Options

ps/trunk/binaries/data/mods/public/gui/common/timer.js

View Options

ps/trunk/binaries/data/mods/public/gui/common/tooltips.js

View Options

ps/trunk/binaries/data/mods/public/gui/credits/credits.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup_mp/gamesetup_mp.js

View Options

ps/trunk/binaries/data/mods/public/gui/loading/loading.js

View Options

ps/trunk/binaries/data/mods/public/gui/lobby/lobby.js

View Options

ps/trunk/binaries/data/mods/public/gui/locale/locale.js

View Options

ps/trunk/binaries/data/mods/public/gui/locale/locale_advanced.js

View Options

ps/trunk/binaries/data/mods/public/gui/manual/manual.js

View Options

ps/trunk/binaries/data/mods/public/gui/msgbox/msgbox.js

View Options

ps/trunk/binaries/data/mods/public/gui/options/options.js

View Options

ps/trunk/binaries/data/mods/public/gui/pregame/backgrounds/hellenes.js

View Options

ps/trunk/binaries/data/mods/public/gui/pregame/backgrounds/seleucid.js

View Options

ps/trunk/binaries/data/mods/public/gui/pregame/mainmenu.js

View Options

ps/trunk/binaries/data/mods/public/gui/prelobby/prelobby.js

View Options

ps/trunk/binaries/data/mods/public/gui/reference/common/core.js

View Options

ps/trunk/binaries/data/mods/public/gui/replaymenu/replay_actions.js

View Options

ps/trunk/binaries/data/mods/public/gui/replaymenu/replay_filters.js

View Options

ps/trunk/binaries/data/mods/public/gui/savedgames/load.js

View Options

ps/trunk/binaries/data/mods/public/gui/session/menu.js

View Options

ps/trunk/binaries/data/mods/public/gui/session/messages.js

View Options

ps/trunk/binaries/data/mods/public/gui/session/placement.js

View Options

ps/trunk/binaries/data/mods/public/gui/session/selection.js

View Options

ps/trunk/binaries/data/mods/public/gui/session/selection_details.js

View Options

ps/trunk/binaries/data/mods/public/gui/session/selection_panels.js

View Options

ps/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js

View Options

ps/trunk/binaries/data/mods/public/gui/session/session.js

View Options

ps/trunk/binaries/data/mods/public/gui/session/unit_actions.js

View Options

ps/trunk/binaries/data/mods/public/gui/session/unit_commands.js

View Options

ps/trunk/binaries/data/mods/public/gui/summary/layout.js

View Options

ps/trunk/binaries/data/mods/public/gui/summary/summary.js

Fix some style issues noticed by our linterrP20322Actions

Description

Details

Event Timeline

Changes (42)

rP20322

ps/trunk/binaries/data/mods/public/gui/civinfo/civinfo.js

ps/trunk/binaries/data/mods/public/gui/common/color.js

ps/trunk/binaries/data/mods/public/gui/common/colorFades.js

ps/trunk/binaries/data/mods/public/gui/common/functions_civinfo.js

ps/trunk/binaries/data/mods/public/gui/common/functions_global_object.js

ps/trunk/binaries/data/mods/public/gui/common/functions_utility.js

ps/trunk/binaries/data/mods/public/gui/common/functions_utility_loadsave.js

ps/trunk/binaries/data/mods/public/gui/common/gamedescription.js

ps/trunk/binaries/data/mods/public/gui/common/music.js

ps/trunk/binaries/data/mods/public/gui/common/settings.js

ps/trunk/binaries/data/mods/public/gui/common/timer.js

ps/trunk/binaries/data/mods/public/gui/common/tooltips.js

ps/trunk/binaries/data/mods/public/gui/credits/credits.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js

ps/trunk/binaries/data/mods/public/gui/gamesetup_mp/gamesetup_mp.js

ps/trunk/binaries/data/mods/public/gui/loading/loading.js

ps/trunk/binaries/data/mods/public/gui/lobby/lobby.js

ps/trunk/binaries/data/mods/public/gui/locale/locale.js

ps/trunk/binaries/data/mods/public/gui/locale/locale_advanced.js

ps/trunk/binaries/data/mods/public/gui/manual/manual.js

ps/trunk/binaries/data/mods/public/gui/msgbox/msgbox.js

ps/trunk/binaries/data/mods/public/gui/options/options.js

ps/trunk/binaries/data/mods/public/gui/pregame/backgrounds/hellenes.js

ps/trunk/binaries/data/mods/public/gui/pregame/backgrounds/seleucid.js

ps/trunk/binaries/data/mods/public/gui/pregame/mainmenu.js

ps/trunk/binaries/data/mods/public/gui/prelobby/prelobby.js

ps/trunk/binaries/data/mods/public/gui/reference/common/core.js

ps/trunk/binaries/data/mods/public/gui/replaymenu/replay_actions.js

ps/trunk/binaries/data/mods/public/gui/replaymenu/replay_filters.js

ps/trunk/binaries/data/mods/public/gui/savedgames/load.js

ps/trunk/binaries/data/mods/public/gui/session/menu.js

ps/trunk/binaries/data/mods/public/gui/session/messages.js

ps/trunk/binaries/data/mods/public/gui/session/placement.js

ps/trunk/binaries/data/mods/public/gui/session/selection.js

ps/trunk/binaries/data/mods/public/gui/session/selection_details.js

ps/trunk/binaries/data/mods/public/gui/session/selection_panels.js

ps/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js

ps/trunk/binaries/data/mods/public/gui/session/session.js

ps/trunk/binaries/data/mods/public/gui/session/unit_actions.js

ps/trunk/binaries/data/mods/public/gui/session/unit_commands.js

ps/trunk/binaries/data/mods/public/gui/summary/layout.js

ps/trunk/binaries/data/mods/public/gui/summary/summary.js

Fix some style issues noticed by our linter
rP20322
Actions