HomeWildfire Games

Adds a wireframe mode to the water rendering.

Description

Adds a wireframe mode to the water rendering.

Reviewed By: wraitii
Differential Revision: https://code.wildfiregames.com/D769

Event Timeline

elexis added a subscriber: elexis.Nov 8 2017, 2:40 PM

There is an issue with this:
Showing two wireframe models on top of each other makes it very hard to recognize and distinguish them.
If we want to analyze the terrain data, the water frame disturbs and vice versa.

There is something wrong with my river here, but the water wireframe obstructs the view:

There should be a way to trigger which of the wireframe modes is going to be displayed.
The current way is the hotkey. Currently it is a 3 way choice: solid rendering, wireframe, both. There could be a fourth and fifth option (solid, terrain wireframe, terrain+water wireframe, solid+terrain wireframe, solid+terrain+water wireframe).

Sometime the wireframe option should also be displayed in the developer overlay (dropdown).

There is an issue with this:
Showing two wireframe models on top of each other makes it very hard to recognize and distinguish them.
If we want to analyze the terrain data, the water frame disturbs and vice versa.

There is something wrong with my river here, but the water wireframe obstructs the view:

There should be a way to trigger which of the wireframe modes is going to be displayed.
The current way is the hotkey. Currently it is a 3 way choice: solid rendering, wireframe, both. There could be a fourth and fifth option (solid, terrain wireframe, terrain+water wireframe, solid+terrain wireframe, solid+terrain+water wireframe).

Sometime the wireframe option should also be displayed in the developer overlay (dropdown).

The commit only adds the feature. I'll add a more comfortable using later. I also want to improve the developer menu, because we need to control more amount of data (i.e. shadow map).

elexis added a comment.Nov 8 2017, 3:17 PM

(Mostly depicted this use case because code changes that could be perceived as regressions by some stakeholders should be attempted to be considered (written in text or not) in the use case analysis before accepting or committing a revision.)

Indeed its not serious enough for a formal concern..
(I guess we don't need a ticket either, as the use of the feature itself reveals what can be extended and only the time to code that is needed.)