Diffusion 0 A.D. Public Repository rP20965

Cleaning of GetEntityState part 2
rP20965
Actions

Tags

None

Subscribers

Description

Cleaning of GetEntityState part 2

Reviewed By: elexis

Differential Revision: https://code.wildfiregames.com/D1227

Details

Committed

mimo	Jan 22 2018, 7:02 PM

Reviewer

Differential Revision

D1227: Cleaning of GetEntityState part 2

Parents

rP20964: Move Replays from Tools & Options submenu to the main menu

Branches

Unknown

Tags

Unknown

Build Status

Buildable 4616
Build 8046: Post-Commit Build

Event Timeline

mimo committed rP20965: Cleaning of GetEntityState part 2.Jan 22 2018, 7:02 PM

Harbormaster failed to build B4616: rP20965: Cleaning of GetEntityState part 2!Jan 22 2018, 7:02 PM

temple added a subscriber: temple.Jan 23 2018, 5:44 PM

temple added inline comments.

/ps/trunk/binaries/data/mods/public/gui/session/selection_details.js
371–372	WARNING: JavaScript warning: gui/session/selection_details.js line 349 reference to undefined property entState.loot If your multiple selection includes a foundation, since they don't have loot.

mimo mentioned this in rP20982: fix loot warning from rP20965 reported by temple.Jan 23 2018, 6:53 PM

Thanks for the report. Fixed in rP20982

Freagarach mentioned this in D4648: Fix aura tooltips on panel entities..May 16 2022, 7:01 AM

Freagarach mentioned this in rP26896: Fix aura tooltips on panel entities..May 20 2022, 12:00 PM

Changes (4)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

session/

selection_details.js

unit_actions.js

simulation/

components/

GuiInterface.js

tests/

test_GuiInterface.js

rP20965

ps/trunk/binaries/data/mods/public/gui/session/selection_details.js

Loading...

ps/trunk/binaries/data/mods/public/gui/session/unit_actions.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/GuiInterface.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_GuiInterface.js

Loading...