Diffusion 0 A.D. Public Repository rP21071

Make the resource/pop tooltips sortable
rP21071
Actions

Tags

None

Subscribers

ffffffff, elexis

Description

Make the resource/pop tooltips sortable

Patch By: ffffffff
Differential Revision: https://code.wildfiregames.com/D1113

Details

Committed

bb	Jan 30 2018, 12:12 AM

Differential Revision

D1113: Order players by resource or population tooltip numbers

Parents

rP21070: petra cleanup

Branches

Unknown

Tags

Unknown

Build Status

Buildable 4741
Build 8216: Post-Commit Build	Jenkins

Event Timeline

bb committed rP21071: Make the resource/pop tooltips sortable.Jan 30 2018, 12:12 AM

Harbormaster completed building B4741: rP21071: Make the resource/pop tooltips sortable.Jan 30 2018, 1:06 AM

elexis added a subscriber: elexis.Feb 25 2018, 7:26 PM

elexis added inline comments.

/ps/trunk/binaries/data/config/default.cfg
367	Don't use abbreviations as it requires the reader to guess what they could mean. respoptooltipsort -> resourcesTooltipOrder
/ps/trunk/binaries/data/mods/public/gui/options/options.json
133	Everything Used Title Case Before. Resources Tooltip Order?
137	That's ordered by playerID, I guess not relevant.
/ps/trunk/binaries/data/mods/public/gui/session/session.js
1192	Wondering if the hotkey tooltip shouldn't be last, but not important.
/ps/trunk/binaries/data/mods/public/gui/session/top_panel/resources.xml
10	The duplication is other than good.

ffffffff added a subscriber: ffffffff.Feb 27 2018, 5:57 PM

ffffffff added inline comments.

/ps/trunk/binaries/data/config/default.cfg
367	Ok
/ps/trunk/binaries/data/mods/public/gui/options/options.json
133	Ok
/ps/trunk/binaries/data/mods/public/gui/session/session.js
1192	feel ok with it
/ps/trunk/binaries/data/mods/public/gui/session/top_panel/resources.xml
10	function into session.js? changeResPopTooltipSort()?

elexis added inline comments.Feb 27 2018, 5:59 PM

/ps/trunk/binaries/data/mods/public/gui/session/top_panel/resources.xml
10	Yep See my comment earlier on about abbreviations. Sort -> Order. change -> toggle.

elexis mentioned this in D1939: redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb some duplication in the gui.Jul 21 2019, 4:43 AM

bb mentioned this in rP22615: redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb….Aug 5 2019, 4:13 PM

Freagarach mentioned this in D2151: Use "setStringTags"-function more often..Sep 13 2019, 8:52 PM

elexis mentioned this in rP23076: Implement session event subscription system and rewrite TopPanel….Oct 17 2019, 5:10 PM

Changes (7)

				Path	Packages
	M			ps/trunk/binaries/data/config/default.cfg
	M			ps/trunk/binaries/data/mods/public/gui/common/color.js
	M			ps/trunk/binaries/data/mods/public/gui/options/options.json
	M			ps/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js
	M			ps/trunk/binaries/data/mods/public/gui/session/session.js
	M			ps/trunk/binaries/data/mods/public/gui/session/top_panel/resource_population.xml
	M			ps/trunk/binaries/data/mods/public/gui/session/top_panel/resources.xml

rP21071

ps/trunk/binaries/data/config/default.cfg

Loading...

ps/trunk/binaries/data/mods/public/gui/common/color.js

Loading...

ps/trunk/binaries/data/mods/public/gui/options/options.json

Loading...

ps/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js

Loading...

ps/trunk/binaries/data/mods/public/gui/session/session.js

Loading...

ps/trunk/binaries/data/mods/public/gui/session/top_panel/resource_population.xml

Loading...

ps/trunk/binaries/data/mods/public/gui/session/top_panel/resources.xml

Loading...