HomeWildfire Games
Diffusion 0 A.D. Public Repository rP21250

Small StatisticsTracker test
AuditedrP21250
Actions

Description

Small StatisticsTracker test

Reviewed by: elexis
Differential Revision: https://code.wildfiregames.com/D1305

Details

Auditors
elexis
Committed
ImarokFeb 18 2018, 11:50 AM
Reviewer
elexis
Differential Revision
D1305: Small StatisticsTracker test
Parents
rP21249: [Windows] Automated build.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 5027
Build 8651: Post-Commit BuildJenkins

Event Timeline

Imarok committed rP21250: Small StatisticsTracker test.Feb 18 2018, 11:50 AM
Harbormaster failed to build B5027: rP21250: Small StatisticsTracker test!Feb 18 2018, 12:43 PM
elexis raised a concern with this commit.Feb 18 2018, 2:35 PM
This commit now has outstanding concerns.Feb 18 2018, 2:35 PM
Itms added a subscriber: Itms.Feb 18 2018, 2:42 PM

For this issue, Jenkins didn't correctly parse the test results (because the previous step which is running the tests failed) - this is fixed now, for next time.

Imarok mentioned this in rP21253: Fix the test added in rP21250.Feb 18 2018, 4:48 PM
elexis accepted this commit.Feb 18 2018, 4:54 PM
elexis added a subscriber: elexis.

thanks, rP21253

All concerns with this commit have now been addressed.Feb 18 2018, 4:54 PM
elexis added inline comments.Oct 21 2019, 10:28 AM
/ps/trunk/binaries/data/mods/public/simulation/components/tests/test_StatisticsTracker.js
25

I guess a review where review means explicit verification would have found that 29 should be [29] and {7] should have been [7, 29], unless the purpose of this was to ensure that invalid data is not reported on? Sounds more like an oversight, refs D2384

elexis mentioned this in D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.Oct 21 2019, 10:35 AM
elexis mentioned this in rP23086: Remove hardcoding and quadruplication of the StatisticsTracker unit and….Oct 21 2019, 10:48 AM

Changes (1)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
components/
tests/

rP21250

View Options

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_StatisticsTracker.js

Loading...
Wildfire Games · Phabricator