Diffusion 0 A.D. Public Repository rP21785

Stop some auras from being applied extra times, don't apply player auras to…
rP21785
Actions

Description

Stop some auras from being applied extra times, don't apply player auras to templates, and fix some linting errors

Differential Revision: https://code.wildfiregames.com/D1430
Comments by: fatherbushido, elexis

Details

Committed

temple

Apr 26 2018, 2:35 AM

Differential Revision

D1430: Fix some auras not being removed

Parents

rP21784: Fix a couple of packing problems from rP21630

Branches

Unknown

Tags

Unknown

Build Status

Buildable 5974
Build 9965: Post-Commit Build	Jenkins

Event Timeline

temple committed rP21785: Stop some auras from being applied extra times, don't apply player auras to….Apr 26 2018, 2:35 AM

Harbormaster completed building B5974: rP21785: Stop some auras from being applied extra times, don't apply player auras to….Apr 26 2018, 3:40 AM

(I wonder why that thing https://trac.wildfiregames.com/wiki/SubmittingPatches#Makingsomechanges was written ; I post that randomly here)

Did you add new tests for the changed methods or did you just fix the existing ?

/ps/trunk/binaries/data/mods/public/simulation/components/tests/test_Auras.js
17	Some of the above could probably have been made const in the process.

In rP21785#30453, @Stan wrote:

Did you add new tests for the changed methods or did you just fix the existing ?

Some new (which would fail without the changes).

elexis mentioned this in D1559: Disable AIInterface earlier.Jun 4 2018, 11:06 AM

elexis mentioned this in D1513: Prevent players from dropping during map generation.Jun 4 2018, 11:09 AM

elexis mentioned this in rP21842: Prevent players from disconnecting during the loading screen by increasing the….Jun 7 2018, 12:10 AM

Changes (2)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

components/

Auras.js

tests/

test_Auras.js

rP21785

View Options

ps/trunk/binaries/data/mods/public/simulation/components/Auras.js