Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.
Fixes #5376, refs #2394.
Differential Revision: https://code.wildfiregames.com/D1991
Patch By: Krinkle
Comments By: Vladislav, wraitii
Description
Description
Details
Details
- Auditors
Krinkle - Committed
elexis Jul 16 2019, 11:52 PM - Differential Revision
- D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions
- Parents
- rP22486: Rename "CauseSplashDamage" to the more generic "CauseDamageOverArea"
- Branches
- Unknown
- Tags
- Build Status
Buildable 8407 Build 13736: Trigger Windows Autobuild Build 13735: Post-Commit Build Jenkins
Event Timeline
| /ps/trunk/source/simulation2/scripting/EngineScriptConversions.cpp | ||
|---|---|---|
| 35 | Usually we use underscores between words in macros, no? Also probably it's not obvious for all, that it returns immediately. | |
| /ps/trunk/source/simulation2/scripting/EngineScriptConversions.cpp | ||
|---|---|---|
| 35 | Not returning here is an error on my part. Do I understand correctly that it still makes it return by other means? If so, what are those means? I've looked at STMT but that doesn't seem to return or throw. And JS_ReportError() as a regular call would need to throw to abort correctly, which as far as I could see, it doesn't do (assuming ScriptInterface::ErrorReporter is indeed the callback we use when this code runs). | |