Make Promotion.js use the common Transform helper, add resource gatherer and promotion to said helper.
Fixes #4334
Differential Revision: https://code.wildfiregames.com/D2026
Description
Description
Details
Details
- Committed
wraitii Aug 22 2019, 7:25 PM - Differential Revision
- D2026: Make Promotion.js use the common Transform helper
- Parents
- rP22752: Replace the horse rein with a less basic version
- Branches
- Unknown
- Tags
- Build Status
Buildable 9008 Build 14757: Post-Commit Build Jenkins
Event Timeline
Comment Actions
r22777
Turn 3513 (500)... WARNING: JavaScript warning: simulation/components/Promotion.js line 83 reference to undefined property this.promotedUnitEntity WARNING: JavaScript warning: simulation/components/Promotion.js line 83 Script value conversion check failed: v.isNumber() (got type undefined) WARNING: JavaScript warning: simulation/components/Promotion.js line 83 Script value conversion check failed: v.isNumber() (got type undefined)
If I was to guess I'd say it's related to entity death.
Comment Actions
Thanks for the fix. It would be good to compare the implementation against the paste some day.
Comment Actions
https://trac.wildfiregames.com/ticket/5610#comment:6
Thanks for the fix. It would be good to compare the implementation against the paste some day.
Or the new implementation against the removed implementation.
| /ps/trunk/binaries/data/mods/public/simulation/helpers/Transform.js | ||
|---|---|---|
| 65 | Actually this should take care of the order transfer. I have no idea why it fails, but apparently it was already broken before? I'll check it. | |
Comment Actions
Was broken because previously the cheer order was added first and the rest of the orders thereafter. As per this commit that order was reversed, and the (faulty) cmpUnitAI.Cheer() did not push an order to the front but it replaced all orders (which it should not). D2358.