Make Promotion.js use the common Transform helper, add resource gatherer and promotion to said helper.
Fixes #4334
Differential Revision: https://code.wildfiregames.com/D2026
Make Promotion.js use the common Transform helper, add resource gatherer and…
Description
Details
Event TimelineComment Actions r22777 Turn 3513 (500)... WARNING: JavaScript warning: simulation/components/Promotion.js line 83 reference to undefined property this.promotedUnitEntity WARNING: JavaScript warning: simulation/components/Promotion.js line 83 Script value conversion check failed: v.isNumber() (got type undefined) WARNING: JavaScript warning: simulation/components/Promotion.js line 83 Script value conversion check failed: v.isNumber() (got type undefined) If I was to guess I'd say it's related to entity death. Comment Actions Thanks for the fix. It would be good to compare the implementation against the paste some day. Comment Actions https://trac.wildfiregames.com/ticket/5610#comment:6
Or the new implementation against the removed implementation.
Comment Actions Was broken because previously the cheer order was added first and the rest of the orders thereafter. As per this commit that order was reversed, and the (faulty) cmpUnitAI.Cheer() did not push an order to the front but it replaced all orders (which it should not). D2358. |