I don't see a valid reason that Promotion should be an exception, but I could have missed it.
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
- Trac Tickets
I anybody knows of said good reason, please comment. Otherwise this is relatively straightforward.
|0 ms||Jenkins > cxxtest_debug.xml::[failed-to-read]|
Failed to read test report file /mnt/data/jenkins-phabricator/workspace/differential/cxxtest_debug.xml org.dom4j.DocumentException: Error on line 1 of document : Content is not allowed in prolog. Nested exception: Content is not allowed in prolog. at org.dom4j.io.SAXReader.read(SAXReader.java:482)
|0 ms||Jenkins > TestAllocators::test_da|
|0 ms||Jenkins > TestAtlasObjectXML::test_parse_attributes1|
|0 ms||Jenkins > TestAtlasObjectXML::test_parse_attributes2|
|0 ms||Jenkins > TestAtlasObjectXML::test_parse_basic|
|View Full Test Results (1 Failed · 322 Passed)|
Transform.js got added in rP18467 to enable upgrading, as transform.js is meant to be generic and should be able to perform any change of template, this change makes should make things more clean and easier to handle.
Notice that we now also carry over the capturable data, which is a good thing (it didn't harm anything up to now since there is no unit that can promote and be captured)
that seems to be missing in tranform.js
we still need that call
Thanks for giving this a look, indeed we should validate that all checks done here are also done in Transform, and perhaps check which checks done in Transform aren't done here.
The experience value might not need to be passed here depending on how IncreaseXP does things, so we'll need to be careful.
Adding tests for Promotion sounds good. We should also add static checking for serialisation.