HomeWildfire Games

Match unit classes with templates names

Description

Match unit classes with templates names

Remove Spear class from pikemen templates.
Give Macedonian Gastraphetes Crossbowman class, as it is a special unit.
Give Kushite Clubman the Clubman class, again a special unit.
Make FishingBoat a visible class.
Introduce Bireme, Trireme and Quinquereme visible classes.
Remove Melee class from Maurya Trireme.
Move Organic to template_unit as most units have it, remove it in appropriate children templates.
List VisibleClasses directly after Classes.
Rename:

  • Axe -> Axeman
  • Javelin -> Javelinist
  • Pike -> Pikeman
  • Sling -> Slinger
  • Spear -> Spearman
  • Sword -> Swordsman
  • Catapult -> StoneThrower

Correct other simulation files accordingly.

Patch By: Nescio

Reviewed By: wraitii

Differential Revision: https://code.wildfiregames.com/D1815

Details

Committed
wraitiiSep 1 2019, 4:08 PM
Reviewer
wraitii
Differential Revision
D1815: match unit classes with templates
Parents
rP22823: legionnaire → legionary (3)
Branches
Unknown
Tags
Unknown
Build Status
Buildable 9166
Build 15052: Post-Commit BuildJenkins

Event Timeline

@Nescio this commit is probably totally unrelated, but in the replay uploaded at https://code.wildfiregames.com/rP22006#37234 we got a report from faction02:

After nani resigned, I also noticed that when clicking on his gaia skirms, we could see three buildings to build: military colony, Library and a third one that I don't remember.

(It says "palisades" in the chatlog from that match)

Does that possibly ring a bell?

Nescio added a comment.Sep 2 2019, 7:23 PM

Sorry, I don't understand what you mean, or what I'm supposed to say. Could you rephrase your question?
This patch improved the classes consistency of unit templates; structures are unchanged.
The colony and library templates were last touched by D1759/rP22256, but that was four months ago.

elexis added a comment.Sep 2 2019, 7:50 PM

I was mostly wondering whether you remember an a24 template patch that changed the build list entries. But I tested on alpha 23 and the issue occurs there too. So I've reported it more properly at #5581.

Nescio added a comment.Sep 2 2019, 8:19 PM

Interesting. It seems those structures listed aren't random, though: they're just the ones defined in the specific templates (see e.g. rome_infantry_javelinist_b.xml), without the ones they inherit from their parents (esp. template_unit_infantry.xml). Perhaps it's a problem with the observer GUI or something?

Nescio added a comment.Sep 2 2019, 8:26 PM

Or perhaps an even simpler explanation: gaia_house doesn't exist, brit_crannog does. And palisades are gaia structures shared by all civs, so they show up too.