HomeWildfire Games

Allow artists to add upgrade animations.

Description

Allow artists to add upgrade animations.
Reviewed by: @Angen

Differential Revision: https://code.wildfiregames.com/D2371

Details

Committed
StanNov 24 2019, 12:34 PM
Reviewer
Silier
Differential Revision
D2371: Allow to play upgrade animations
Parents
rP23184: Move CGUI constructor to the top of its file following rP9.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 10111
Build 17136: Post-Commit BuildJenkins

Event Timeline

elexis raised a concern with this commit.Jan 7 2020, 6:15 PM
elexis added a subscriber: elexis.

The upgrading animation is cancelled if a tech research is started.

I'm not sure if it even makes sense to allow researching techs while upgrading, since the upgraded structure might not provide that technology.

This commit now has outstanding concerns.Jan 7 2020, 6:15 PM
Nescio added a subscriber: Nescio.Jan 7 2020, 6:25 PM

Entities shouldn't be able to train or research anything while (un)packing or being upgraded. Was that introduced here?

Silier added a comment.EditedJan 7 2020, 6:32 PM

The upgrading animation is cancelled if a tech research is started.

I'm not sure if it even makes sense to allow researching techs while upgrading, since the upgraded structure might not provide that technology.

That would be this one correctly rP23239. Correct solution would be to use different keys for these animation variants so they cannot be cancelled by others. [Edit: would not, that are just animations, no variants]

Entities shouldn't be able to train or research anything while (un)packing or being upgraded. Was that introduced here?

No here are just animations.

elexis removed an auditor: elexis.Jan 7 2020, 6:35 PM
This commit no longer requires audit.Jan 7 2020, 6:35 PM