HomeWildfire Games

Enable garrisoning on gates / fix movement of units with visible garrison points
AuditedrP23710

Description

Enable garrisoning on gates / fix movement of units with visible garrison points

This addresses two related issues:

  • Units visibly garrisoned on gates keep the gate open.
  • Units visibly garrisoned on entities keep their pathfinding blocker flags.

Remove the block-movement flag from visibly garrisoned entities.
Keep a list of entities that cannot move and thus should not count towards gate-opening logic.

Packing logic is kept separate: it is more related to entities having 'alternate forms' with different capabilities than being currently incapable of moving.

Based on work by temple

Comments by: Freagarach

Tested by: Nescio

Fixes #2679
Fixes #5151

Differential Revision: https://code.wildfiregames.com/D1418

Event Timeline

Angen raised a concern with this commit.May 31 2020, 10:56 AM
Angen added a subscriber: Angen.

Start game with iberians.
Update long wall to gate.
Move unit through gate.
It will never ever close back.

This commit now has outstanding concerns.May 31 2020, 10:56 AM
Nescio added a subscriber: Nescio.May 31 2020, 12:36 PM

Tested by: Nescio

For the record, I don't believe I actually tested D1418; that would have involved rebuilding the source code. What I did was comment that I liked the concept, and ask for its current status.

Tested by: Nescio

For the record, I don't believe I actually tested D1418; that would have involved rebuilding the source code. What I did was comment that I liked the concept, and ask for its current status.

Ah, I assumed you did because of D2760 which only works with the patch.

wraitii requested verification of this commit.May 31 2020, 8:17 PM

Start game with iberians.
Update long wall to gate.
Move unit through gate.
It will never ever close back.

For the record this only happened with skirmish-placeholder walls.

Changes reverted in rP23714, see D2775 for the renewed diff.

This commit now requires verification by auditors.May 31 2020, 8:17 PM
Angen accepted this commit.Jun 6 2020, 6:48 PM
All concerns with this commit have now been addressed.Jun 6 2020, 6:48 PM