Diffusion 0 A.D. Public Repository rP23710

Enable garrisoning on gates / fix movement of units with visible garrison points
AuditedrP23710
Actions

Description

Enable garrisoning on gates / fix movement of units with visible garrison points

This addresses two related issues:

Units visibly garrisoned on gates keep the gate open.
Units visibly garrisoned on entities keep their pathfinding blocker flags.

Remove the block-movement flag from visibly garrisoned entities.
Keep a list of entities that cannot move and thus should not count towards gate-opening logic.

Packing logic is kept separate: it is more related to entities having 'alternate forms' with different capabilities than being currently incapable of moving.

Based on work by temple

Comments by: Freagarach

Tested by: Nescio

Fixes #2679
Fixes #5151

Differential Revision: https://code.wildfiregames.com/D1418

Details

Auditors

Silier

Committed

wraitii

May 30 2020, 11:18 AM

Differential Revision

D1418: Enable garrisoning on gates / fix movement of units with visible garrison points

Parents

rP23709: Do not compute capture points for the invalid player on player defeat

Branches

Unknown

Tags

Unknown

Reverted By

rP23714: Revert rP23708, rP23710 and rP23711

Build Status

Buildable 11863
Build 22166: Trigger Windows Autobuild
Build 22165: Post-Commit Build	Jenkins
Build 22164: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP23710: Enable garrisoning on gates / fix movement of units with visible garrison points.May 30 2020, 11:18 AM

wraitii added an edge: D1418: Enable garrisoning on gates / fix movement of units with visible garrison points.

Harbormaster completed building B11863: rP23710: Enable garrisoning on gates / fix movement of units with visible garrison points.May 30 2020, 11:37 AM

wraitii mentioned this in D2367: Move the ability to hold a turret to a separate file..May 30 2020, 12:45 PM

wraitii mentioned this in D2646: Remove special Animal state..May 30 2020, 2:47 PM

wraitii mentioned this in rP23711: Hotfix for rP23710 - remove the OnEntityRenamed handling..May 30 2020, 4:26 PM

Start game with iberians.
Update long wall to gate.
Move unit through gate.
It will never ever close back.

This commit now has outstanding concerns.May 31 2020, 10:56 AM

wraitii added a reverting change: rP23714: Revert rP23708, rP23710 and rP23711.May 31 2020, 12:07 PM

Tested by: Nescio

For the record, I don't believe I actually tested D1418; that would have involved rebuilding the source code. What I did was comment that I liked the concept, and ask for its current status.

In rP23710#42505, @Nescio wrote:

Tested by: Nescio

For the record, I don't believe I actually tested D1418; that would have involved rebuilding the source code. What I did was comment that I liked the concept, and ask for its current status.

Ah, I assumed you did because of D2760 which only works with the patch.

wraitii mentioned this in D1445: Make structures not block construction.May 31 2020, 7:59 PM