Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP24161

Store turret positions in map files.
rP24161
Actions

Tags

None

Subscribers

Description

Store turret positions in map files.

Follow up on r23529/rP23529. Allows saving turret positions in the map file, instead of relying on the order in which the entities are added.

Differential Revision: D2614
Reviewed by: @wraitii
Comments by: @Angen, @bb, @vladislavbelov.

Details

Committed

Nov 11 2020, 8:40 PM

Reviewer

Differential Revision

D2614: Also store turret position in map file.

Parents

rP24160: Removes additional depth texture copying and reusing existing refraction depth.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 13580
Build 27609: Trigger Windows Autobuild
Build 27608: Post-Commit Build	Jenkins
Build 27607: Post-Commit Build (macOS)	Jenkins

Event Timeline

Freagarach committed rP24161: Store turret positions in map files..Nov 11 2020, 8:40 PM

Freagarach added an edge: D2614: Also store turret position in map file..

Freagarach added subscribers: Silier, vladislavbelov, bb, wraitii.

Harbormaster failed to build B13580: rP24161: Store turret positions in map files.!Nov 11 2020, 8:48 PM

vladislavbelov added inline comments.Nov 11 2020, 8:49 PM

/ps/trunk/source/graphics/MapReader.cpp
958	Useless space in `> >`.
1026	In case of automatic deduction for `std::make_pair` it'd be more clear to use `emplace_back`: Turrets.emplace_back(attrs.GetNamedItem(at_turret), attrs.GetNamedItem(at_uid).ToInt());
1081	You don't need `Turrets` content anymore, you can move it instead of copying.
/ps/trunk/source/graphics/MapWriter.cpp
364	Useless space in `> >`.

Freagarach mentioned this in D3096: Fix notes in rP24161..Nov 11 2020, 9:00 PM

Refs. #2984, #3008.

Freagarach mentioned this in rP24542: Fix some C++-style notes from r24161..Jan 11 2021, 12:26 PM

Changes (9)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

maps/

simulation/

components/

TurretHolder.js

interfaces/

TurretHolder.js

source/

graphics/

simulation2/

components/

ICmpTurretHolder.cpp

ICmpTurretHolder.h

rP24161

ps/trunk/binaries/data/mods/public/maps/scenario.rnc

Loading...

ps/trunk/binaries/data/mods/public/maps/scenario.rng

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/TurretHolder.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/interfaces/TurretHolder.js

Loading...

ps/trunk/source/graphics/MapReader.cpp

Loading...

ps/trunk/source/graphics/MapWriter.cpp

Loading...

ps/trunk/source/simulation2/TypeList.h

Loading...

ps/trunk/source/simulation2/components/ICmpTurretHolder.cpp

Loading...

ps/trunk/source/simulation2/components/ICmpTurretHolder.h

Loading...