HomeWildfire Games

Fix VisualActor tech changes for mirages


Fix VisualActor tech changes for mirages

Correctly recompute the actor when something changes that could modify it (ownership change, ...).
Make sure mirages are updated when they reappear after being hidden.
Make sure foundations have proper identity classes.
Make sure mirages don't respond to value modifications in the visual component.
Clarify a few comments.

Earlier work by: Sandarac

Fixes #2907

Differential Revision: https://code.wildfiregames.com/D576

Event Timeline

s0600204 raised a concern with this commit.Dec 7 2020, 6:48 AM

Adding the Identity class to the special/filter/construction template has also pulled in the identity classes, leading to the side effect of meaning that construction|... entities now count toward entity limits.

As a an example, it is no longer necessary to fully build five village phase structures to unlock the "Town Phase" technology: simply placing the foundations and starting construction works.

Reported by @wowgetoffyourcellphone on the forum: https://wildfiregames.com/forum/topic/34104-entities-unlocked-before-prerequisite-is-finished-being-built/

This commit now has outstanding concerns.Dec 7 2020, 6:48 AM
Stan added a subscriber: Stan.Dec 18 2020, 2:07 AM

Can you confirm it's fixed @s0600204?

wraitii requested verification of this commit.Dec 18 2020, 9:19 AM
This commit now requires verification by auditors.Dec 18 2020, 9:19 AM
s0600204 accepted this commit.Dec 20 2020, 10:22 PM
All concerns with this commit have now been addressed.Dec 20 2020, 10:22 PM