Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP24489

Remove SSE detection duplication in Colors and ModelRenderer
rP24489
Actions

Description

Remove SSE detection duplication in Colors and ModelRenderer

Rename macros to be more explicit
Move detection code to a separate file
Remove a lot of checks in ARB mode (ModelDef.cpp would check for sse multiple times per frame)
Make explicit the SSE2 dependency for Windows

Comments by: @vladislavbelov @wraitii @OptimusShepard

Differential Revision: https://code.wildfiregames.com/D3212

Details

Committed

Stan	Dec 31 2020, 4:37 PM

Differential Revision

D3212: Remove SSE duplication in Colors and ModelRenderer

Parents

rP24488: Add missing files in Phab:rP24487

Branches

Unknown

Tags

Unknown

Build Status

Buildable 14676
Build 31384: Trigger Windows Autobuild
Build 31383: Post-Commit Build	Jenkins
Build 31382: Post-Commit Build (macOS)	Jenkins

Event Timeline

Stan committed rP24489: Remove SSE detection duplication in Colors and ModelRenderer.Dec 31 2020, 4:37 PM

Stan added an edge: D3212: Remove SSE duplication in Colors and ModelRenderer.

Stan added subscribers: OptimusShepard, vladislavbelov, wraitii.

Harbormaster completed building B14676: rP24489: Remove SSE detection duplication in Colors and ModelRenderer.Dec 31 2020, 6:38 PM

vladislavbelov added inline comments.Jan 2 2021, 2:55 PM

/ps/trunk/source/graphics/ModelDef.h
278	I suppose `extern` is not needed here, since the function isn't used in a separate modules/libraries.

vladislavbelov added inline comments.Jan 20 2021, 7:09 PM

/ps/trunk/source/lib/sse.h
1	I think it's the wrong place for such header, since it's platform dependent. It should be in `source/lib/sysdep/x86_x64` and similar.

Changes (10)

Path

Size

ps/

trunk/

build/

premake/

premake5.lua

source/

graphics/

lib/

sysdep/

ps/

GameSetup/

GameSetup.cpp

renderer/

ModelRenderer.cpp

rP24489

View Options

ps/trunk/build/premake/premake5.lua

View Options

ps/trunk/source/graphics/Color.cpp

View Options

ps/trunk/source/graphics/Color.h

View Options

ps/trunk/source/graphics/ModelDef.cpp

View Options

ps/trunk/source/graphics/ModelDef.h

View Options

ps/trunk/source/lib/sse.cpp

View Options

ps/trunk/source/lib/sse.h

View Options

ps/trunk/source/lib/sysdep/compiler.h

View Options

ps/trunk/source/ps/GameSetup/GameSetup.cpp

View Options

ps/trunk/source/renderer/ModelRenderer.cpp

Remove SSE detection duplication in Colors and ModelRendererrP24489Actions

Description

Details

Event Timeline

Changes (10)

rP24489

ps/trunk/build/premake/premake5.lua

ps/trunk/source/graphics/Color.cpp

ps/trunk/source/graphics/Color.h

ps/trunk/source/graphics/ModelDef.cpp

ps/trunk/source/graphics/ModelDef.h

ps/trunk/source/lib/sse.cpp

ps/trunk/source/lib/sse.h

ps/trunk/source/lib/sysdep/compiler.h

ps/trunk/source/ps/GameSetup/GameSetup.cpp

ps/trunk/source/renderer/ModelRenderer.cpp

Remove SSE detection duplication in Colors and ModelRenderer
rP24489
Actions