Diffusion 0 A.D. Public Repository rP25368

Let entity react on target death directly.
AuditedrP25368
Actions

Description

Let entity react on target death directly.

Don't let entities waste a repeat time when they've killed their target.
Done by storing a list of attackers in cmpResistance (since that cmp is obligatory anyway).

Differential revision: https://code.wildfiregames.com/D2129
Comments by: @Angen, @wraitii

Details

Auditors

Committed

Freagarach

May 4 2021, 7:18 AM

Differential Revision

D2129: Let entity react on target death directly.

Parents

rP25367: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 17040
Build 39098: Post-Commit Build	Jenkins
Build 39097: Post-Commit Build (macOS)	Jenkins

Event Timeline

Freagarach committed rP25368: Let entity react on target death directly..May 4 2021, 7:18 AM

Freagarach added an edge: D2129: Let entity react on target death directly..

Freagarach added subscribers: Silier, wraitii.

Harbormaster completed building B17040: rP25368: Let entity react on target death directly..May 4 2021, 7:29 AM

wraitii mentioned this in D4001: Fix CanAttack for mirages following rP25465.May 22 2021, 10:18 AM

wraitii mentioned this in rP25517: Fix CanAttack for mirages following rP25465.May 22 2021, 12:57 PM

bb raised a concern with this commit.Sep 5 2021, 11:30 PM

bb added a subscriber: bb.

bb added inline comments.

/ps/trunk/binaries/data/mods/public/simulation/components/Attack.js
458–461	Same concern as reased in rP25465 pops up here: attack a mirage with some ranged units (archers vs cc worked for me) and you will see that the units that arrive first try to capture (since the become idle) other than use the ranged attack (when giving the ranged attack order). I guess we need to replace the target by the parent in case it is a mirage for the entire function here. Reminds me of rP24005.

This commit now has outstanding concerns.Sep 5 2021, 11:30 PM

Freagarach added inline comments.Sep 9 2021, 6:50 PM

/ps/trunk/binaries/data/mods/public/simulation/components/Attack.js
458–461	The problem is if you add the attacker to the parent, and the parent dies, the attacker will stop attacking. I guess we need to also mock this function in the mirage and query that?