Freagarach May 4 2021, 7:18 AM
- Differential Revision
- D2129: Let entity react on target death directly.
- rP25367: [Windows] Automated build.
- Build Status
Buildable 17040 Build 39098: Post-Commit Build Jenkins Build 39097: Post-Commit Build (macOS) Jenkins
Same concern as reased in rP25465 pops up here: attack a mirage with some ranged units (archers vs cc worked for me) and you will see that the units that arrive first try to capture (since the become idle) other than use the ranged attack (when giving the ranged attack order).
I guess we need to replace the target by the parent in case it is a mirage for the entire function here. Reminds me of rP24005.
The problem is if you add the attacker to the parent, and the parent dies, the attacker will stop attacking. I guess we need to also mock this function in the mirage and query that?