Diffusion 0 A.D. Public Repository rP25850

Update Available mods when installing them
AuditedrP25850
Actions

Tags

None

Subscribers

Description

Update Available mods when installing them

Differential revision: D4211

Since rP25546 available mods where cached and not updated when new where installed.
Fixing above.

Details

Auditors

Langbart
Stan

Committed

Aug 17 2021, 7:32 PM

Differential Revision

D4211: Update Available mods when installing them

Parents

rP25849: Fix gui objects failing on undefined in modmod

Branches

Unknown

Tags

Unknown

Build Status

Buildable 18161
Build 42572: Trigger Windows Autobuild
Build 42571: Post-Commit Build	Jenkins
Build 42570: Post-Commit Build (macOS)	Jenkins

Event Timeline

Silier added an edge: D4211: Update Available mods when installing them.Aug 17 2021, 8:34 PM

Silier committed rP25850: Update Available mods when installing them.Aug 17 2021, 7:32 PM

Freagarach added a subscriber: Freagarach.Aug 17 2021, 9:51 PM

Freagarach added inline comments.

/ps/trunk/source/ps/Mod.cpp

Mod.cpp
../../../source/ps/Mod.cpp: In member function ‘bool Mod::EnableMods(const ScriptInterface&, const std::vector<CStr8>&, bool)’:
../../../source/ps/Mod.cpp:139:45: warning: unused parameter ‘scriptInterface’ [-Wunused-parameter]
  139 | bool Mod::EnableMods(const ScriptInterface& scriptInterface, const std::vector<CStr>& mods, const bool addPublic)
      |                      ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~

Harbormaster completed building B18161: rP25850: Update Available mods when installing them.Aug 17 2021, 11:03 PM

This commit now has outstanding concerns.Aug 20 2021, 2:34 PM

Silier mentioned this in D4220: Fix downloanded mods not showing in list until restart.Aug 20 2021, 4:59 PM

A problem with "non-visual" replay has been detected. #6288

In rP25850#53552, @Langbart wrote:

A problem with "non-visual" replay has been detected. #6288

Silier mentioned this in rP25853: Fix downloanded mods not showing in list until restart.Aug 22 2021, 11:59 AM

Stan accepted this commit.Aug 23 2021, 6:20 PM

All concerns with this commit have now been addressed.Aug 23 2021, 6:20 PM

Changes (4)

Path

Size

ps/

trunk/

source/

ps/

GameSetup/

rP25850

ps/trunk/source/main.cpp

Loading...

ps/trunk/source/ps/GameSetup/GameSetup.cpp

Loading...

ps/trunk/source/ps/Mod.cpp

Loading...

ps/trunk/source/ps/Mod.h

Loading...