HomeWildfire Games

Make formations respond as one to threats.

Description

Make formations respond as one to threats.

Improves their functioning significantly.

Based on a patch by @lyv
Differential revision: https://code.wildfiregames.com/D4666
Reviewed by: @marder
Comments by: @Stan

Event Timeline

Not really a concern, but a note:
This doesn't work while the formation has an attack-move command -> then only the units react who are in sight of the threat, while the rest of the formation stand still and waits for them to return.

Yeah, that was already the case before this patch.

Grapjas raised a concern with this commit.EditedAug 7 2022, 1:42 PM
Grapjas added a subscriber: Grapjas.

This unfortunately breaks units responding properly to enemy units while in formation. Reported on the forum (read from that point and onwards). Video of the behavior

This commit now has outstanding concerns.Aug 7 2022, 1:42 PM
Freagarach requested verification of this commit.Aug 8 2022, 9:14 AM
This commit now requires verification by auditors.Aug 8 2022, 9:14 AM

What is expected from "This commit now requires verification by auditors."?

marder added a comment.Aug 8 2022, 6:57 PM

What is expected from "This commit now requires verification by auditors."?

That the auditor/ person raising the concern tries out the newest revision which includes the fix (in this case the removal of this code) and see if the problem described is now gone/ solved.

Yeah but isn't that on a different page? What do i need to do here?

Stan added a comment.Aug 8 2022, 7:21 PM

Either accept or resign from the revision.

marder added a comment.Aug 8 2022, 7:22 PM

ah that's what you meant.
Yeah what Stan said, same button, just accept again if its ok.

Grapjas resigned from this commit.Aug 8 2022, 7:28 PM
This commit no longer requires audit.Aug 8 2022, 7:28 PM